
There's only one case I can think of where I'd want to see the above dialog: when I actually MADE A CHANGE and then pressed Esc. However, there are two cases where the dialog pops up which makes it EXTREMELY annoying:
- Create a new Text element (but don't type anything) and press Esc. Revit should just cancel the creation (as expected), even if a leader was created (but especially if there's none). Pressing Esc usually indicates that you want to cancel the command. Revit should do so. Promptly.
- Edit an existing Text element (but don't make any changes) and press Esc. There's no changes to keep, so why is it asking?
If you click outside the Text box (instead of clicking Esc) for either of the cases above, then no dialog is presented. However, this would require unnecessary retraining. Also, if a leader is created in a new (empty) Text element, clicking outside it now keeps the leader (with blank text) instead of requiring you to actually type in an invisible character (so clicking outside the text box is not a viable workaround to cancel the creation in many cases).
This is a change in 2017+ (2016 and earlier versions behave properly). Revit should honor Esc!