Script with IF statements stopping once it gets a positive result
Consider using a list and the function foreach, might as well check the status of the layer if its off, then turned it on
(foreach layername '("EO-Pr6070-M-LightingFeederPillar"
"EO-Pr6070-M-LightingFeederPillar2DView"
"EO-Pr6070-M-LightingFeederPillar3DView"
)
(if (and
(setq status (tblsearch "layer" layername))
(minusp (Cdr (assoc 62 status))))
(command "-LAYER" "_on" layername "" "_y")
)
)
HTH
@Mark.HarrisBGNSX wrote:
.... the layers don't always exist, so traditional -layer commands would stall when the script comes across a layer it doesn't see. ....
No it won't. A message will go by that it didn't find the Layer(s), but it will just return to the regular prompt, just as if the Layer(s) did exist. And your "_y" entries don't fit the prompts that will be issued -- they'll be taken as a new command, and you'll get an unknown-command message, which probably explains your "stops once it gets to" issue. [Did that get dragged in from copying a Layer command turning off all Layers, in which you would be asked whether you really want the current Layer off?]
Another problem is your nesting of (command) functions inside other (command) functions.
As for the 'nil' at the conclusion, the (command) function always returns nil [read about it in the AutoLisp Reference] -- that doesn't mean it didn't work.
This will do what you want, whether or not any of the Layers exist:
(command "_.LAYER" "_on" "EO-Pr6070-M-LightingFeederPillar,EO-Pr6070-M-LightingFeederPillar2DView,EO-Pr6070-M-LightingFeederPillar3DView" "")
(prin1) ;; this [or (princ) or (print), any with no arguments] will suppress the 'nil' return [read about that, too].
EDIT:
If those are all your Layers that start that way, you can shortcut the multiple names with a wildcard standing in for any following string content:
(command "_.LAYER" "_on" "EO-Pr6070-M-LightingFeederPillar*" "")
[By the way, that's not a Script -- that word has a specific and different (though related) meaning in AutoCAD.]
@pbejse wrote:
.... might as well check the status of the layer if its off, then turned it on ....
That's utterly unnecessary. Just turn them all on, and it won't matter whether any of them are already on, nor will it matter whether they even exist in the drawing. See Message 4.
@john.kaulB9QW2 wrote:
....
(command "_.LAYER" "_on" "EO-Pr6070-M-LightingFeederPillar*" "") (command "_.LAYER" "_thaw" "EO-Pr6070-M-LightingFeederPillar*" "") (command "_.LAYER" "_unlock" "EO-Pr6070-M-LightingFeederPillar*" "") .......
Are you [and others] aware that you can combine as many Layer options as you want into one Layer command?
(command "_.LAYER"
"_on" "EO-Pr6070-M-LightingFeederPillar*"
"_thaw" "EO-Pr6070-M-LightingFeederPillar*"
"_unlock" "EO-Pr6070-M-LightingFeederPillar*"
""
)or even:
(setq lname "EO-Pr6070-M-LightingFeederPillar*")
(command "_.LAYER" "_thaw" lname "_on" lname "_unlock" lname "")
@john.kaulB9QW2 wrote:
....
.... ;; - Iterate the layers and make sure proper settings are in place. (mapcar (function (lambda (lyrname) (layerActions (+ *On* *Thaw* *Unlock* *PlotOn*) lyrname))) lyrs ) ;...This is clear....
... only if you also have the additional code required to define the (layeractions) function.
@john.kaulB9QW2 wrote:
I gave it to you here: ....
So you did. So ignoring comment lines, you're up to over 30 lines of code to do what can be done in two or so, which to me seems a strange definition of "concise."
And I disagree about the error-proneness of using wildcards. They simply need to be used correctly, just as AutoLisp functions, answers to command prompts, etc. need to be used correctly -- those are just as error-prone if not done right.
What i posted is more about the OP question, “stopping once … “
I included the “check status” thingy as a suggestion to what can be done in case the code requires additional evaluation.
Looking at post #5, we can say that it did help, we leave it to @Mark.HarrisBGNSX to decide what you describe as “utterly unnecessary”
just be happy for the OP will you.
