Community
Some thoughts:
In the Layer business at the end, except for the Truecolor, the properties you're setting to them are defaults, so you don't need to set them. And if you're setting CMDECHO to 0 regardless and at the end to 1 regardless, just do that -- no need to test the value, nor to use a variable. And since the properties you're setting to the Layers are the same, you can do that to more than one Layer together with a comma-delimited string of Layer names. I think this is all you need:
(setq layernames "PV Mechanical Obstructions,PV Misc Obstructions")
(setvar 'cmdecho 0)
(command "_.layer" "_new" layernames "_color" "_truecolor" "0,0,0" layernames "")
(setvar 'cmdecho 1)Do you really need a Truecolor version of Black? If you work with a white background, color 7 is the same, and it's the default for new Layers, so you don't need to assign it, so you can do just:
(setvar 'cmdecho 0)
(command "_.layer" "_new" "PV Mechanical Obstructions,PV Misc Obstructions" "")
(setvar 'cmdecho 1)Only if those Layers may already exist with non-default color or transparency or lineweight, and you want to correct those properties, do you need to assign them.
Likewise with CMDECHO outside the Layer part, the only place you use your cmdEcho variable is here:
(if (= (getvar "CMDECHO") 0)
(setvar "CMDECHO" cmdEcho)
)so you "reset" it only if it's 0. But it will always be 0 at that point, because either you set it that way earlier if it was 1, or it was already 0. You set it into the variable only if it was 1. Presumably after you're done you will want command-echoing to operate. So again, I would simply set it to 0 at the beginning regardless, and set it to 1 at the end, and forget the variable.
This:
(setq pointList (list))does nothing for you. A "list" with nothing in it is not even a list at all -- it's nothingness, nonexistent [i.e. nil]. You could set it to nil instead of to (list), but don't bother -- just put it in the localized variables list at the top and it will be nil to begin with for purposes of the routine. BUT you don't build the equivalent pointlist if there's no pre-selection, only if there is, but in any case, I don't see that you use the pointlist variable anywhere, so....?
You don't need to step through an any-kind-of-thing selection and check the entity type of each thing to decide whether to remove it. You can limit selection to only those kinds of things you want:
(if (ssget "_I") ; if there is a currently active selection set:
; then, get only wanted things from it:
(setq ss (ssget "_I" '((0 . "LINE,LWPOLYLINE,ARC"))))
(progn ; else
(setq
pt1 (getpoint "\nSpecify first corner: ")
pt2 (getcorner pt1 "\nSpecify opposite corner: ")
)
(setq ss (ssget "_C" pt1 pt2 '((0 . "LINE,LWPOLYLINE,ARC"))))
)
)
Kent Cooper, AIA 
How about doing that SetByLayer thing to the original selection set, before you go through it to Offset etc.?
Kent Cooper, AIA
@Jonathan_Bell82GXG wrote:
There still has to be a way to update the selection set to reflect the changed entities. ....
Not if everything in the selection you want to update was already processed before any of the joining/offsetting changes happen -- you won't need to do anything more to them, so you won't need to update the selection.
Kent Cooper, AIA
@Jonathan_Bell82GXG wrote:
.... The code should not make any changes to the already existing entities aside from joining them. ....
As for that, I assumed otherwise from this line in the original:
(setq ss (ssget "_C" pt1 pt2)) ; update ssUsing the same selection area, without filtering the selection at all, would find all the source things as well as the new ones, and it then goes into the ByLayer setting operation on everything in that set.
But if that's now commented out.... I suspect the easiest thing would be to collect the Offset-result objects as you go -- make an initially empty selection set with (ssadd), and after each successful Offset, use (ssadd) again to put (entlast) into that set.
Kent Cooper, AIA
Forums Links
Can't find what you're looking for? Ask the community or share your knowledge.
Post to forums
