Hatchedit only changes one

[C.Utzinger]

 HI

I have the following code, but the Problem is it works only for one hatch. If I select more than one, then only the last selected one changes.

What can I do?

(defun c:<Test5 ( / *error* layr cmd SPIhatch)

	(defun *error* (errmsg)
    	   (if (not (wcmatch errmsg "Function cancelled,quit / exit abort,console break"))
      	   (princ (strcat "\nError: " errmsg)))
    	   (setvar 'CLAYER layr)
    	   (setvar 'CMDECHO cmd)
	   (command-s "_.undo" "_end")
    	   (princ "\n"))

;------------------------------------------------

     	(setq layr (getvar 'CLAYER)
              cmd (getvar 'CMDECHO))	
	
	(setq SPIhatch (ssget "I"))

	(if (not SPIhatch)
		 (progn
		   (command "_.undo" "_begin")
		   (setvar 'CMDECHO 0)
  		   (command "_.-LAYER" "_m" "-I-Schraffur" "_co" "8" "-I-Schraffur" "")
		   (setvar 'HPNAME "NET")
		   (command "_.-bhatch" "_l" "-I-Schraffur" "_p" "NET" "2" "0" "_a" "_h" "_y" "_a" "_y" "" "_co" "bylayer" "_n" "")
		   (setvar 'CMDECHO 1)
		   (command "_.-bhatch") 
		   (while (> (getvar "cmdactive") 0) (command pause))
		   (setvar 'CLAYER lay)
  		   (setvar 'CMDECHO cmd)
		   (command "_.undo" "_end")
		   (prin1))
		
		 (progn
		   (command "_.undo" "_begin")
  		   (command "_.-LAYER" "_m" "-I-Schraffur" "_co" "8" "-I-Schraffur" "")
		   (command "_.-hatchedit" SPIhatch "_p" "NET" "2" "0")
		   (command "_.-hatchedit" SPIhatch "LA" "-I-Schraffur")
		   (setvar 'CLAYER layr)
  		   (setvar 'CMDECHO cmd)
		   (prompt "\nSchraffur angepasst und auf Layer -I-Schraffur gewechselt!")
		   (command "_.undo" "_end")
  		   (princ)) 
	)
) ;_ end of defun

[hencoop]

Put the commands in a WHILE loop for the length of the selection set.

(defun c:<Test5 ( / *error* layr cmd SPIhatch)

	(defun *error* (errmsg)
    	   (if (not (wcmatch errmsg "Function cancelled,quit / exit abort,console break"))
      	   (princ (strcat "\nError: " errmsg)))
    	   (setvar 'CLAYER layr)
    	   (setvar 'CMDECHO cmd)
	   (command-s "_.undo" "_end")
    	   (princ "\n"))

;------------------------------------------------

     	(setq layr (getvar 'CLAYER)
              cmd (getvar 'CMDECHO))	
	
	(setq SPIhatch (ssget "I"))

	(if (not SPIhatch)
		 (progn
		   (command "_.undo" "_begin")
		   (setvar 'CMDECHO 0)
  		   (command "_.-LAYER" "_m" "-I-Schraffur" "_co" "8" "-I-Schraffur" "")
		   (setvar 'HPNAME "NET")
		   (command "_.-bhatch" "_l" "-I-Schraffur" "_p" "NET" "2" "0" "_a" "_h" "_y" "_a" "_y" "" "_co" "bylayer" "_n" "")
		   (setvar 'CMDECHO 1)
		   (command "_.-bhatch") 
		   (while (> (getvar "cmdactive") 0) (command pause))
		   (setvar 'CLAYER lay)
  		   (setvar 'CMDECHO cmd)
		   (command "_.undo" "_end")
		   (prin1))
		
		 (progn
		   (command "_.undo" "_begin")
  		   (command "_.-LAYER" "_m" "-I-Schraffur" "_co" "8" "-I-Schraffur" "")
                   (SETQ cnt 0)
                   (WHILE (< cnt (SSLENGTH SPIhatch))
		     (command "_.-hatchedit" (SSNAME SPIhatch cnt) "" "_p" "NET" "2" "0")
		     (command "_.-hatchedit" (SSNAME SPIhatch cnt) "" "LA" "-I-Schraffur")
                     (SETQ cnt (1+ cnt))
                   )
		   (setvar 'CLAYER layr)
  		   (setvar 'CMDECHO cmd)
		   (prompt "\nSchraffur angepasst und auf Layer -I-Schraffur gewechselt!")
		   (command "_.undo" "_end")
  		   (princ)) 
	)
) ;_ end of defun

[C.Utzinger]

Sorry but does not work!

[hencoop]

what does it do?

[C.Utzinger]

Just the same. Only the last hatch of the selection gets changed.

[hencoop]

I'm sorry, bonehead blunder on my part.

I forgot to replace SPIhatch with (SSNAME SPIhatch cnt) ""

I updated my code post... try it now.

[C.Utzinger]

Sorry but it doesn't work!

Now ist difficult to explain was it does

Only one changes the pattern, but not the layer. And then the Routine stops saying that the pattern is incorrect. Really strange!

Thank you by the way...

[C.Utzinger]

Now it works

Take away the "" after (SSNAME SPIhatch cnt)!!!

[hencoop]

I think the remaining problem is in the command sequence.

step through the command at the command line taking note of each input required.

When you are asked to select the hatch that is where (SSNAME SPIhatch cnt) belongs in your code.

there needs to be a termination of the selection which is "" right after (SSNAME SPIhatch cnt) in the code.

Carefully replicate the required input in your code until you are returned to the command prompt for each command sequence.

I think that will fix it.

[C.Utzinger]

This way it works perfect

Post the complete code and I accept it as solution.

		     (command "_.-hatchedit" (SSNAME SPIhatch cnt) "_p" "NET" "2" "0")
		     (command "_.-hatchedit" (SSNAME SPIhatch cnt) "LA" "-I-Schraffur")

[hencoop]

Good catch!  I use a different setting for the PICK variables than you use.

[hencoop · Accepted solution]

As you requested:

(defun c:<Test5 ( / *error* layr cmd SPIhatch)

	(defun *error* (errmsg)
    	   (if (not (wcmatch errmsg "Function cancelled,quit / exit abort,console break"))
      	   (princ (strcat "\nError: " errmsg)))
    	   (setvar 'CLAYER layr)
    	   (setvar 'CMDECHO cmd)
	   (command-s "_.undo" "_end")
    	   (princ "\n"))

;------------------------------------------------

     	(setq layr (getvar 'CLAYER)
              cmd (getvar 'CMDECHO))	
	
	(setq SPIhatch (ssget "I"))

	(if (not SPIhatch)
		 (progn
		   (command "_.undo" "_begin")
		   (setvar 'CMDECHO 0)
  		   (command "_.-LAYER" "_m" "-I-Schraffur" "_co" "8" "-I-Schraffur" "")
		   (setvar 'HPNAME "NET")
		   (command "_.-bhatch" "_l" "-I-Schraffur" "_p" "NET" "2" "0" "_a" "_h" "_y" "_a" "_y" "" "_co" "bylayer" "_n" "")
		   (setvar 'CMDECHO 1)
		   (command "_.-bhatch") 
		   (while (> (getvar "cmdactive") 0) (command pause))
		   (setvar 'CLAYER lay)
  		   (setvar 'CMDECHO cmd)
		   (command "_.undo" "_end")
		   (prin1))
		
		 (progn
		   (command "_.undo" "_begin")
  		   (command "_.-LAYER" "_m" "-I-Schraffur" "_co" "8" "-I-Schraffur" "")
                   (SETQ cnt 0)
                   (WHILE (< cnt (SSLENGTH SPIhatch))
		     (command "_.-hatchedit" (SSNAME SPIhatch cnt) "_p" "NET" "2" "0")
		     (command "_.-hatchedit" (SSNAME SPIhatch cnt) "LA" "-I-Schraffur")
                     (SETQ cnt (1+ cnt))
                   )
		   (setvar 'CLAYER layr)
  		   (setvar 'CMDECHO cmd)
		   (prompt "\nSchraffur angepasst und auf Layer -I-Schraffur gewechselt!")
		   (command "_.undo" "_end")
  		   (princ)) 
	)
) ;_ end of defun

[C.Utzinger]

Which Pick variable?

I will try, and perhaps fix the correct one in the Routine!

Thank you very much!

[hencoop]

There is not a "correct" setting.  It is a user preference.  The different settings can change the required command line input when making selections.  All that is necessary is to make the command line input match the current selection sequence.  To make the routine work regardless of the settings you would capture the value of the pick variables that are involved (I would not know which are without experimenting with them) and set them to values that work for your command sequence and then reset them at the end of the program.

My current settings are (COMMAND "SETVAR" "?" "PICK*"):

PICKADD 2
PICKAUTO 5
PICKBOX 5
PICKDRAG 2
PICKFIRST 1
PICKSTYLE 1

[C.Utzinger]

I have another Problem with the code.

It crashes when you have selected some hatches and an other object (line).

I tryed to fix this, but it only works if I only select one object (line):

(if (ssget "I" '((0 . "HATCH")))(setq SPIhatch (ssget "I"))(alert "Keine Schraffur gewählt"))

Can you help me?

[hencoop]

It appears that you do not need to select anything but hatches.  Is that correct?

If so, I can tailor the SSGET function to only allow selection of hatch objects to solve the problem.

[C.Utzinger]

Yes i need only to get hatches...

Thank in advance

[hencoop]

change this line

(setq SPIhatch (ssget "I"))

make it this

(setq SPIhatch (ssget "I" '((0 . "HATCH"))))

 Or, this is you want it to prompt you to select them

(setq SPIhatch (ssget '((0 . "HATCH"))))

I've got to run.  I'll pick it up tomorrow if you still need some fixing

[C.Utzinger]

HI

No, I want to Change them directly without prompt.

So with your second code it work fine without braking the Routine:

(setq SPIhatch (ssget "I" '((0 . "HATCH"))))

Now it would be great if there comes some alert saying that there were other objects than hatches...

Can you fix this??? I tried some, but nothing worked...

[hencoop]

with this SSGET code:

(setq SPIhatch (ssget "I" '((0 . "HATCH"))))

your selection is filtered to only select the hatches.  It cannot select anything else.