U Shaped function
@Sea-Haven wrote:
....
Enter length, enter height, that's all that is needed.
.... and extrusion thickness. [If that's what you meant by "height," then some other term like "width" of the pre-extruded shape is also needed.]
@rpajounia wrote:
... i cant really make all these shapes 1 by 1 which is why im asking for a lisp and not trying to manually make each object. ... i dont have the time to make them 1 by 1.
If they're not all the same shape so they could just be Copied, a routine is going to need inputs for each one, anyway, so there must be some sort of "1 by 1" aspect to the process. What is the source of the particulars for each shape? Would you give the dimensions for each shape, and have the routine just do the forming and extrusion of it? Are they in something like a spreadsheet file that a routine could read them from? What would be the criteria for the location of each one? Are all the shapes of the same kind of "D" shape as in your image, but with differences in sizes/proportions, or are there different varieties of shapes? If all "D" shaped, could it be done with a Block and different scale factors? Etc., etc.
EDIT: >Here< is something that could give you some idea how to approach the "D" shape, requiring not-too-complicated adjustment to achieve that rather than the shape it makes:
You would also need to decide the orientation of the "D" shape -- as a "D", or [assuming it is done by drawing a Polyline] with the half-circle arc segment on some side other than the right, such as the bottom [given the Topic wording]? Having determined that, and given dimensions and a starting point, a PLINE command with some (polar) functions, and switching between line and arc segments, and with calculations about the line segment lengths tangent to the arc segment, would not be difficult to construct.
There are other things in my previous reply that you will need to address before you can complete a full routine.
@rpajounia wrote:
Orientation doesnt really matter i want to give 2 variables, 1 is the bottom line length, 2 is the height of the arc
Given your "bottom line" wording, I'll assume the arc segment on the top [upside-down U, closed]. And I will assume that variable 2 is the height of the arc segment itself plus the length of the vertical line segments tangent to it, that connect it to the bottom line [since for this shape, the height of the arc segment itself must be half the bottom line length, so it would not need to be specified]. There should probably be a check that the specified height is at least half the specified bottom line length. If it is exactly half the bottom line length, there would be no vertical line segments, and the whole Polyline would be just one line segment and one arc segment.
@Kent1Cooper wrote:
@rpajounia wrote:
.... i want to give 2 variables, 1 is the bottom line length, 2 is the height of the arc
Given your "bottom line" wording, I'll assume the arc segment on the top [upside-down U, closed]. And I will assume that variable 2 is the height of the arc segment itself plus the length of the vertical line segments tangent to it....
Like this?
That would not be a difficult thing to program a PLINE command to draw, and an extrusion thickness could also be included easily enough if you change your mind from "( thickness does not matter )" in Message 6 back to something like your original image. But the questions remain about where those values are coming from for all the multiple shapes, how they should be positioned relative to each other, etc.
It sounds from more than one of your Messages like you have a routine going already with some of what you want to do. Adding to it, have it read a line from the text file [what is the format of the information?], start a PLINE command presumably at 0,0, go right by the base dimension, up by the height minus half the base dimension, get into Arc mode and go left by the base dimension, get back into Line mode and Close. Do you know how to add code to do that kind of thing?
@rpajounia wrote:
Im making an automated lisp ....
....my lisp file is reading a text file....
yes please
Those first two are what suggest to me that you have something started. There's no point in our starting from scratch if it will duplicate what you have already. Post that in addition to the sample text file that @Sea-Haven requested.
What was the third line above in reply to?
@rpajounia wrote:
.... I would like x = 10 y = 10 z = 5 ....
That does not help unless you intend to type in values individually for all the shapes, which Message 3 says you do not. You have mentioned, but [after several requests] not yet posted an example of, a text file from which the values would be read, nor have we seen whatever code you have already.
@rpajounia wrote:.... (if (<= (read Width) 72) (progn (if (= (read Thickness) 1) (progn (ssadd (_circl (* (read Width) 12.7)) 1InchList) ) ) (if (= (read Thickness) 2) (progn (ssadd (_circl (* (read Width) 12.7)) 2InchList) ) ) (if (= (read Thickness) 3) (progn (ssadd (_circl (* (read Width) 12.7)) 3InchList) ) ) (if (= (read Thickness) 4) (progn (ssadd (_circl (* (read Width) 12.7)) 4InchList) ) ) (if (= (read Thickness) 5) (progn (ssadd (_circl (* (read Width) 12.7)) 5InchList) ) ) (if (= (read Thickness) 6) (progn (ssadd (_circl (* (read Width) 12.7)) 6InchList) ) ) ) (progn (if (= (read Thickness) 1) (progn (ssadd (_circl (* (read Width) 12.7)) 1InchList84x96) ) ) (if (= (read Thickness) 2) (progn (ssadd (_circl (* (read Width) 12.7)) 2InchList84x96) ) ) (if (= (read Thickness) 3) (progn (ssadd (_circl (* (read Width) 12.7)) 3InchList84x96) ) ) (if (= (read Thickness) 4) (progn (ssadd (_circl (* (read Width) 12.7)) 4InchList84x96) ) ) (if (= (read Thickness) 5) (progn (ssadd (_circl (* (read Width) 12.7)) 5InchList84x96) ) ) (if (= (read Thickness) 6) (progn (ssadd (_circl (* (read Width) 12.7)) 6InchList84x96) ) ) ) ) ....
We still haven't seen the nature of the content of the text file you're pulling information from.
But in any case, your code can be greatly reduced in a variety of ways.
You have unnecessary (progn) "wrappers" around things that don't need them [single functions -- mostly (ssadd) -- used as 'then' arguments in (if) functions, where (progn) is needed only when multiple functions together are needed as the single 'then' or 'else' argument].
You have conversions of strings to non-text that you don't need, such as:
(if (= (read Thickness) 1)
when you could just do:
(if (= Thickness "1")
You have multiple (if) functions that would be better handled with (cond) functions [but the following would eliminate a lot of that anyway].
Any time the same code is repeated multiple times, there's probably a way to reconfigure things to contain it fewer times, or even just once. One of the more extreme examples is that [I believe -- untested] the entire excerpt quoted above can be replaced with just this:
(ssadd
(_circl (* (read Width) 12.7))
(read (strcat Thickness "InchList" (if (> (read Width) 72) "84x96" "")))
)
and similarly for the "Trap" portion and the (_rect) portion if it's not "Circle" or "Trap."
Speaking of which, if you use a RECTANG command, it's not necessary to convert points between the current UCS and the WCS, nor to convert them to XY only coordinates, nor to calculate the other two corners. Your (_circ1) function doesn't specify model space or Layer 0 as the (_rect) and (_trap) functions do, so if I can assume you are there when you run this, or it doesn't really matter if the objects are just drawn on the current Layer, you should be able to replace the (_rect) function with just this:
(defun _rect (p1 p2)
(command "_.rectang" "_non" p1 "_non" p2)
(setq q (entlast))
)
Yes, it "takes longer," but you would need to be making a very large number of them for that to make a meaningful difference.
