LISP - CIRCLE
Accepted solution
Welcome to these Forums!
The thing I noticed first is that the localized variables in parentheses after the command name need to be after a slash:
(DEFUN c:HMMM (/ CNT DIAM)
After that, assuming that fixes it, there are other things you could do to streamline it. For instance, since you are doing exactly the same Circle command no matter which option the User chooses, that can be in there only once, as can the (setq) function for the 'DIAM' variable if you put the (cond) function inside it:
(SETQ CNT (GETPOINT "\nselect circle center"))
;click the center of the circle
(INITGET "1Pul 2Pul")
(SETQ PUL (GETKWORD "\n1Pul, 2Pul:"))
;do not write the real diameter number
(setq DIAM
(cond
((= PUL "1Pul") 0.033401)
((= PUL "2Pul") 0.060325)
); cond
); setq
(command "circle" CNT "D" DIAM)
(PRINC)
)
BUT, I'm finding a curiosity related to numbers as initial characters in (initget) string arguments. I was thinking that if you don't capitalize the P, the User can type just the 1 or 2, instead of needing to also type the P, to get the option they want. But oddly, even if you leave it capitalized, I find I still need to type only the 1 or 2. So you might consider not capitalizing the P in the (getkword) prompt, and people [who know how these things work] will know they don't have to type more than the 1 or 2.
Kent Cooper, AIA 
@john.uhden wrote:
The problem is that you named your local variables as input arguments
Make that... (DEFUN c:HMMM ( / CNT DIAM) ^ Add the slash (and spaces)
[Just to get overly picky about it.... You do need that space between the slash and the localized variable names, but in this case not the one before the slash. If you define a function [without the C: to make it a command name], and if that function has both arguments before the slash and localized variables after it, then you need a space between the last argument and the slash, but when there are no arguments, you don't need it before the slash.]
Kent Cooper, AIA
@scot-65 wrote:
.... numbers/fractions are difficult to make a selection from.
....
Another way to go about that kind of thing is with stand-in letters for different numerical values. Here's an excerpt from a routine of mine that offers choices for some standard insulation thicknesses [US sizes, Imperial units], setting a global *ibthick* variable [the "ib" part is for Insulation Batting]. It also allows entering a numerical value that isn't one of its built-in choices, if that's something you might need.
(initget (if *ibthk* 6 7) "A B C D"); no Enter on first use, no 0, no negative
(setq
thktemp
(getdist
(strcat
"\nThickness of insulation batting, or [A=3.5/B=5.5/C=9.5/D=12]"
(if *ibthk* (strcat " <" (rtos *ibthk* 2 2) ">") ""); default only if not first use
": "
); end strcat
); end getdist & thktemp
*ibthk*
(cond
((= thktemp "A") 3.5)
((= thktemp "B") 5.5)
((= thktemp "C") 9.5)
((= thktemp "D") 12.0)
((numberp thktemp) thktemp); user entered number or picked distance
(T *ibthk*); otherwise, user hit Enter - keep value
); end cond & *ibthk*
); end setq
Kent Cooper, AIA
Could it be the missing right parenthesis?
(command "laymcur" P1); to move in other layer with a select
Kent Cooper, AIA