I need correction in function given by Hak_vz
Code provided is correct and in accordance to your original request where it was told that after calculation any value less than 4 to be replaced with 4 (minimal scaled distance). And you didn't mention that distance can be 0. I understand that zero distance comes from situation when you have two or more hole at the same vertical. But I had to figure out by myself from your other post that followed this request.
Since you've started learning autolisp, at least you told that in other post, try to figure out what has to be changed to take into account zero distances. It's only one simple IF statement at the bottom of the function provided.
To be clear, your mathematical solution posted in original request was brilliant and code is made according to your lets call it pseudo code.
Try to make changes to the code and post it here, and if you need some other changes write them down. It's really hard to restart working on code where I nearly forgot what it was all about.
Miljenko Hatlak
Did your question get successfully answered? Then click on the ACCEPT SOLUTION button.
@avinash00002002 Try this code.
(defun plus_minus (lst fitting / plusp set_nth i sum_list k co cu su so e m p)
(defun plusp (num) (cond ((numberp num) (>= num 0.0))))
(defun set_nth (lst n value)
(cond
((and (plusp n) (<= n (length lst)))
(cond
((zerop n)
(cons value (cdr lst))
)
(t (cons (car lst) (set_nth (cdr lst) (1- n) value)))
)
)
)
)
(setq
i -1
sum_list (apply '+ lst)
k (/ (float fitting) sum_list)
cu 0
co 0
su 0
so 0
)
(while (< (setq i (1+ i)) (length lst))
(setq e (* k (nth i lst)))
(if (and (> e 0.0)(< e 4.0))
(setq su (+ su e) cu (1+ cu))
(setq so (+ so e) co (1+ co))
)
(setq lst (set_nth lst i e))
)
(setq m (- fitting (* cu 4.0)))
(setq p (/ m (* (/ 1.0 k) so)))
(setq i -1)
(while (< (setq i (1+ i)) (length lst))
(setq e (nth i lst))
(cond
((and(> e 0.0)(< e 4.0))(setq lst (set_nth lst i 4.0)))
((>= e 4.0)(setq lst (set_nth lst i (/ (* e p) k))))
)
)
lst
)(setq lst '(25.0 164.0 137.0 0.0 132.5 158.5 181.5 0.0 192.0 0.0 204.5 0.0 215.5 183.5 75.5 82.5 25.0))Command: (setq b (plus_minus lst 230))
(4.0 21.0816 17.6109 0.0 17.0324 20.3746 23.3312 0.0 24.6809 0.0 26.2878 0.0 27.7018 23.5883 9.70527 10.6051 4.0)
Command: (apply '+ b)
230.0Or for different length (let say 877)
Command: (setq b (plus_minus lst 877))
(12.3382 80.9387 67.6134 0.0 65.3925 78.2243 89.5754 0.0 94.7575 0.0 100.927 0.0 106.355 90.5625 37.2614 40.7161 12.3382)
Command: (apply '+ b)
877.0In some of your other requests you also asked for final values rounded to 0.5. This code is not so complicated, and you have also been provided with code that rounds values and keeps correct total sum. As an exercise, try to join this two code to one.
Miljenko Hatlak
Did your question get successfully answered? Then click on the ACCEPT SOLUTION button.
Working with separate list of x and y coordinates plus block name rises algorithm complexity and resulting code is not easy to follow. Elements in your lists are not sorted so checking if nth element is equal to nth+1 won't create correct result. Your code is hard to read and I don't have time to spent.
If you would have a list defined as follows I guess you would have more options
'(((x1 y1) "namex")((x2 y2) "namex")((x3 y3) "namex")...)
Miljenko Hatlak
Did your question get successfully answered? Then click on the ACCEPT SOLUTION button.
I'm not sure that my original code is prone to that kind of error, but will have to look later today. Sorry, but with all this various posts and requests, it is really hard to follow.
Miljenko Hatlak
Did your question get successfully answered? Then click on the ACCEPT SOLUTION button.
Code is wrong and it needs to be written again.
Miljenko Hatlak
Did your question get successfully answered? Then click on the ACCEPT SOLUTION button.
Code is working properly but when you use long list like this with combinations of lots of small values and few large ones, all small values when scaled receive value less than 4.0. and are changed to 4.0.
For example you can have for your list:
Command: (setq c(plus_minus lst 250))
(4.0 4.0 4.0 1.8573 1.78976 4.0 4.0 4.0 4.0 4.0 4.0 0.0 4.0 0.0 4.0 4.0 4.0 4.0 0.0 4.0 4.0 4.0 4.0 4.0 1.72785 10.1307 8.00327 4.0 4.0 4.0 9.00508 9.47222 4.0 4.0 4.0 4.0 4.0 4.0 4.0 4.0 4.0 4.0 4.0 4.0 4.0 6.16848 4.0 0.0 7.82879 4.0 4.0 4.0 0.0 0.0 4.0 4.0 4.0 4.44063 1.57589 4.0 4.0 4.0 4.0 4.0)
Command: (setq d(plus_minus lst 1000))
(5.17586 9.05775 9.05775 21.3504 20.574 4.20538 5.62874 4.0 5.62874 4.0 10.2223 0.0 4.52887 0.0 11.7751 4.0 4.52887 4.52887 0.0 4.39948 4.0 4.0 3.88189 4.27008 19.8623 116.457 92.0008 9.057Code is created according to your algorithm and that is all how I can help. You are doing this work from day to day and for me this is still a mystery.
Miljenko Hatlak
Did your question get successfully answered? Then click on the ACCEPT SOLUTION button.
