Enabling and Disabling Tiles in DCL
@doaiena wrote:
This style of coding is just a nightmare. It would be impossible to edit and maintain. I don't have the time, nor patience to go through such code..
Thank you for your valuable input and suggestions.
Notice that other posters are just asking for a lisp code without even trying to write one, so don't be too hard on the OP doaien.
As for the OP, please be patient and try not to double post,
Accepted solution
Hi, I've tried that make it work. You'll never short it down to 40 lines. Maybe 200. The drawing is too complex.
- fix your program, there is a lot of places where you compare string to real. Eg.
(COND ((= EBD "16") (SETQ OST 230) (SETQ OB 70)))
16 must be real or integer.
- Be aware that a dividing between two integers is still integer. (/ 10 2) = 4 !! In most cases in your program you have at least one real. So you're good to go. But if you're not sure, better make the integer real: (/ var 2.) (see the dot, now this is a real and you're save). This (FLOAT(/ WIDTH 2)) is unnecesary since the width is a real: (SETQ WIDTH (ATOF WIDTH)). So 2 can be an integer, but I usually use 2. anyway - no need to ever thing about it.
- Since you have such a monster DCL to input your data, you may consinder to adjust your program to allow a "testing" mode to be possible run without dcl.
eg.
(or EBD ; if you cancel DCL (= nil)
(setq EBD "40")) ; set EBD
- you're using the (cond) function wrong way. You may use the (or) function, or better the (member). Sorry for a screenshot, I've been experiencing some difficulties.
- If the program works for you, I would probrably not bother to re-write it. But if I do, I would probably pick 5 major points and all the parts calculate using just those. And you should solve one part after another and clearly separate it (describe).
- as a programmer, you should test the input values and not allow values out of valid range!!!
- sorry to not answering your question (don't know dcl much)
depakcad15,
I took the liberty of running thru the DCL code.
There are a few advanced tricks to reduce the character count.
If you want to learn by example, then this might tickle your fancy...
// constants
swh0 :spacer {width=0.0; height=0.0;}
swh1 :spacer {width=1.0; height=1.0;}
ebx2 :edit_box {edit_width=2;}
ebx3 :edit_box {edit_width=3;}
ebx4 :edit_box {edit_width=4;}
ebx6 :edit_box {edit_width=6;}
//
PEB1
:dialog {label="Place Name of Program Here";
swh0;
:text {label="Please fill out the following information"; alignment=centered;}
swh0;
:row {
:column {
:boxed_column {label="Clear Height";
:row {
:toggle {key="CLR"; label=" Clear Height Required";}
:ebx6 {key="CHT";}
}
swh0;
}
:boxed_column {label="Base";
:ebx6 {key="W"; label="WIDTH OF THE BUILDING:";}
:ebx6 {key="H"; label="HEIGHT OF THE BUILDING:";}
:ebx3 {key="S"; label="SLOPE OF THE BUILDING (I in.):";}
:ebx3 {key="P"; label="PURLIN DEPTH:";}
:ebx3 {key="G"; label="GIRT DEPTH:";}
swh0;
}
}
:boxed_column {label="Built Up";
:ebx4 {key="CW"; label="MAJOR COLUMN WEB DEPTH:";}
:ebx4 {key="MCW"; label="MINOR COLUMN WEB DEPTH:";}
:ebx2 {key="CFT"; label="COLUMN FLANGE THICK:";}
:ebx4 {key="RW"; label="RAFTER WEB DEPTH:";}
:ebx2 {key="RFT"; label="RAFTER FLANGE THICK:";}
:ebx2 {key="EST"; label="EAVE SPLICE THICK:";}
:ebx2 {key="RST"; label="RIDGE SPLICE THICK:";}
swh0;
}
:column {
:boxed_column {label="Extra";
:ebx4 {key="BPW"; label="BASE PLATE WIDTH:";}
:ebx4 {key="BPT"; label="BASE PLATE THICK:";}
:ebx2 {key="BBD"; label="BASE BOLT DIA.:";}
:ebx2 {key="EBD"; label="EAVE BOLT DIA.:";}
:ebx2 {key="RBD"; label="RIDGE BOLT DIA.:";}
swh0;
}
swh1;
ok_cancel;
swh0;
}
}
}
//
Character count went from 2836 to 1657 - a reduction of almost 42%!
I did make changes to the radio buttons and replaced with a toggle.
The copy of your DCL file did not have the carriage return on the last line
(making the cursor go to the next line, which is blank).
This has been known to cause problems. I usually end my code with
the comment symbol "//" just to be sure.
Where there are radio buttons, one must wrap these buttons inside a
radio row or column container. By assigning a key to the container,
one can now "talk" to the buttons (set_tile and get_tile).
Labels are typically of varying length. Referencing the key when short
term memory is failing, locate "key=" as the first attribute of the tile.
Hope this helps.