A couple of suggestions, first you are definitely heading in the right
direction by pulling the common functionality out of the Panel and Panels
subs and putting that into it's own function.
Second, make the InsertPanel sub a function, even if it only returns a
boolean indicating success or failure of the operation. You don't have to
use the return value if you don't need, but it's invaluable when you find
that your entire application crashes in the event that this functions fails.
You may also want to consider a new name for the function. I think that
InsertPanel is a great function name, but perhaps not for this particular
function. What is it exactly that this function is doing and to what is it
doing it to?
Third, your real error isn't syntactical, it's in the architecture of your
design. If a function requires an argument to perform it's operations, then
ensure that all procedures that call the function provide that argument. In
general, functions should be passed all of the data that they will need and
should not have to go get data that was not supplied.
To apply that to this particular situation, place the burden of collecting
data from the user and supplying the appropriate arguments to the
InsertPanel function on the Panel sub.
'**Warning - not tested**
Private Sub Panel()
Dim oEnt As AcadEntity
Dim Pnt As Variant
Dim oBlkRef as AcadBlockReference
ThisDrawing.Utility.GetEntity oEnt, Pnt, "Select Panel to update: "
If Typeof oEnt Is AcadBlockReference Then
Set oBlkRef = oEnt
Call InsertPanel (ThisDrawing.Blocks(oBlkRef.Name))
End If
End Sub
This way, you can use the same InsertPanel function for both the Panel and
the Panels subs, not to mention any future code that you may write.
--
Bobby C. Jones
www.acadx.com
