Hello. I have the following steps:
1. Create a structural framing
2. Add Reference Plane
3. Cut Geometry using this Reference Plane
4. Open 3D view
Curve curve = (element.Location as LocationCurve).Curve;
XYZ startPoint = curve.GetEndPoint(0);
XYZ endPoint = curve.GetEndPoint(1);This code will return start and end coordinates of actual frame, but how can I get start and end coordinates of visible part of the frame?
Thanks in advance.
It looks like really hard way 🙂
I can rephrase my question then, maybe someone would offer simplier solution.
I'm creating tag with leader for my beam using https://www.revitapidocs.com/2018/1f622654-786a-b8fd-1f81-278698bacd5b.htm.
I need to calculate XYZ pnt somehow, so tag leader would point to the beam. For now I'm using
locationCurve.Curve.Evaluate(0.5, true)to get the point, but when beam is cut, sometimes I can receive a leader pointing to nowhere.
So my question is how to make leader always point visible part of the beam.
I'm using following code to get solid:
Options options = new Options
{
DetailLevel = ViewDetailLevel.Fine
};
GeometryElement geometryElement = element.get_Geometry(options);
Solid solid = GetSolid(geometryElement);
if (solid != null)
{
BoundingBoxXYZ boundixBox = solid.GetBoundingBox();
return (boundixBox.Min + boundixBox.Max) / 2;
}
private static Solid GetSolid(GeometryElement geometryElement)
{
foreach (GeometryObject geometryObject in geometryElement)
{
Solid solid = geometryObject as Solid;
if (solid != null && solid.Id != ElementId.InvalidElementId.IntegerValue)
{
return solid;
}
GeometryInstance geometryInstance = geometryObject as GeometryInstance;
if (geometryInstance != null)
{
GeometryElement transformedGeometryElement = geometryInstance.GetInstanceGeometry(geometryInstance.Transform);
return GetSolid(transformedGeometryElement);
}
}
return null;
}For any beam I always get (0, 0, 0) point:
BoundingBox has a transform the Min/Max points are often centred on 0 so they would result in zero if averaged. Since in this case the transform has no rotation component you can get the origin from the bounding box transform and use that but strictly speaking you should be using:
Solid.GetBoundingBox.Transform
and Transform.OfPoint with the Min/Max points.
I have come across bounding boxes in other scenarios where the min/max are not mirror opposites so I would not just use the origin instead of OfPoint since OfPoint will always give the right answer also allowing for the rotation aspect where such exists.
Generally for geometry the bounding box transform has no rotation component.
Thank you very much. It works prefect in almost all cases, but I have a strange one. I have a beam that received some stage tag position using your approach. I tried to visualize its bounding box (draw a line between transformed min and max points) and received some strange result.
But in my other cases your approach works great.
You've not included any code so hard to say what you are getting wrong but I suspect it is you treating uncut and cut geometry the same way, you need to do that from a lower level i.e. avoid using GetInstanceGeometry. My approach would be as below:
Private Function Obj_230320a(ByVal commandData As Autodesk.Revit.UI.ExternalCommandData,
ByRef message As String, ByVal elements As Autodesk.Revit.DB.ElementSet) As Result
Dim UIApp As UIApplication = commandData.Application
Dim UIDoc As UIDocument = commandData.Application.ActiveUIDocument
If UIDoc Is Nothing Then Return Result.Cancelled Else
Dim IntDoc As Document = UIDoc.Document
Dim R As Reference
Try
R = UIDoc.Selection.PickObject(Selection.ObjectType.Element)
Catch ex As Exception
Return Result.Cancelled
End Try
Dim El As Element = IntDoc.GetElement(R)
Dim GeomEl As GeometryElement = El.Geometry(New Options With {.DetailLevel = ViewDetailLevel.Fine})
Dim geomInst As GeometryInstance = GeomEl.OfType(Of GeometryInstance).FirstOrDefault
'This is the old way can use GetSymbolGeometryId.SymbolId now
'FS below is not the Revit type but a element for the graphical symbol.
Dim FS As FamilySymbol = IntDoc.GetElement(geomInst.Symbol.Id)
Dim GeomElSymb As GeometryElement = FS.Geometry(New Options With {.DetailLevel = ViewDetailLevel.Fine})
Dim S As Solid = GeomElSymb.OfType(Of Solid).Where(Function(k) k.Volume > 0).FirstOrDefault
Dim BB As BoundingBoxXYZ = S.GetBoundingBox
Dim Max As XYZ = BB.Transform.OfPoint(BB.Max)
Dim Min As XYZ = BB.Transform.OfPoint(BB.Min)
Dim EP0 As New XYZ(Min.X, (Min.Y + Max.Y) / 2, Max.Z)
Dim EP1 As New XYZ(Max.X, (Min.Y + Max.Y) / 2, Max.Z)
Dim LN As Line = Line.CreateBound(EP0, EP1)
LN = LN.CreateTransformed(geomInst.Transform)
Using tx As New Transaction(IntDoc, "LN")
If tx.Start = TransactionStatus.Started Then
'Extension method (not part of RevitAPI)
LN.Draw(IntDoc)
tx.Commit()
End If
End Using
Return Result.Succeeded
End Function
