String.length of instance/type parameter.
The comparison that you're using is a little strange...
if (param.AsString() != "")
What if the string is empty spaces... or many others.
if (!String.IsNullOrWhiteSpace(param.AsString()))
Can you try it? Have you debugged your code?
What's bugging me the most is "the debugger only pause when >10"
Aren't you able to set the breakpoint earlier?
I don't see a reason for this code to fail due Revit API, but only if it's missing a step (like comparison or values on the .rtf)
Hi,
may it be that is it a matter of timing since Revit API is just a C# wrapper around native C++ Revit classes ?
Each time we read an Element's property or method, there is some additional working under the hood.
You call param.AsString() several times, so may it be that the last call is "choked" anyway ?
What about calling param.AsString() just one time, then storing the value in a string variable and using this one for comparison ?
Just an idea.
Revitalizer
Hi mohd.fadel,
hehe, seems that I've developed a special feeling for problems, over the years.
Best regards,
have a nice weekend,
Revitalizer
Hi mohd.fadel,
you say:
"But afterwards, i noticed that extracting the substrings from the original parameter was causing the problem!"
So, using my initial suggestion would not solve any underlying cause of the problem,
but could be used as a workaround to make your function run properly.
Revitalizer
Hello again Arnošt,
I'm sorry for the late reply. I couldn't reply earlier. I tried your code too, it worked perfectly! I tried mine:
if (uidoc.Selection == null)
{
TaskDialog.Show("Info", "Select an element.");
return Result.Succeeded;
}
ICollection<ElementId> elemIds = uidoc.Selection.GetElementIds();
if (elemIds.Count != 1)
{
TaskDialog.Show("Info", "Select an element.");
return Result.Succeeded;
}
ElementId elemId = elemIds.First();
Element elem = uidoc.Document.GetElement(elemId);
if (elem == null)
{
TaskDialog.Show("Error", "Could not get element");
return Result.Succeeded;
}
//Parameter comments = elem.get_Parameter("Executed Date");
Parameter comments = elem.get_Parameter(BuiltInParameter.ALL_MODEL_INSTANCE_COMMENTS);
if (comments == null)
{
TaskDialog.Show("Info", "Parameter \"Comments\" not found");
return Result.Succeeded;
}
string svalue = comments.AsString();
if (string.IsNullOrEmpty(svalue))
{
TaskDialog.Show("Info", "No comments!");
return Result.Succeeded;
}
string dd;
string mm;
string yyyy;
string paramString;
int paramLength;
dd = comments.AsString().ToString().Substring(0, 2);
mm = comments.AsString().ToString().Substring(3, 2);
yyyy = comments.AsString().ToString().Substring(6, 4);
paramString = comments.AsString();
paramLength = paramString.Length;
System.Windows.Forms.MessageBox.Show(paramLength.ToString());
it didn't work! Although it has the same use of Substring!
As you can see, i tried 2 scenarios:
//Parameter comments = elem.get_Parameter("Executed Date");
Parameter comments = elem.get_Parameter(BuiltInParameter.ALL_MODEL_INSTANCE_COMMENTS);
I tried your choice (using the Comments paramter). I thought i'll double check now that i'm not using the EventHandler. Same issue!! Only now, an error is occured when trying to enter values less than 10 characters:
at System.String.InternalSubStringWithChecks(Int32 startIndex, Int32 length, Boolean fAlwaysCopy).
Interesting! But i don't get it. Any ideas?
M. Fadel
