SetGroupTypeId for project parameters is not kept after closing the model
Looks like a bug, I tested and was not able to save the new parameter group, really strange.
I tested in version 2024 - Build 24.0.4.427.
Here is a code with the file for testing. The file has a project parameter and a shared parameter.
public void ModifyParameterGroup(Document document)
{
System.Console.WriteLine(document.Title);
Dictionary<string, ForgeTypeId> paramDict = new Dictionary<string, ForgeTypeId>();
//other
paramDict.Add("R_TEST", GroupTypeId.Phasing);
paramDict.Add("R_TEST_SHARED", GroupTypeId.Phasing);
BindingMap bindingsMap = document.ParameterBindings;
DefinitionBindingMapIterator iterator = bindingsMap.ForwardIterator();
using (Transaction t = new Transaction(document))
{
t.Start("Change Parameter Group");
while (iterator.MoveNext())
{
ElementBinding elementBinding = iterator.Current as ElementBinding;
Definition definition = iterator.Key;
InternalDefinition intDef = definition as InternalDefinition;
if (paramDict.ContainsKey(definition.Name))
{
System.Console.WriteLine($"{definition.Name} \t {intDef.GetGroupTypeId().TypeId} -> {paramDict[definition.Name].TypeId}");
intDef.SetGroupTypeId(paramDict[definition.Name]);
}
}
t.Commit();
}
document.Save();
}
@a.bejenaru wrote:So I'm the first person to try this? I think this method is available since 2022
Maybe yes.
I never needed to change the group in an existing document, maybe would be a good idea to check if that happened with the old BuiltInParameterGroup to see if works or not.
And... same issue, change the group is not saved, here is the code. (Tested in Revit 24.0.4.427.)
public void ModifyBuiltInParameterGroup(Document document)
{
System.Console.WriteLine(document.Title);
Dictionary<string, BuiltInParameterGroup> paramDict = new Dictionary<string, BuiltInParameterGroup>();
//other
paramDict.Add("R_TEST", BuiltInParameterGroup.PG_PHASING);
paramDict.Add("R_TEST_SHARED", BuiltInParameterGroup.PG_PHASING);
BindingMap bindingsMap = document.ParameterBindings;
DefinitionBindingMapIterator iterator = bindingsMap.ForwardIterator();
using (Transaction t = new Transaction(document))
{
t.Start("Change Parameter Group");
while (iterator.MoveNext())
{
ElementBinding elementBinding = iterator.Current as ElementBinding;
Definition definition = iterator.Key;
InternalDefinition intDef = definition as InternalDefinition;
if (paramDict.ContainsKey(definition.Name))
{
System.Console.WriteLine($"{definition.Name} \t {intDef.get_ParameterGroup()} -> {paramDict[definition.Name]}");
intDef.set_ParameterGroup(paramDict[definition.Name]);
}
}
t.Commit();
}
document.Save();
}
I figure out the issue.
There is no transaction when you change the parameter group in the document, this means I can use SetGroupTypeId without a transaction. Probably the document never saves that change if you close and open the document again.
Here is a video. https://youtu.be/LMcxdK7WRx8
This is the Command in the video without transaction that changes the SetGroupTypeId.
using Autodesk.Revit.Attributes;
using Autodesk.Revit.DB;
using Autodesk.Revit.UI;
using System.Collections.Generic;
namespace RevitTestSample
{
[Transaction(TransactionMode.Manual)]
[System.ComponentModel.Designer("/UIFrameworkRes;component/ribbon/images/revit.ico")]
public class Command : IExternalCommand
{
public Result Execute(ExternalCommandData commandData, ref string message, ElementSet elementSet)
{
UIApplication uiapp = commandData.Application;
Document document = uiapp.ActiveUIDocument.Document;
ModifyParameterGroup(document);
return Result.Succeeded;
}
public void ModifyParameterGroup(Document document)
{
System.Console.WriteLine(document.Title);
Dictionary<string, ForgeTypeId> paramDict = new Dictionary<string, ForgeTypeId>();
//other
paramDict.Add("R_TEST", GroupTypeId.Phasing);
paramDict.Add("R_TEST_SHARED", GroupTypeId.Phasing);
BindingMap bindingsMap = document.ParameterBindings;
DefinitionBindingMapIterator iterator = bindingsMap.ForwardIterator();
while (iterator.MoveNext())
{
ElementBinding elementBinding = iterator.Current as ElementBinding;
Definition definition = iterator.Key;
InternalDefinition intDef = definition as InternalDefinition;
if (paramDict.ContainsKey(definition.Name))
{
System.Console.WriteLine($"{definition.Name} \t {intDef.GetGroupTypeId().TypeId} -> {paramDict[definition.Name].TypeId}");
intDef.SetGroupTypeId(paramDict[definition.Name]);
}
}
}
}
}
@a.bejenaru wrote:So it is a bug?
Yes, hey @jeremytammik, can you ask the Revit team to check that?
I tested in Revit 2021 and looks like changing the ParameterGroup in the project parameters never works. I can execute outside a Transaction and even outside the Revit context.
This command should fail without a transaction.
using Autodesk.Revit.Attributes;
using Autodesk.Revit.DB;
using Autodesk.Revit.UI;
using System;
using System.Collections.Generic;
namespace RevitTestSample
{
[Transaction(TransactionMode.Manual)]
public class Command : IExternalCommand
{
public Result Execute(ExternalCommandData commandData, ref string message, ElementSet elementSet)
{
UIApplication uiapp = commandData.Application;
Document document = uiapp.ActiveUIDocument.Document;
ModifyBuiltInParameterGroup(document);
return Result.Succeeded;
}
public void ModifyBuiltInParameterGroup(Document document)
{
System.Console.WriteLine(document.Title);
Dictionary<string, BuiltInParameterGroup> paramDict = new Dictionary<string, BuiltInParameterGroup>();
//other
paramDict.Add("R_TEST", BuiltInParameterGroup.PG_PHASING);
paramDict.Add("R_TEST_SHARED", BuiltInParameterGroup.PG_PHASING);
foreach (var item in GetParameterBindings(document))
{
ElementBinding elementBinding = item.Value as ElementBinding;
Definition definition = item.Key;
InternalDefinition intDef = definition as InternalDefinition;
if (paramDict.ContainsKey(definition.Name))
{
System.Console.WriteLine($"{definition.Name} \t {intDef.get_ParameterGroup()} -> {paramDict[definition.Name]}");
intDef.set_ParameterGroup(paramDict[definition.Name]);
}
}
}
public IDictionary<Definition, Binding> GetParameterBindings(Document document)
{
var parameterBindings = document.ParameterBindings;
var iterator = parameterBindings.ForwardIterator();
var result = new Dictionary<Definition, Binding>();
while (iterator.MoveNext())
{
var definition = iterator.Key as Definition;
var binding = iterator.Current as Binding;
result.Add(definition, binding);
}
return result;
}
}
}
I guess using the DocumentOpened Event kinda works momentarily.
Yes, if you are using SharedParameter the ReInsert should work. But if you are using a ProjectParameter, the ReInsert does nothing.
The SetGroupTypeId/set_ParameterGroup still changes the propriety in the document but is not saved in a transaction.
using Autodesk.Revit.Attributes;
using Autodesk.Revit.DB;
using Autodesk.Revit.UI;
using System;
using System.Collections.Generic;
namespace RevitTestSample
{
[Transaction(TransactionMode.Manual)]
public class CommandReInsert : IExternalCommand
{
public Result Execute(ExternalCommandData commandData, ref string message, ElementSet elementSet)
{
UIApplication uiapp = commandData.Application;
Document document = uiapp.ActiveUIDocument.Document;
// ModifyBuiltInParameterGroup(document);
using (Transaction transaction = new Transaction(document))
{
transaction.Start("ReInsertBuiltInParameterGroup");
ReInsertBuiltInParameterGroup(document); // Does not work with Project Parameter
transaction.Commit();
}
return Result.Succeeded;
}
public void ModifyBuiltInParameterGroup(Document document)
{
System.Console.WriteLine(document.Title);
Dictionary<string, BuiltInParameterGroup> paramDict = new Dictionary<string, BuiltInParameterGroup>();
//other
paramDict.Add("R_TEST", BuiltInParameterGroup.PG_PHASING);
paramDict.Add("R_TEST_SHARED", BuiltInParameterGroup.PG_PHASING);
foreach (var item in GetParameterBindings(document))
{
ElementBinding elementBinding = item.Value as ElementBinding;
Definition definition = item.Key;
InternalDefinition intDef = definition as InternalDefinition;
if (paramDict.ContainsKey(definition.Name))
{
System.Console.WriteLine($"{definition.Name} \t {intDef.get_ParameterGroup()} -> {paramDict[definition.Name]}");
intDef.set_ParameterGroup(paramDict[definition.Name]);
}
}
}
public void ReInsertBuiltInParameterGroup(Document document)
{
System.Console.WriteLine(document.Title);
Dictionary<string, BuiltInParameterGroup> paramDict = new Dictionary<string, BuiltInParameterGroup>();
//other
paramDict.Add("R_TEST", BuiltInParameterGroup.PG_PHASING);
paramDict.Add("R_TEST_SHARED", BuiltInParameterGroup.PG_PHASING);
foreach (var item in GetParameterBindings(document))
{
Binding binding = item.Value;
Definition definition = item.Key;
InternalDefinition intDef = definition as InternalDefinition;
if (paramDict.ContainsKey(definition.Name))
{
System.Console.WriteLine($"{definition.Name} \t {intDef.get_ParameterGroup()} -> {paramDict[definition.Name]}");
//intDef.set_ParameterGroup(paramDict[definition.Name]);
//document.ParameterBindings.ReInsert(definition, binding);
document.ParameterBindings.ReInsert(definition, binding, paramDict[definition.Name]);
}
}
}
public IDictionary<Definition, Binding> GetParameterBindings(Document document)
{
var parameterBindings = document.ParameterBindings;
var iterator = parameterBindings.ForwardIterator();
var result = new Dictionary<Definition, Binding>();
while (iterator.MoveNext())
{
var definition = iterator.Key as Definition;
var binding = iterator.Current as Binding;
result.Add(definition, binding);
}
return result;
}
}
}
