Copy Parameters

[emaguilera]

Hi everyone,

I need to copy the content from the source parameters to the target parameters. I've written the following code, but it doesn't seem to work correctly. Can anyone help me figure out what's wrong?

    [Transaction(TransactionMode.Manual)]
    public class CopyParameterCommand : IExternalCommand
    {
        public Result Execute(ExternalCommandData commandData, ref string message, ElementSet elements)
        {
            UIApplication uiApp = commandData.Application;
            Autodesk.Revit.DB.Document doc = uiApp.ActiveUIDocument.Document;

            FilteredElementCollector collector = new FilteredElementCollector(doc);
            ICollection<Element> allElements = collector.WhereElementIsNotElementType().ToElements();

            using (Transaction trans = new Transaction(doc, "Copiar parámetro "))
            {
                trans.Start();

                foreach (Element element in allElements)
                {
                    Parameter sourceParam = element.LookupParameter("Source-parameter");
                    Parameter targetParam = element.LookupParameter("Target-parameter");


                    if (sourceParam != null && sourceParam.HasValue)
                    {
                        string sourceValue = sourceParam.AsString();

                        if (targetParam != null && targetParam.StorageType == StorageType.String)
                        {
                            targetParam.Set(sourceValue);
                            sourceParam.Set(string.Empty);
                        }
                    }
                }

                trans.Commit();
            }

            return Result.Succeeded;
        }
    }

[jeremy_tammik]

I cannot tell what the problem might be. What behaviour do you observe?

Your code looks sort of OK-ish, although I see a couple of issues that could easily be optimised.

[emaguilera]

.

[emaguilera]

.

I want what is in red to become what is in yellow.
I can't get it to work.

[jeremy_tammik]

So, what is the problem with your script? What happens?

[MarryTookMyCoffe]

maybe source and target parameter are type parameters, you look for them in instance not in symbol. debug it or if you don't know how make a simple dialog that show if any parameter was found.

[emaguilera]

The code basically doesn't work, it doesn't do what I want it to do.

[emaguilera]

I managed to fix it, the error was in the parameter name... 😂
Regards,
Emanuel.