iLogic to update iproperties on all open drawings.
Is this a 'local' rule, or an external rule? Is the one drawing it is working on the 'local' drawing, or the drawing that was 'active' when the rule first started? If so, which?
If this is a 'local' rule, then the term 'ThisDrawing.ModelDocument' (more specifically the 'ThisDrawing' term) may always be pointing to the 'local' drawing document. If this is an external rule, and the code is always working for the drawing document that was open/active when the rule first started, it may also be due to using that 'ThisDrawing.ModelDocument' term, because I believe in that case it will always refer to the document that was 'active' when the rule first started. If any of these scenario's is true, you may have to access the drawing's 'model' document through the oDrawDoc.ReferencedDocuments.Item(1) instead. Just my initial thoughts.
If this solved your problem, or answered your question, please click ACCEPT SOLUTION.
Or, if this helped you, please click (LIKE or KUDOS) 👍.
If you want and have time, I would appreciate your Vote(s) for My IDEAS 💡or you can Explore My CONTRIBUTIONS
Wesley Crihfield
(Not an Autodesk Employee)
OK. My next thought is that the 'modelName' variable isn't working for you. Normally the 'DisplayName' of the document will work here, if it hasn't been altered from default, but I usually avoid doing it that way, due to the stability issue, and opt for accessing the iProperties of other documents the long way, just to be more sure. So I simply eliminated the use of that variable, in favor of using the actual document variable. Here's what I've got now, that you can try out.
For Each oDoc As Document In ThisApplication.Documents.VisibleDocuments
If Not oDoc.DocumentType = DocumentTypeEnum.kDrawingDocumentObject Then Continue For 'skip to next oDoc
Dim oDrawDoc As DrawingDocument = oDoc
oDrawDoc.Activate
If oDrawDoc.ReferencedDocuments.Count = 0 Then Continue For 'skip to next oDoc
Dim oMDoc As Document = oDrawDoc.ReferencedDocuments.Item(1)
Dim oDTProps As PropertySet = oMDoc.PropertySets.Item(3)
Dim oCProps As PropertySet = oMDoc.PropertySets.Item(4)
Try
Part_Material = oCProps.Item("MATERIAL").Value
Catch
Part_Material = ""
End Try
Try
Part_Grade = oCProps.Item("GRADE").Value
Catch
Part_Grade = ""
End Try
Try
Part_Finish_Type = oCProps.Item("FINISH TYPE").Value
Catch
Part_Finish_Type = ""
End Try
Try
Stock_Number = oDTProps.Item("Stock Number").Value
Catch
Stock_Number = ""
End Try
Try
'these lines are accessing the iProperties of the 'active' document
iProperties.Value("Custom", "MATERIAL") = Stock_Number & " - " & Part_Material & " - " & Part_Grade & " || " & Part_Finish_Type
iProperties.Value("Custom", "PROJECT DESCRIPTION") = oDTProps.Item("Project").Value
iProperties.Value("Custom", "PART DESCRIPTION") = oDTProps.Item("Description").Value
iProperties.Value("Custom", "PART NUMBER") = oDTProps.Item("Part Number").Value
iProperties.Value("Custom", "CPT PROJECT") = oCProps.Item("Company PROJECT").Value
Catch
End Try
Next oDoc
If this solved your problem, or answered your question, please click ACCEPT SOLUTION.
Or, if this helped you, please click (LIKE or KUDOS) 👍.
If you want and have time, I would appreciate your Vote(s) for My IDEAS 💡or you can Explore My CONTRIBUTIONS
Wesley Crihfield
(Not an Autodesk Employee)
I just realized that since those last several lines of code (using iProperties.Value("Custom",....)) are writing the retrieved iProperty values to whatever document is currently 'active', and we are using 'Activate' on each of the documents we are looping through, we are in fact writing the one called "Material" over itself, and the rest are being either updated or created within that newly 'active' document. Was that your intention? If not, we may have to convert those lines to using the long route too.
Wesley Crihfield
(Not an Autodesk Employee)
I was a way for a while, then just came back and looked at this again. I think I may have been wrong in my last statement. In those last several lines (of the last code I posted) the first half of each line is referencing the 'active' drawing document in the loop (because they aren't specifying a target document), while the second have of each line is referencing the model document's iProperties (because they are using the PropertySet variables created for the 'model' documet). It's kind of hart to keep it all straight in my head, because I'm 'multi-tasking' a little too much right now. 😅 Sorry for that mistake...I hope I haven't just confused you even further.
Wesley Crihfield
(Not an Autodesk Employee)
I think its better to use API-calls instead of the iLogic interface when you're modifying properties of other documents than the one the rule is running in. It just gives better control of what you're working with IMO.
This rule is quite ugly due to all the try-catch statements and I haven't tried it myself but I think something like this should probably work...
For Each oDoc In ThisApplication.Documents.VisibleDocuments If oDoc.DocumentType <> kDrawingDocumentObject Then Continue For Dim mDoc As Document Try mDoc = TryCast(oDoc, DrawingDocument).Sheets(1).DrawingViews(1).ReferencedDocumentDescriptor.ReferencedDocument Catch Continue For End Try Dim Part_Material As String Dim Part_Grade As String Dim Part_Finish_Type As String Dim Stock_Number As String Dim Company_Project As String Dim drawingCprops As PropertySet = oDoc.PropertySets("{D5CDD505-2E9C-101B-9397-08002B2CF9AE}") Dim cProps As PropertySet = mDoc.PropertySets("{D5CDD505-2E9C-101B-9397-08002B2CF9AE}") Dim dProps As PropertySet = mDoc.PropertySets("{32853F0F-3444-11D1-9E93-0060B03C1CA6}") Try Part_Material = cProps("MATERIAL").Expression Catch End Try Try Part_Grade = cProps("GRADE").Expression Catch End Try Try Part_Finish_Type = cProps("FINISH TYPE").Expression Catch End Try Try Stock_Number = dProps("Stock Number").Expression Catch End Try Try Company_Project = cProps("Company PROJECT").Expression Catch End Try Try drawingCprops("MATERIAL").Value = Stock_Number & " - " & Part_Material & " - " & Part_Grade & " || " & Part_Finish_Type Catch drawingCprops.Add(Stock_Number & " - " & Part_Material & " - " & Part_Grade & " || " & Part_Finish_Type, "MATERIAL") End Try Try drawingCprops("PROJECT DESCRIPTION").Value = dProps("Project").Value Catch drawingCprops.Add(dProps("Project").Value, "PROJECT DESCRIPTION") End Try Try drawingCprops("PART DESCRIPTION").Value = dProps("Description").Value Catch drawingCprops.Add(dProps("Description").Value, "PART DESCRIPTION") End Try Try drawingCprops("PART NUMBER").Value = dProps("Part Number").Value Catch drawingCprops.Add(dProps("Part Number").Value, "PART NUMBER") End Try Try drawingCprops("CPT PROJECT").Value = Company_Project Catch drawingCprops.Add(Company_Project, "CPT PROJECT") End Try Next
Jhoel Forshav
Download my free Inventor Addin - Hole Projector
LinkedIn | Ideas | Contributions | Blog posts | Website
FYI...The error indicates that one of the lines where it is trying to 'Add' an iProperty is giving the error, but it doesn't specify which specific line the error occurred on.
Wesley Crihfield
(Not an Autodesk Employee)
As long as the property has something to put as its value, the add-method should work. So i just made sure there's always a value there even if the corresponding property doesn't exist in the model document. See if this works for you 🙂
For Each oDoc In ThisApplication.Documents.VisibleDocuments If oDoc.DocumentType <> kDrawingDocumentObject Then Continue For Dim mDoc As Document Try mDoc = TryCast(oDoc, DrawingDocument).Sheets(1).DrawingViews(1).ReferencedDocumentDescriptor.ReferencedDocument Catch Continue For End Try Dim Part_Material As String = "-" Dim Part_Grade As String = "-" Dim Part_Finish_Type As String = "-" Dim Stock_Number As String = "-" Dim Company_Project As String = "-" Dim drawingCprops As PropertySet = oDoc.PropertySets("{D5CDD505-2E9C-101B-9397-08002B2CF9AE}") Dim cProps As PropertySet = mDoc.PropertySets("{D5CDD505-2E9C-101B-9397-08002B2CF9AE}") Dim dProps As PropertySet = mDoc.PropertySets("{32853F0F-3444-11D1-9E93-0060B03C1CA6}") Try Part_Material = cProps("MATERIAL").Expression Catch End Try Try Part_Grade = cProps("GRADE").Expression Catch End Try Try Part_Finish_Type = cProps("FINISH TYPE").Expression Catch End Try Try Stock_Number = dProps("Stock Number").Expression Catch End Try Try Company_Project = cProps("Company PROJECT").Expression Catch End Try Try drawingCprops("MATERIAL").Value = Stock_Number & " - " & Part_Material & " - " & Part_Grade & " || " & Part_Finish_Type Catch drawingCprops.Add(Stock_Number & " - " & Part_Material & " - " & Part_Grade & " || " & Part_Finish_Type, "MATERIAL") End Try Try drawingCprops("PROJECT DESCRIPTION").Value = dProps("Project").Value Catch drawingCprops.Add(dProps("Project").Value, "PROJECT DESCRIPTION") End Try Try drawingCprops("PART DESCRIPTION").Value = dProps("Description").Value Catch drawingCprops.Add(dProps("Description").Value, "PART DESCRIPTION") End Try Try drawingCprops("PART NUMBER").Value = dProps("Part Number").Value Catch drawingCprops.Add(dProps("Part Number").Value, "PART NUMBER") End Try Try drawingCprops("CPT PROJECT").Value = Company_Project Catch drawingCprops.Add(Company_Project, "CPT PROJECT") End Try Next
Jhoel Forshav Download my free Inventor Addin - Hole Projector
LinkedIn | Ideas | Contributions | Blog posts | Website
