Message 1 of 3
Replacing diagonal lines with vertical and horizontal lines.
- Mark as New
- Bookmark
- Subscribe
- Mute
- Subscribe to RSS Feed
- Permalink
- Report
Hello everyone,
I have a code done by exceed that deletes some uncessecary lines on my closed plines, based on the lenght of each segment of the pline.
The issue here is that when the pline is beign closed by the code, sometimes the segment that joins the first and the last point can be diagonal. The goal is to convert the diagonal line to a vertical or horizontal line.
Is there a way to make sure that in the end we only have vertical or horizontal lines?
Thanks in advance (see attached drawing with examples. Diagonal segments under red circles)
; DentRepair - 2023.09.15 exceeds
; Dent repairs polyline segments with vertical and horizontal outlines outwards.
; If the length of one line segment is less than a certain value, it adjusted out to a wider side.
(defun c:DentRepair ( / *error* acdoc ss ssl index ent obj clist cllen
isclosed index2 p0 p1 p2 p3 linelength
lineangle setlength tempclist1 tempclist2
temp1 temp2 temp1obj temp2obj temp1area
temp2area stopper resultent
)
(vl-load-com)
;; Group by Number - Lee Mac
;; Groups a list 'l' into a list of lists, each of max length 'n'
(defun *error* (msg)
(if (/= msg "Function cancelled")
(princ (strcat "\nError: " msg))
)
(vla-EndUndoMark acdoc)
(princ)
)
(defun LM:group<n ( l n )
(if l (LM:group<n-sub (cons nil l) n n))
)
(defun LM:group<n-sub ( l m n )
(if (and (cdr l) (< 0 n))
(LM:group<n-sub (cons (cons (cadr l) (car l)) (cddr l)) m (1- n))
(cons (reverse (car l)) (LM:group<n (cdr l) m))
)
)
;;---------------------=={ Subst Nth }==----------------------;;
;; ;;
;; Substitutes an item at the nth position in a list. ;;
;;------------------------------------------------------------;;
;; Author: Lee Mac, Copyright © 2011 - www.lee-mac.com ;;
;;------------------------------------------------------------;;
;; Arguments: ;;
;; a - item to substitute ;;
;; n - position in list to make the substitution ;;
;; l - list in which to make the substitution ;;
;;------------------------------------------------------------;;
;; Returns: Resultant list following the substitution ;;
;;------------------------------------------------------------;;
(defun LM:SubstNth ( a n l )
(if l
(if (zerop n)
(cons a (cdr l))
(cons (car l) (LM:SubstNth a (1- n) (cdr l)))
)
)
)
;; Unique - Lee Mac
;; Returns a list with duplicate elements removed.
(defun LM:Unique ( l )
(if l (cons (car l) (LM:Unique (vl-remove (car l) (cdr l)))))
)
; degree to radian
(defun dtr (a)
(setq x (* pi (/ a 180.0)))
)
; radian to degree
(defun rtd (a)
(setq x (/ (* a 180) pi))
)
(defun lwpolybylist (lst cls)
(entmakex
(append
(list
(cons 0 "LWPOLYLINE")
(cons 100 "AcDbEntity")
(cons 100 "AcDbPolyline")
(cons 90 (length lst))
(cons 70 cls)
)
(mapcar (function (lambda (p) (cons 10 p))) lst)
)
)
)
(setq acdoc (vla-get-ActiveDocument (vlax-get-ACAD-Object)))
(vla-StartUndoMark acdoc)
(setq setlength 0.8)
(setq setlength (abs setlength))
(setq ss (ssget "_x" '((8 . "0"))))
(setq ssl (sslength ss))
(setq index 0)
(repeat ssl
(setq ent (ssname ss index))
(setq obj (vlax-ename->vla-object ent))
(setq clist (vlax-safearray->list (vlax-variant-value (vlax-get-property obj 'coordinates))))
(setq cllen (length clist))
(setq isclosed (vlax-get-property obj 'closed))
;(princ "\n isclosed? ")
;(princ isclosed)
(if (= isclosed :vlax-true)
(progn
(setq clist (append clist (list (car clist) (cadr clist))))
)
(progn
(if (and (= (car clist) (nth (- cllen 2) clist)) (= (cadr clist) (nth (- cllen 1) clist)))
(progn)
(progn
(setq clist (append clist (list (car clist) (cadr clist))))
)
)
)
)
(setq clist (lm:unique (lm:group<n clist 2)))
;(princ "\n clist - ")
;(princ clist)
(setq cllen (length clist))
(setq index2 0)
(if (>= cllen 4)
(progn
(repeat cllen
(if (and (/= index2 0) (/= resultent nil))
(entdel resultent)
)
(setq p1 (nth index2 clist))
(if (= (- cllen 1) index2)
(setq p2 (nth 0 clist))
(setq p2 (nth (+ index2 1) clist))
)
(if (= index2 0)
(setq p0 (last clist))
(setq p0 (nth (- index2 1) clist))
)
(if (<= index2 (- cllen 3))
(setq p3 (nth (+ index2 2) clist))
(setq p3 (nth (- (+ index2 2) cllen) clist))
)
(setq linelength (distance p1 p2))
;(princ "\n linelength - ")
;(princ linelength)
(setq lineangle (rtd (angle p1 p2)))
;(princ "\n lineangle - ")
;(princ lineangle)
(setq tempclist1 '())
(setq tempclist2 '())
(if (>= linelength setlength)
(progn
;(if (or (= lineangle 0) (= lineangle 90) (= lineangle 180) (= lineangle 270) (= lineangle 360))
; (progn)
; (progn)
;)
)
(progn
(cond
((or (= (rtos lineangle 2 0) "0") (= (rtos lineangle 2 0) "180")) ;horizontal line
(setq tempclist1 (LM:SubstNth (list (car p1) (cadr p0)) index2 clist))
(setq tempclist1 (LM:SubstNth (list (car p2) (cadr p0)) (if (= (- cllen 1) index) 0 (+ index2 1)) tempclist1))
(setq tempclist2 (LM:SubstNth (list (car p1) (cadr p3)) index2 clist))
(setq tempclist2 (LM:SubstNth (list (car p2) (cadr p3)) (if (= (- cllen 1) index) 0 (+ index2 1)) tempclist2))
)
((or (= (rtos lineangle 2 0) "90") (= (rtos lineangle 2 0) "270")) ;verical line
(setq tempclist1 (LM:SubstNth (list (car p0) (cadr p1)) index2 clist))
(setq tempclist1 (LM:SubstNth (list (car p0) (cadr p2)) (if (= (- cllen 1) index) 0 (+ index2 1)) tempclist1))
(setq tempclist2 (LM:SubstNth (list (car p3) (cadr p1)) index2 clist))
(setq tempclist2 (LM:SubstNth (list (car p3) (cadr p2)) (if (= (- cllen 1) index) 0 (+ index2 1)) tempclist2))
)
(t
(setq tempclist1 clist)
(setq tempclist2 clist)
)
)
;(princ "\n tempclist1 - ")
;(princ tempclist1)
(setq temp1 (lwpolybylist tempclist1 1))
;(princ "\n tempclist2 - ")
;(princ tempclist2)
(setq temp2 (lwpolybylist tempclist2 1))
(setq temp1obj (vlax-ename->vla-object temp1))
(setq temp2obj (vlax-ename->vla-object temp2))
(setq temp1area (vla-get-area temp1obj))
(setq temp2area (vla-get-area temp2obj))
(if (>= temp1area temp2area)
(setq clist tempclist1)
(setq clist tempclist2)
)
(entdel temp1)
(entdel temp2)
)
)
(setq resultent (lwpolybylist clist 1))
;(setq stopper (getstring "\n continue ? : "))
;(princ "\n index2 - ")
;(princ index2)
;(princ " / cllen - ")
;(princ cllen)
(setq index2 (+ index2 1))
)
)
(progn
(princ "\n not enough vertices. (less then 4)")
)
)
;(setq stopper (getstring "\n continue ? : "))
(setq index (+ index 1))
)
(vla-EndUndoMark acdoc)
(princ)
)
(c:DentRepair)
