Lisp help, explanations welcome.
I have a window frame package that draws the white lines. Full control of sizes.
Post me a PM if interested.
Adding the mitered mullions is possible.
Anyway a quick way around it is enter offset then pick each pane, you now have the sizes so can work out the line work. Just select all panes and loop through.
(defun c:wow ( / off x k co-ord co-ord2)
(setq oldsnap (getvar 'osmode) oldlay (getvar 'clayer))
(setvar 'osmode 0)
(setq off (- (getreal "\nEnter offset ")))
(prompt "\nSelect inside only ")
(setq ss (ssget '((0 . "LWPOLYLINE"))))
(if (= ss nil)
(alert "no panes selected")
(progn
(repeat (setq x (sslength ss))
(setq ent (ssname ss (setq x (1- x))))
(setq co-ord (mapcar 'cdr (vl-remove-if-not '(lambda (x) (= (car x) 10)) (entget ent))))
(vla-offset (vlax-ename->vla-object ent) off)
(vla-put-layer (vlax-ename->vla-object (entlast)) "Geometry_0")
(setq co-ord2 (mapcar 'cdr (vl-remove-if-not '(lambda (x) (= (car x) 10)) (entget (entlast)))))
(setq k -1)
(setvar 'clayer "Geometry_0")
(repeat 4
(command "line" (nth (setq k
(1+ k)) co-ord)(nth k co-ord2) "")
)
)
)
)
(setvar 'osmode oldsnap)
(setvar 'clayer oldlay)
(princ)
)
(c:wow)
@annoisscary wrote:
....
(initget "True False")
(setq tdl (getkword "Is this TDL? [True/False]:"))
(IF(= tdl True)(setq tdlxy (getreal "\nEnter Profile Width: ")))
....
The (initget)/(getkword) approach returns a text string, which will need its quotation marks:
....
(IF (= tdl "True") (setq tdlxy (getreal "\nEnter Profile Width: ")))
....
Another little suggestion: Don't make the choice of the type of divided lights whether it is true or false for one of the options, but rather directly between the two options:
(initget "True Simulated")
(setq tdl (getkword "Which type of divided lights? [True/Simulated]: "))
(if (= tdl "True") ....
@annoisscary wrote:
... the bit about picking between the types instead of true or false.. is that just a design choice or is there a bigger picture there?
The "bigger picture" if there is one comes when there are more than two options. It shouldn't matter if there are only two, but you could, for example, have different mullion/muntin widths, both in true and simulated divided lights, and have all of them available within one choice among options, if you set it up right. It also makes it clear what the choices are, though that may not be necessary for knowledgeable Users -- a less knowledgeable User might wonder at a prompt like "Is this TDL?" [as opposed to what?].
[Also, maybe I'm just subconsciously reacting against the potential for confusion of "True" as a text-string option and T as an AutoLisp symbol, but....
I think if I were doing it as a question of whether or not it's one of the choices, instead of as an explicit choice between specified options, with a prompt such as "Is this TDL?" I would be inclined to use "Yes/No" rather than "True/False".]
When your making the plines you can add them to a list as they are created, then you would just run the code I provided as you now have a selection set, you would just add the code at the end of what you already have there would be no 2nd step, the code was created to show how to do it.
Re True False this is my code
(if (not AH:Butts)(load "Multi radio buttons.lsp")) ; loads the program if not loaded already
(setq ans (ah:butts 1 "V" '("True or False" "True" "False"))) ; ans holds the button picked value as a string
(cond
((= ans "True")(do something 1))
((= ans "False")(do something 2))
)
There is also a Acet function "Yes no" does something similar.
Another attempt give it a try
; Modified by Alan H OCT 2022
(defun c:LP (/ frm xnum ynum xspace yspace xpane ypane pane pane2 ptc pt1 pt2 pt3 pt4 ptp1 ptp2 ptp3 ptp4)
(setq oldsnap (getvar 'osmode) oldlay (getvar 'clayer))
(setvar "CMDECHO" 0)
(setq ss (ssadd))
(initget 7)
(setq frm (getreal "\nEnter Frame Offset: "))
;This offset for frame could honestly go but dont know how to get rid of it without breaking everything
(initget 7)
(setq xnum (getint "\nEnter Number of Columns (W): "))
(initget 7)
(setq ynum (getint "\nEnter Number of Rows (H): "))
(initget 7)
(setq xspace(setq yspace (getreal "\nEnter Bar Face: ")))
(initget 7)
;Example of possible addition below
;
;(setq tdlx (setq tdly (getreal "\nEnter Profile Width: ")))
;Would ideally like to add an IF function that "triggers" this prompt
;Not sure how to code it but logically speaking it would be like so,
; IF TDL = True THEN getreal tdlx, tdly (both x and y would be same value so
;im assuming it could be one variable instead of two
;
(setq pt1 (getpoint "\nSelect Lower Left Window Corner: ")
pt3 (getpoint pt1 "\nSelect Upper Right Window Corner: ")
;getpoints are fine, suitable selection method.
pt2 (list (car pt3)(cadr pt1))
pt4 (list (car pt1)(cadr pt3))
;Looks like the last 2 points are grabbed by using the opposites x and y
ptc (mapcar '(lambda (q p) (/ (+ q p) 2.0)) pt1 pt3)
;dont really get this one, i know mapcar returns a list of executing a function
;but i dont really know what that realistically means
;pretty sure lambda is for defining temporary variables that aren't Defun'd
;but have no idea what the results of q and p are or why 2 is hard coded
xlen (- (distance pt1 pt2) (* 2 frm))
ylen (- (distance pt1 pt4) (* 2 frm))
;easy enough to understand, distance between 2 points minus the offset
;from either side for "actual" distance
xpane (/ (- xlen (* (1- xnum) xspace)) xnum)
;Am i reading the above right? xnum-1, *xspace, *xnum, -xylen, /xpane
;just trying to understand the structure
ypane (/ (- ylen (* (1- ynum) yspace)) ynum)
ptp1 (list (+ (car pt1) frm)(+ (cadr pt1) frm))
; the above sets ptp1 X and Y by first
;listing X from PT1 with CAR+frm and then lists Y from pt1 with CADR+frm, right?
ptp2 (list (+ (car ptp1) xpane)(cadr ptp1))
ptp3 (list (+ (car ptp1) xpane)(+ (cadr ptp1) ypane))
ptp4 (list (car ptp1)(+ (cadr ptp1) ypane))
)
;Not 100% understanding the code above for defining the points but i get
;the gist of it, I dont know how the frame variable is interacting with everything
;which is why I haven't removed it myself. When i tried it threw everything out of wack
(entmakex (append (list (cons 0 "LWPOLYLINE")
(cons 100 "AcDbEntity")
(cons 100 "AcDbPolyline")
(cons 90 4)
(cons 70 1)
(cons 10 ptp1)
(cons 10 ptp2)
(cons 10 ptp3)
(cons 10 ptp4))))
;Looks like this draws a single square?
;not really clear on how cons works
(setq pane (entlast))
(setq pane2 (entlast))
(setq ss (ssadd pane ss))
;(setvar 'clayer "Geometry_0")
(setq co-ord (mapcar 'cdr (vl-remove-if-not '(lambda (x) (= (car x) 10)) (entget pane))))
(vla-offset (vlax-ename->vla-object pane) frm)
;(vla-put-layer (vlax-ename->vla-object (entlast)) "Geometry_0")
(setq ss (ssadd (entlast) ss))
(setq co-ord2 (mapcar 'cdr (vl-remove-if-not '(lambda (x) (= (car x) 10)) (entget (entlast)))))
(setq k -1)
(repeat 4
(command "line" (nth (setq k (1+ k)) co-ord)(nth k co-ord2) "")
(setq ss (ssadd (entlast) ss))
)
(setvar 'clayer oldlay)
;sets pane to the square made by to bit of code above right?
(setq ptc (mapcar '(lambda (q p) (/ (+ q p) 2.0)) ptp1 ptp2))
;ptc mapcar thing i dont really understand again
; (setq pane2 (entlast))
; huh? when did a second pane get made?
(cond
((AND (= ynum 1)(= xnum 1)) T)
((= ynum 1) (command "-array" ss "" "R" ynum xnum (+ xpane xspace)))
((= xnum 1) (command "-array" ss "" "R" ynum xnum (+ ypane yspace)))
((OR (> ynum 1)(> xnum 1)) (command "-array" ss "" "R" ynum xnum (+ ypane yspace) (+ xpane xspace)))
(t nil)
)
;something to do with creating the array
(setvar 'clayer oldlay)
(princ)
)
(c:lp)
