2016 acad lisp program returns "to many arguments"
By the way, unrelated to the question at hand, you can reduce the file size by eliminating a whole batch of (progn) functions, in two ways:
1. You can combine multiple variable settings in one (setq) function, so in many of your instances the one (setq) can be the 'then' argument to an (if) function, rather than a bunch of (setq)'s "wrapped" inside a (progn) function. One short example -- this:
(if (= file2 4)
(progn
(setq block12 "C:/Block Viewer2/Ferrule Tank Kettle Valve NZ-FER-001/4_in_bom_260")
(setq block13 "4_IN_BOM")
(setq block1 "C:/Block Viewer2/Ferrule Tank Kettle Valve NZ-FER-001/4_in_side_260")
(setq block14 "4_IN_SIDE")
(setq file1 nil)
)
)
can be done this way:
(if (= file2 4)
(setq
block12 "C:/Block Viewer2/Ferrule Tank Kettle Valve NZ-FER-001/4_in_bom_260" ;; note right parentheses removed
block13 "4_IN_BOM"
block1 "C:/Block Viewer2/Ferrule Tank Kettle Valve NZ-FER-001/4_in_side_260"
block14 "4_IN_SIDE"
file1 nil
); setq ;; this right parenthesis covers all variable settings
); if
2. In a "satisfied" condition in a (cond) function, you don't need to "wrap" multiple functions inside a (progn) function, the way you do for the 'then' or 'else' argument to an (if) function [even if you were to keep separate (setq) functions as in most of your (cond)/(progn) functions]. You can change this [a shorter example]:
((= file3 2)
(progn
(setq block12 "C:/Block Viewer2/Lifting Lugs/Lifting lug silo SI-LLG-001/lug_bom_330")
(setq block13 "LUG_BOM")
(setq block1 "C:/Block Viewer2/Lifting Lugs/Lifting lug silo SI-LLG-001/lug_side_330")
(setq block14 "LUG_SIDE")
(setq block2 "C:/Block Viewer2/Lifting Lugs/Lifting lug silo SI-LLG-001/lug_top_330")
(setq block15 "LUG_TOP")
(setq file4 nil)
); progn
); file3 = 2 condition
to this:
((= file3 2)
(setq
block12 "C:/Block Viewer2/Lifting Lugs/Lifting lug silo SI-LLG-001/lug_bom_330"
block13 "LUG_BOM"
block1 "C:/Block Viewer2/Lifting Lugs/Lifting lug silo SI-LLG-001/lug_side_330"
block14 "LUG_SIDE"
block2 "C:/Block Viewer2/Lifting Lugs/Lifting lug silo SI-LLG-001/lug_top_330"
block15 "LUG_TOP"
file4 nil
); setq
); file3 = 2 condition
@Anonymous wrote:
Below are the last two modifications i made. the error occurs when he runs the program. ....
There are certain ways of omitting or misplacing parentheses and/or double-quotes, or having extra ones, that might result in the kind of error message you're seeing, though A) I didn't see any such omissions/misplacements/extras in any of the (if)/(progn)/(setq) functions in what you posted, and B) such an error should affect all Users. And the (mode_tile) function there has the same number and kinds of arguments as in scores of other places.
Could it be something not within the area where you changed things, but downstream somewhere in the use of those settings? Since it looks like all the Block name settings are in C: drive locations, they must be local to each computer. Might that one computer be missing a folder, or have a sub-folder shifted to be in the wrong place [we once had a draftsperson who pretty often picked on a folder and held onto it too long while shifting their mouse a little, and a folder would end up moved to end up inside an adjacent one, rather than opened], or some such thing? Check that User's file structure. If you can, try having all those things in folders in a shared location such as on a Server, where there can't be differences from one User to another.
@Anonymous wrote:
.... i will try the suggested changes to simply the program. knowing mine does it as well, i can fix it as soon as i have time. currently looking to see if the dialog box setting is turned off on his machine.
....
As BeekeeCZ said, the suggestions I made are not critical, and besides, they won't fix the problem you're having [as I started off in that Post, they're unrelated to the question at hand]. I would concentrate on finding and fixing the problem, and then if you want to tweak things, do it in a copy that you can test thoroughly before replacing a working [if longer] version.
