Place mutiple famiy symbols

[denisyukJ]

Hi,

I would like to place multiple symbols, but can not unserstand how to do it one transaction, the following code throws exception. fs variable returns me instance of FamilySymbols class.  What am I doing wrong?

            using (Transaction t = new Transaction(doc, "asd"))
            {
                foreach (var item in ll)
                {
                    var fs = RevitFunctions.GetFamilySymbol(doc, item.FamilyName, item.FamilySymbolName);
                    doc.Create.NewFamilyInstance(new XYZ(), fs, Autodesk.Revit.DB.Structure.StructuralType.NonStructural);
                }
            }

.

[naveen.kumar.t]

Hi @denisyukJ ,

What exception are you encountering?
What types of family symbols are you using?
Does it require a host?

In the sample code you shared, the transaction is neither started nor committed.

[denisyukJ]

Hi, @naveen.kumar.t 

Thanks for note about transaction management. It makes my code work, but it's simplidied sample. Before it I use to work with wraper method includes transaction: 

public static void CreateTransaction(Document document, string transactionName, Action action)
{
    lock (SingleLocker)
    {
        using (var transaction = new Transaction(document))
        {
            transaction.Start(transactionName);
            try
            {
                action?.Invoke();
                transaction.Commit();
            }
            catch (Exception)
            {
                transaction.RollBack();
            }
        }
         

... and on this case execusion looks like this:

public static void PlaceFs(Document doc, List<ComponentInfo> combs, XYZ pt)
{
    TransactionManager.CreateTransaction(doc, "Размещение вертикальных элементов", () =>
    {
        {
            try
            {
                foreach (var item in combs)
                {
                    pt = new XYZ(pt.X, pt.Y, (double)item.Z);
                    RevitFunctions.CreateNewInstance(doc, item, pt);
                }

            }
            catch { }
        }
    }
    );
}

 Let me ask in another way -- what is the best practice to place multiple family symbols (in my case its mechanical elements) collected from FilterElementCollector?

[Moustafa_K]

you can use NewFamilysymbole2. this will create a patch placement a sample is also provided over the link