Can't close MDIdocument
The code itself you post is not the source of the problem. It is the context where the code runs in: does the code run in application context, or in document context? If it is latter, you cannot close a document while code runs in its context.
In you case, what does "batch script" mean? Is it a *.scr file (AutoCAD script file) that list a bunch of commands (including you custom commands defined with "CommandMethod" attribute)?
If the showed code runs within "CommandMethod" decorated class method, you need to set CommandFlags.Session to indicate the code should be executed in application context, so that you can close document.
You might want to post more code that tells how the code is executed (i.e. the usual CommandClass and/or the IExtensionApplication class where the AutoCAD .NET API code gets run from).
Accepted solution
Something happend: I just posted a reply a few minutes ago (which I have seen it) is now gone. So here I re-post it:
Your code seems OK in regarding opening, saving and closing drawings with CommandFlags.Session set. Maybe there is other thing you did not mention/reveal.
Here is my much simplified code that opens multiple drawings, changes something in each drawing's DB, and then saves and closes:
using System.Collections.Generic;
using Autodesk.AutoCAD.ApplicationServices;
using Autodesk.AutoCAD.DatabaseServices;
using Autodesk.AutoCAD.Runtime;
using CadApp = Autodesk.AutoCAD.ApplicationServices.Application;
[assembly: CommandClass(typeof(BatchWorkTest.MyCommands))]
namespace BatchWorkTest
{
public class MyCommands
{
[CommandMethod("BatchDwg", CommandFlags.Session )]
public static void RunCommand()
{
var dwg = CadApp.DocumentManager.MdiActiveDocument;
var ed = dwg.Editor;
var fileNames = GetFileNames();
if (fileNames==null)
{
ed.WriteMessage("\n*Cancel*");
return;
}
ProcessDwgs(fileNames);
}
private static IEnumerable<string> GetFileNames()
{
IEnumerable<string> files = null;
using (var dialog = new System.Windows.Forms.OpenFileDialog
{
DefaultExt = ".dwg",
Multiselect = true,
Filter = "dwg files|*.dwg",
})
{
if (dialog.ShowDialog()== System.Windows.Forms.DialogResult.OK)
{
files = dialog.FileNames;
}
}
return files;
}
private static void ProcessDwgs(IEnumerable<string> dwgFiles)
{
var dwgCol = CadApp.DocumentManager;
foreach (var dwgFile in dwgFiles)
{
// Since the CommnadFlags.Session flag is set
// The newly opened drawing becomes MdiActiveDocument automatically
var dwg = dwgCol.Open(dwgFile, false, null);
using (var lck = dwg.LockDocument())
{
DoSomethingInDwg(dwg);
}
// Save and close
dwg.Database.SaveAs(dwg.Name, true, DwgVersion.Current, null);
dwg.CloseAndDiscard();
}
}
private static void DoSomethingInDwg(Document dwg)
{
//CadApp.ShowAlertDialog($"Processing drawing:\n{dwg.Name}");
//change 2 user system variables
dwg.Database.Useri1 = 1;
dwg.Database.Useri2 = 2;
}
}
}
Here is screencast clip showing how the code work through:
HTH
@yoitsarun wrote:
Hi @norman.yuan ,
Sorry to ask in this post. I am using your above code exactly for my plugin.
I want to make it side open. Now it takes too much to time to open all the files in batch process.
By "...make it side open", I assume you mean open each drawing as side database (so, you do not have to open the drawing in AutoCAD editor visually, which takes longer time), right? if so, simply change my posted code a bit like this:
private static void ProcessDwgs(IEnumerable<string> dwgFiles)
{
foreach (var dwgFile in dwgFiles)
{
using (var db=new Database(false, true)
{
db.ReadDwgFile(dwgFile, FileOpenMode.OpenForReadAndAllShare, true, null)
DoSomethingInDwg(db);
// Save and close
db.SaveAs(dwg.Name, true, DwgVersion.Current, null);
}
}
}
private static void DoSomethingInDwg(Database db)
{
//CadApp.ShowAlertDialog($"Processing drawing:\n{db.Filename}");
//change 2 user system variables
db.Useri1 = 1;
db.Useri2 = 2;
}
Also, in the [CommandMethod(...)] attribute, there is no need to set CommandFlags.Session flag (but leave it would be harmless as the code is, in this case).
HTH
Did you step through the code in debugging, and which line of the code resulted in the error?
Some critiques to the code:
In DoSomething() method,
1. Why do you need to have Document argument, which is completely no used at all.
2. is my old sample code, the 2 lines
db.Useri1=1;
db.Useri2-2;
was just there to show that you can do something with a side database. You do not just copy them over to your code, unless your specific process happens to need them.
3. There is no need to declare a variable to point to MdiActiveDocument and not use it in the method.
4. You do not need to use
using (db)
{
....
}
in this method, because the side database has already been wrapped by "using(...){...}" block in the calling code (ProcessDwgs() method)
In ProcessDwgs() method:
1. Again, I do not see why you need a Document argument (well, you might argue that you use "dwg" parameter to get new dwg file name, see 2);
2. the way you obtain a new dwg file name for saving changed side database produces the same file name for all side databases being processed., so you would end up only the last processed database being saved. You should use Database .FileName of each processed side database to generate new file name.
3. dwg.ClaseAndDiscard() is not needed. It was in my old sample code, because the original question was about opening multiple drawing in AutoCAD editor for processing. If you read the code I posted to your request, there was no this line, because now the code opens side database one by one, not drawing in AutoCAD editor visually. As matter of fact, this line might be the offensive line that caused the error. You need to remove it.
Here is the code I modified for you (not tested, with NotePad, so there may be typos):
namespace BatchWorkTest
{
public partial class MyCommands
{
...
...
private void ProcessDwgs(IEnumerable<string> dwgFiles)
{
// Use Acad's progress bar, so that AutoCAD would not looks like
// frozen during long processing
using (var prog = new ProgressMeter())
{
prog.SetLimit(dwgFiles.Count());
prog.Start("Processing DWG files...";
foreach (var dwgFile in dwgFiles)
{
prog.ProgressMether();
using (var db=new Database(false, true))
{
db.ReadDwgFile(dwgFile, FileOpenMode.OpenForReadAndWriteNoShare, true, null);
DoSomethingInDwg(db);
// Save changed database
string prefix = "Acad-";
string newFileName = Path.Combine(Path.GetDirectoryName(db.Filename), prefix + Path.GetFileName(db.Filename));
db.SaveAs(newFileName, true, DwgVersion.Current, default);
}
}
prog.Stop();
}
}
private static bool DoSomethingInDwg(Database db)
{
using (Transaction tr = db.TransactionManager.StartTransaction())
{
var collection = new ObjectIdCollection();
BlockTable bt = tr.GetObject(db.BlockTableId, OpenMode.ForRead) as BlockTable;
foreach (ObjectId btrId in bt)
{
BlockTableRecord btr = tr.GetObject(btrId, OpenMode.ForRead) as BlockTableRecord;
if (btr.IsFromExternalReference & btr.IsUnloaded)
{
collection.Add(btrId);
btr.UpgradeOpen();
string oldPath = btr.PathName;
string newpath = @"C:\ProgramData\Autodesk\ApplicationPlugins\XrefBind.bundle\Contents\Resources\CadART.dwg";
btr.PathName = newpath;
}
}
if (collection.Count > 0)
{
db.ReloadXrefs(collection);
}
tr.Commit();
}
using (var bTran = db.TransactionManager.StartTransaction())
{
var bBT = (BlockTable)db.BlockTableId.GetObject(OpenMode.ForRead);
var XrefIds = new ObjectIdCollection();
foreach(ObjectId brId in bBT)
{
var bBTRr = (BlockTableRecord)bTran.GetObject(brId, OpenMode.ForRead);
if (bBTRr.IsFromExternalReference & bBTRr.IsResolved)
{
XrefIds.Add(bBTR.Id);
}
}
if (XrefIds.Count>0)
{
try
{
db.BindXrefs(XrefIds, false);
}
catch (Exception ex)
{
Application.ShowAlertDialog("this drawing don't have any xref or xrefs are unreferenced, Error: " + ex.Message);
}
}
bTrans.Commit();
}
}
}//end of class
}// end of namespace