Total Length of Selected Objects
Accepted solution
Accepted solution
Hi,
First, thanks for sharing.
If I may have some suggestions:
- You should use a selection filter to get only measurable entities.
- You do not need to test the existence of an implied selection set, CommandFlags.UsePickSet will do all the magic (including the selection filter).
- Optionally, you can also use Linq to process the selection set in a more declarative way.
using Autodesk.AutoCAD.DatabaseServices;
using Autodesk.AutoCAD.EditorInput;
using Autodesk.AutoCAD.Runtime;
using System.Linq;
using AcAp = Autodesk.AutoCAD.ApplicationServices.Application;
[assembly: CommandClass(typeof(TotalLength.Commands))]
namespace TotalLength
{
public class Commands
{
[CommandMethod("TOTLEN", CommandFlags.UsePickSet)]
public void TotalLength()
{
var doc = AcAp.DocumentManager.MdiActiveDocument;
var db = doc.Database;
var ed = doc.Editor;
// build a selection filter to get only measurable entities
var filter = new SelectionFilter(new[]
{
new TypedValue(-4, "<OR"),
new TypedValue(0, "ARC,CIRCLE,ELLIPSE,LINE,LWPOLYLINE,SPLINE"),
new TypedValue(-4, "<AND"),
new TypedValue(0, "POLYLINE"), // polylines 2d or 3d
new TypedValue(-4, "<NOT"), // but not meshes
new TypedValue(-4, "&"),
new TypedValue(70, 112),
new TypedValue(-4, "NOT>"),
new TypedValue(-4, "AND>"),
new TypedValue(-4, "OR>")
});
var selection = ed.GetSelection(filter);
if (selection.Status != PromptStatus.OK)
return;
using (var tr = db.TransactionManager.StartTransaction())
{
// use Linq queries to get lengths by type in a dictionary
var lengthes = selection.Value
.Cast<SelectedObject>()
.Select(so => (Curve)tr.GetObject(so.ObjectId, OpenMode.ForRead))
.ToLookup(curve => curve.GetType().Name, // <- key selector
curve => curve.GetDistanceAtParameter(curve.EndParam)) // <- element selector
.ToDictionary(group => group.Key, // <- key selector
group => group.Sum()); // <- element selector
// print results
foreach (var entry in lengthes)
{
ed.WriteMessage($"\n{entry.Key,-12} = {entry.Value,9:0.00}");
}
ed.WriteMessage($"\nTotal Length = {lengthes.Values.Sum(),9:0.00}");
tr.Commit();
}
AcAp.DisplayTextScreen = true;
}
}
}
1. Because var is shorter to type than most explicit types and give the same result. Furthemore, IMO, it makes the code more readable (avoiding redundancy as: SelectionFilter filter = new SelectionFilter()). Using inferred type is also an F# habit.
2. Using the int values of the DxfCode enum in selection filters is a old AutoLISP habit.
- -4 stands for: (int)DxfCode.Operator and is used with relational operators and logical grouping operators.
- 0 stands for: (int)DxfCode.Start and is used with entities DXF names.
- 70 stands for (int)DxfCode.Int16 and is typically used for bit flags, for the POLYLINE DXF type it specifies the polyline type.
3. Getting started with LINQ in C# may be a good start. Within AutoCAD we mostly use LINQ to Objects with AutoCAD collections. By my side, I prefer use the Method Syntax with IEnumerable<T> extension methods and lambda expressions (again my functional programming background with LISP and F#).
Hi,
I'm not very comfortable with VB but it seems to me the issue is due to the way the converter converted the typedValue array initialisation.
try this way (not tested)
Public Sub TotalLength()
Dim doc = AcAp.DocumentManager.MdiActiveDocument
Dim db = doc.Database
Dim ed = doc.Editor
Dim filter = New SelectionFilter(New TypedValue() { _
New TypedValue(-4, "<OR"), _
New TypedValue(0, "ARC,CIRCLE,ELLIPSE,LINE,LWPOLYLINE,SPLINE"), _
New TypedValue(-4, "<AND"), _
New TypedValue(0, "POLYLINE"), _
New TypedValue(-4, "<NOT"), _
New TypedValue(-4, "&"), _
New TypedValue(70, 112), _
New TypedValue(-4, "NOT>"), _
New TypedValue(-4, "AND>"), _
New TypedValue(-4, "OR>") })
Dim selection = ed.GetSelection(filter)
If selection.Status <> PromptStatus.OK Then Return
Using tr = db.TransactionManager.StartTransaction()
Dim lengthes = selection.Value _
.Cast(Of SelectedObject)() _
.Select(Function(so) CType(tr.GetObject(so.ObjectId, OpenMode.ForRead), Curve)) _
.ToLookup(Function(curve) curve.GetType().Name, Function(curve) curve.GetDistanceAtParameter(curve.EndParam)) _
.ToDictionary(Function(group) group.Key, Function(group) group.Sum())
For Each entry In lengthes
ed.WriteMessage($"\n{entry.Key} = {entry.Value}")
Next
ed.WriteMessage($"\nTotal Length = {lengthes.Values.Sum()}")
tr.Commit()
End Using
AcAp.DisplayTextScreen = True
End Sub
Anyway, the use of an online converter and copy / paste without trying to understand the code does is the worst way to learn.
You should re-write the code to suit your coding conventions or habits.
Working solution (tested with AutoCAD 2017)
The Compile Options settings:
Explicit = On
Strict = On
Infer = On
Imports Autodesk.AutoCAD.ApplicationServices
Imports Autodesk.AutoCAD.DatabaseServices
Imports Autodesk.AutoCAD.EditorInput
Imports Autodesk.AutoCAD.Runtime
Public Class Commands
<CommandMethod("TOTLEN", CommandFlags.UsePickSet)>
Public Sub TotalLength()
Dim doc = Application.DocumentManager.MdiActiveDocument
Dim db = doc.Database
Dim ed = doc.Editor
Dim filter = New SelectionFilter(New TypedValue() {
New TypedValue(-4, "<OR"),
New TypedValue(0, "ARC,CIRCLE,ELLIPSE,LINE,LWPOLYLINE,SPLINE"),
New TypedValue(-4, "<AND"),
New TypedValue(0, "POLYLINE"),
New TypedValue(-4, "<NOT"),
New TypedValue(-4, "&"),
New TypedValue(70, 112),
New TypedValue(-4, "NOT>"),
New TypedValue(-4, "AND>"),
New TypedValue(-4, "OR>")})
Dim selection = ed.GetSelection(filter)
If selection.Status <> PromptStatus.OK Then Return
Using tr = db.TransactionManager.StartTransaction()
Dim lengthes = selection.Value _
.Cast(Of SelectedObject)() _
.Select(Function(so) CType(tr.GetObject(so.ObjectId, OpenMode.ForRead), Curve)) _
.ToLookup(Function(curve) curve.GetType().Name, Function(curve) curve.GetDistanceAtParameter(curve.EndParam)) _
.ToDictionary(Function(group) group.Key, Function(group) group.Sum())
For Each entry In lengthes
ed.WriteMessage($"{vbLf}{entry.Key} = {entry.Value}")
Next
ed.WriteMessage($"{vbLf}Total Length = {lengthes.Values.Sum()}")
tr.Commit()
End Using
Application.DisplayTextScreen = True
End Sub
End Class
