I downloaded the 2023 version of the VBA add-on, and I'm still getting two issue copying the exact code you've provided.
1: Next is still looking for the beginning of a For loop, so I commented that out
2: im getting a pause at a different line at the IF statement. Topnode looks like it's still a valid object in VBA for Active pane (which you should be able to confirm by erasing the .TopNode and typing the period. This will let you see the list of possible objects/options for ActivePane)
I get this error:
Interesting, my error was before that at setting oTopNode... I agree it's missing a for each, and it compiled previously without it but starting giving me the same error but the macro ran fine for years without it. I get the impression something changed in the program and the method was never updated
Just curious about one little detail... I noticed that you are using 'ActiveEditDocument' instead of 'ActiveDocument'. Are you planning on using this code to effect the referenced document of an assembly component that you are in 'Edit Mode' of within an assembly? That 'ActiveEditDocument' term is basically made for that scenario, but will work in other scenarios too. If you are editing a component within an assembly when you run this macro, that may (or may not) be the problem. I am not sure this will work on a document that is not 'visibly' open (so you can actually see its browser tree on your screen at the time). I know you can access things in another document's browser tree without it being visibly open, but I am not sure if you can effect it in this way, without it actually being the 'active' document on your screen at the time. Have you tested that theory?
Wesley Crihfield
(Not an Autodesk Employee)
Hi @e_frissell. I knew your post seemed familiar somehow but couldn't recall why. I had used some code pretty much identical to the one you first posted years ago when I was first getting started into this stuff, but my code was in iLogic instead of VBA. At the time I used a simple iLogic rule to investigate what those internal names were in other document types, because when I first started responding on these forums, I found out that there were folks on here from many other countries, and that the 'English' names for some stuff I was working with did not always work some of those other folks who had other language versions of Inventor. Those internal names were stable across all languages, unlike the 'local' regular names of some objects. I did not use a Function like the nice one posted above by @A.Acheson, but came to similar conclusion. I had two different versions of the iLogic code. One version looped through all top level nodes under the top node, and made sure they were not expanded. The other version selected that top node, then executed a command, similar to the one that gets executed when you use the right-click method manually. Below are both versions of code, but in VBA instead of iLogic, since your original code above was in VBA.
Version 1:
Sub CollapseModelTreeNodes()
Dim oDoc As Document
Set oDoc = ThisApplication.ActiveDocument
Dim oTopNode As BrowserNode
If oDoc.DocumentType = DocumentTypeEnum.kAssemblyDocumentObject Then
Set oTopNode = oDoc.BrowserPanes.Item("AmBrowserArrangement").TopNode
ElseIf oDoc.DocumentType = DocumentTypeEnum.kDrawingDocumentObject Then
Set oTopNode = oDoc.BrowserPanes.Item("DlHierarchy").TopNode
ElseIf oDoc.DocumentType = DocumentTypeEnum.kPartDocumentObject Then
Set oTopNode = oDoc.BrowserPanes.Item("PmDefault").TopNode
End If
If oTopNode Is Nothing Then Exit Sub
'If oTopNode.Expanded Then oTopNode.Expanded = False 'can not undo manually
If oTopNode.BrowserNodes.Count > 0 Then
Dim oNode As BrowserNode
For Each oNode In oTopNode.BrowserNodes
If oNode.Visible And oNode.Expanded Then oNode.Expanded = False
Next
End If
End SubVersion 2:
Sub CollapseModelTreeNodes2()
Dim oDoc As Document
Set oDoc = ThisApplication.ActiveDocument
Dim oTopNode As BrowserNode
If oDoc.DocumentType = DocumentTypeEnum.kAssemblyDocumentObject Then
Set oTopNode = oDoc.BrowserPanes.Item("AmBrowserArrangement").TopNode
ElseIf oDoc.DocumentType = DocumentTypeEnum.kDrawingDocumentObject Then
Set oTopNode = oDoc.BrowserPanes.Item("DlHierarchy").TopNode
ElseIf oDoc.DocumentType = DocumentTypeEnum.kPartDocumentObject Then
Set oTopNode = oDoc.BrowserPanes.Item("PmDefault").TopNode
End If
If oTopNode Is Nothing Then Exit Sub
oDoc.SelectSet.Clear
oDoc.SelectSet.Select (oTopNode.NativeObject)
ThisApplication.CommandManager.ControlDefinitions.Item("AppBrowserCollapseChildrenCmd").Execute
End SubSince a similar amount of code is used for both versions, I greatly prefer the version that does not call the command to execute though. But since my installation of Inventor is for English language, I tend to simply use the name "Model" in my working code, to keep the code shorter and simpler, and that works just fine for me, without needing to know the internal names. Plus, in my iLogic versions, I tend to use 'ThisDoc.Document' instead of 'ThisApplication.ActiveDocument', because it tends to work better in more scenarios...just a personal preference. I have also been avoiding the use of VBA as much as possible, in favor of iLogic the past couple years, for security reasons. Below is a link to an article about that.
Wesley Crihfield
(Not an Autodesk Employee)
@A.Acheson unfortunately the function doesn't work - I really think that something happened between Inventor 2021 and 2023 because the original macro worked well (I can't take credit for writing it, I just happened to find it) and after making a few updates to let the macro run, the collapsed design tree is not what we're used to. Example: the first photo is the design tree prior to running the macro, then the second photo is the design tree after.
Hi @e_frissell. That last version you posted was not using the function correctly. When you call a Sub routine to run in VBA, you just use the keyword 'Call' followed by the name of the Sub routine, but when calling a Function routine to run, those are designed to 'return' something to the 'main' routine that called it to run, so you need to prepare a variable to hold what the function is supposed to return. Below is a slightly edited version of what you just posted, that captures what the function returns, then uses that result when getting the 'TopNode', instead of going ahead and using the 'ActivePane' which you were doing before all of this.
Public Sub CollapseDesignTree()
Dim oDoc As Document
Set oDoc = ThisApplication.ActiveDocument
Dim oModelPane As BrowserPane
Set oModelPane = GetDocumentBrowserPane(oDoc)
Dim oTopNode As BrowserNode
Set oTopNode = oModelPane.TopNode
If oTopNode.Expanded = True Then
oTopNode.Expanded = False
End If
' Dim oNode As BrowserNode
' For Each oNode In oTopNode.BrowserNodes
' If oNode.Visible = True And oNode.Expanded = True Then
' oNode.Expanded = False
' End If
' Next
End Sub
Public Function GetDocumentBrowserPane(oDoc As Document) As BrowserPane
Dim oModelBP As BrowserPane
'Get the Model BrowserPane for Part
If (oDoc.DocumentType = kPartDocumentObject) Then
Set oModelBP = oDoc.BrowserPanes.Item("PmDefault")
End If
'Get the Model BrowserPane for Assembly
If (oDoc.DocumentType = kAssemblyDocumentObject) Then
Set oModelBP = oDoc.BrowserPanes.Item("AmBrowserArrangement")
End If
'Get the Model BrowserPane for Drawing
If (oDoc.DocumentType = kDrawingDocumentObject) Then
Set oModelBP = oDoc.BrowserPanes.Item("DlHierarchy")
End If
Set GetDocumentBrowserPane = oModelBP
End FunctionWesley Crihfield
(Not an Autodesk Employee)
I also had multiple previous Autodesk accounts/profiles, but I wasn't really as active in the online stuff with some of those previous accounts as a have been with this one. VBA is an older coding system that was centered around Microsoft's Office products, while the VB.NET system (also used by iLogic) is newer and more dynamic. In VBA you usually have to use the 'Call' keyword to call routines to run, but there are actually two different ways to do it too (use 'Call' keyword then enclose input variables within the () brackets ... or ... don't use the 'Call' keyword, then do not enclose input variables within the () brackets), but that is not necessary in vb.net (always enclose input variables within () brackets). In VBA you have to use the 'Set' keyword on reference type variables, but not on variables for String, Integer, Double, and such data types. The 'Set' keyword is not needed in vb.net. There are also several object types that are not readily available in VBA, that are available in vb.net (and the other way around). One of the main attractions for using VBA with Inventor instead of iLogic is that the VBA editor has a much more advanced user interface and tools available to work with though.
Wesley Crihfield
(Not an Autodesk Employee)
I personally do not like to collapse everything into just that one top node like that, because it is difficult to undo that manually, if needed. I personally prefer to not collapse that 'TopNode' itself, and just collapse all of its 'children' (BrowserNodes under it), because that is much more natural looking, and can easily be undone manually if I want to. That is what the commented out part would have done, by itself, if the top node collapse part was commented out instead.
Wesley Crihfield
(Not an Autodesk Employee)
