topic Re: CODE correction for extract ATTRIBUTE in Visual LISP, AutoLISP and General Customization Forum

CODE correction for extract ATTRIBUTE

Anonymous — Sun, 11 Oct 2020 14:50:28 GMT

Dear All,

I am writing a code to extract block ATTRIBUTE into excel file like below. I can load the lisp without any issue. While running in CAD the loop is not completed. And i put something wrong somewhere. but i could not correct that. Could you please anyone correct me and teach me where i put wrong. ?

I have attached my Lisp and CAD block file here.

(defun c:ATTX() (setq filePath "c:\\temp\\") (setq fileName "P&ID List") (setq fileLoc (strcat filePath fileName ".csv")) (setq xcelfile(open fileLoc "w")) (setq blocks (ssget "_X" '((0 . "INSERT") (8 . "VALVE")))) (setq ctr 0) (setq len (sslength blocks)) (write-line (strcat "ValveTag") xcelfile) (while (/= ctr len) (setq blk (ssname blocks ctr)) (setq blks (entget blk)) (setq flag T) (while flag (setq lArea (entget(entnext(cdr(assoc -1 blks))))) (setq attrib1 (cdr(assoc 0 lArea))) (if (= attrib1 "ATTRIB") (progn (setq tagnameArea (cdr(assoc 2 lArea))) (if (= tagnameArea "VALVETAG") (setq valveTag (cdr (assoc 1 lArea))) ) ) (setq flag nil) ) ) (write-line (valveTag) xcelfile) (setq ctr (1+ ctr)) ) (close xcelfile) (princ (strcat " Extraction is complete. " fileName " has been created. ")) (princ) )

Re: CODE correction for extract ATTRIBUTE

hak_vz — Sun, 11 Oct 2020 14:54:35 GMT

(while (/= ctr len)

replace with

(while (< ctr len)

Re: CODE correction for extract ATTRIBUTE

Anonymous — Sun, 11 Oct 2020 15:09:25 GMT

Thanks for your fastest reply,

But i have no luck.

It is still the same model of loading when running the lisp file.

The lisp file is working and its complete the process without writing anything in the excel file. If I put the code like the below.

(while(> ctr len)

Re: CODE correction for extract ATTRIBUTE

hak_vz — Sun, 11 Oct 2020 15:14:06 GMT

OK. Upload dwg the file with predefined blocks and layers for easier work.

I will check the code to for error.

Re: CODE correction for extract ATTRIBUTE

hak_vz — Sun, 11 Oct 2020 15:27:52 GMT

Try this

(defun c:ATTX() (cond ((and (setq f (getfiled "Output .csv file:" (getvar "dwgprefix") "csv" 3))) (setq outstring (strcat "\nExtraction is complete. " f " has been created. ")) (setq xcelfile (open f "w")) (setq blocks (ssget "_X" '((0 . "INSERT") (8 . "VALVE")))) (setq ctr 0) (setq len (sslength blocks)) (write-line "ValveTag" xcelfile) (while (< ctr len) (setq blk (ssname blocks ctr)) (setq blks (entget blk)) (setq flag T) (while flag (setq lArea (entget(entnext(cdr(assoc -1 blks))))) (setq attrib1 (cdr(assoc 0 lArea))) (if (= attrib1 "ATTRIB") (progn (setq tagnameArea (cdr(assoc 2 lArea))) (if (= tagnameArea "VALVETAG") (setq valveTag (cdr (assoc 1 lArea))) ) ) (setq flag nil) ) ) (write-line valveTag xcelfile) (setq ctr (1+ ctr)) ) (close xcelfile) (princ outstring) ) ) (princ) )

Re: CODE correction for extract ATTRIBUTE

pbejse — Sun, 11 Oct 2020 15:31:50 GMT

(defun c:ATTX ( / blocks filePath fileName fileLoc xcelfile ctr len valvetag blk ) (if (and ;; ensure that there are block objects on this layer ;;; (setq blocks (ssget "_X" '((0 . "INSERT")(66 . 1)(8 . "VALVE")))) ;; Checks if directory exist ;; (findfile (setq filePath "c:\\temp")) (setq fileName "P&ID List" fileLoc (strcat filePath "\\" fileName ".csv")) (setq xcelfile(open fileLoc "w")) (setq ctr 0 len (sslength blocks)) ) (progn (write-line (strcat "ValveTag") xcelfile) ;; while ctr valeu is less than len ;; ;; selection sets are 0 index ;; (while (< ctr len) (setq blk (ssname blocks ctr)) (while (and (null valveTag) (setq blk (entnext blk)) (= "ATTRIB" (cdr (assoc 0 (setq enx (entget blk))))) ) (setq valveTag (cdr (assoc 1 (reverse enx)))) ) (write-line valveTag xcelfile) (setq ctr (1+ ctr) valveTag nil) ) (close xcelfile) (princ (strcat " Extraction is complete. " fileName " has been created. ")) ) (princ "\nNo valid block(s) found") ) (princ) )

Re: CODE correction for extract ATTRIBUTE

_Tharwat — Sun, 11 Oct 2020 15:38:59 GMT

Following your way of coding but you need to localize the variables.

(defun c:ATTX () (setq filePath "c:\\temp\\") (setq fileName "P&ID List") (setq fileLoc (strcat filePath fileName ".csv")) (setq xcelfile (open fileLoc "w")) (if (setq blocks (ssget "_X" '((0 . "INSERT")(66 . 1)(8 . "VALVE")))) (progn (setq len (sslength blocks)) (write-line (strcat "ValveTag") xcelfile) (while (setq blk (ssname blocks (setq len (1- len)))) (setq blks (entget blk)) (while (and (setq blk (entnext blk)) (/= (cdr (assoc 0 (setq lArea (entget blk)))) "SEQEND") ) (if (= (cdr (assoc 0 lArea)) "ATTRIB") (progn (setq tagnameArea (cdr (assoc 2 lArea))) (if (= tagnameArea "VALVETAG") (setq valveTag (cdr (assoc 1 lArea))) ) ) ) ) (write-line valveTag xcelfile) ) (close xcelfile) (princ (strcat " Extraction is complete. " fileName " has been created. " ) ) ) ) (princ) )

Re: CODE correction for extract ATTRIBUTE

_Tharwat — Sun, 11 Oct 2020 15:41:22 GMT

@pbejse wrote:

(write-line (strcat "ValveTag") xcelfile)

What's the function STRCAT for? 😉

Re: CODE correction for extract ATTRIBUTE

_Tharwat — Sun, 11 Oct 2020 15:44:24 GMT

Be careful if the ssget function returns nil, then the program will throw an error and keep the file hanging in the sky without closing. 😉

Re: CODE correction for extract ATTRIBUTE

pbejse — Sun, 11 Oct 2020 15:44:30 GMT

@_Tharwat wrote:

What's the function STRCAT for? 😉

Bad case of copy and paste is what 😀

Re: CODE correction for extract ATTRIBUTE

hak_vz — Sun, 11 Oct 2020 16:29:36 GMT

@_Tharwat wrote:
Be careful if the ssget function returns nil, then the program will throw an error and keep the file hanging in the sky without closing. 😉

I know. But since @Anonymous is greasing elbows to learn autolisp I would like him to start testing his code and look for potential potholes. That is best way to learn programing, and we all have gone through this.

Re: CODE correction for extract ATTRIBUTE

pbejse — Sun, 11 Oct 2020 17:01:33 GMT

@hak_vz wrote:

That is best way to learn programing, and we all have gone through this.

Though I agree with you about learning, but that particular error would be a tough one for a beginner to figure out on their own, would you agree?

Cmon @hak_vz , be nice 😉

Bet money the OP restarted CAD about 5 times by now,

Re: CODE correction for extract ATTRIBUTE

hak_vz — Sun, 11 Oct 2020 17:38:39 GMT

@Anonymous

Your code is not bad but you have to start using testing.

Instead using IF statements try to use COND.

With selection sets there is a catch. When you receive selection set always test for its existence and number of elements inside it.

(setq ss (ssget)) (cond ((and ss (> (sslenght ss)0) ...... code goes here ) )

Same principle apply when you use function getfiled to select input/output file through system dialog.

If you hit <esc> during file selection file path string will be nill and code will present an error.

(cond ((and (setq f (getfiled "Output .csv file:" (getvar "dwgprefix") "csv" 3))) ....... ) )

Re: CODE correction for extract ATTRIBUTE

_Tharwat — Sun, 11 Oct 2020 17:49:27 GMT

@hak_vz wrote:
@Anonymous
Your code is not bad but you have to start using testing.
Instead using IF statements try to use COND.
With selection sets there is a catch. When you receive selection set always test for its existence and number of elements inside it.

(setq ss (ssget)) (cond ((and ss (> (sslenght ss)0) ...... code goes here ) )

You don't need to check if the sslength of the selection set is more than one as long as the selection set is not equal to nil.

COND can't be BETTER than IF function nor visa versa because that depends on the situation and sometimes on the experience of the user.

Re: CODE correction for extract ATTRIBUTE

hak_vz — Sun, 11 Oct 2020 18:22:07 GMT

@_Tharwat wrote:
@hak_vz wrote:
@Anonymous

You don't need to check if the sslength of the selection set is more than one as long as the selection set is not equal to nil.

Yes, but if you want to have your code bulletproof you have to add it in your code. Once selection set equals null your code will break.

COND can't be BETTER than IF function nor visa versa because that depends on the situation and sometimes on the experience of the user.

True and false. It is a different story when number of PROGN blocks starts to rise. Cond is than easier to handle.

Re: CODE correction for extract ATTRIBUTE

_Tharwat — Sun, 11 Oct 2020 18:55:27 GMT

@hak_vz wrote:

Yes, but if you want to have your code bulletproof you have to add it in your code. Once selection set equals null your code will break.

You got it the wrong way, and this is what I meant based on YOUR cond way,

(cond (ss ;; this is enough without checking if the length is more than zero.

@hak_vz wrote:
True and false. It is a different story when number of PROGN blocks starts to rise. Cond is than easier to handle.

Also True and False, the number of times you use PROGN is less than the number of statements you might use with COND although that I did not refer to that at all.

Re: CODE correction for extract ATTRIBUTE

Sea-Haven — Mon, 12 Oct 2020 00:11:18 GMT

hak_z and Tharwat My $0.05 when writing code I do

(if (setq ss ....

(progn

hit enter a few times

)

Then go back in and add code that way know IF is balanced. Same with REPEAT.

It is something I should do more often stopping selection errors and admit to that.

Re: CODE correction for extract ATTRIBUTE

Anonymous — Mon, 12 Oct 2020 04:12:31 GMT

I have tried with the selection set by manual way, its has a proper contents successful.

But only thing the loop is getting issue.

Thanks for the suggestion.

Re: CODE correction for extract ATTRIBUTE

Anonymous — Mon, 12 Oct 2020 04:57:22 GMT

1 st Positive response from your code,

Its running and the excel file is creating successfully.

Thanks for this.

Re: CODE correction for extract ATTRIBUTE

_Tharwat — Mon, 12 Oct 2020 07:01:58 GMT

@Anonymous wrote:
1 st Positive response from your code,
Its running and the excel file is creating successfully.
Thanks for this.

You're welcome anytime.