topic Re: Error: malformed list on input in Visual LISP, AutoLISP and General Customization Forum

Error: malformed list on input

paulo.barreraF8J36 — Thu, 02 Feb 2023 00:29:50 GMT

Hello Everyone,

I am currently trying to create a .lisp program that automates the editing of attributes in a dynamic block. I have written the code and uploaded it to AutoCAD but am getting the error : malformed list on input. This shows up above the command line after I load it in the load/unload applications tab.

The code works by taking a csv file and separating the entries by columns. The csv file has 5 columns: Block, ID, ID_value, Attribute, Attribute_Value.

This is my first time working on AutoLISP so really anything could be wrong.

Thank you so much for your time and help.

Here is my code, I will also upload the file below:

(defun c:replaceAttributes (filePath)
(if (setq fp (open filePath "r"))
(progn
(while (setq line (read-line fp))
(if (> (length line) 0)
(progn
(setq values (mapcar 'atoi (strsplit line ",")))
(setq blockName (nth 0 values))
(setq attribName (nth 1 values))
(setq newValue (nth 2 values))
(if (setq b (ssget (list (cons 0 "INSERT") (cons 2 blockName))))
(progn
(foreach b (entget b)
(if (and (equal (cdr (assoc 2 b)) blockName) (equal (cdr (assoc 70 b)) 1))
(progn
(if (setq a (ssget (list (cons 0 "ATTRIB") (cons 8 b) (list (cons 2 attribName)))))
(progn
(setq attribs (entget a))
(if (setq index (assoc 2 attribName attribs))
(progn
(setq newAttribs (subst (cons 2 newValue) index attribs))
(entmod newAttribs)
)
)
)
)
)
)
)
)
)
)
)
(close fp)
(alert "Attributes replaced.")
)
(alert (strcat "File " filePath " not found."))
)
)

Re: Error: malformed list on input

paullimapa — Thu, 02 Feb 2023 02:44:28 GMT

you missed a closing parenthesis at the end

; https://forums.autodesk.com/t5/visual-lisp-autolisp-and-general/error-malformed-list-on-input/m-p/11722945#M443041 (defun c:replaceAttributes (filePath) (if (setq fp (open filePath "r")) (progn (while (setq line (read-line fp)) (if (> (length line) 0) (progn (setq values (mapcar 'atoi (strsplit line ","))) (setq blockName (nth 0 values)) (setq attribName (nth 1 values)) (setq newValue (nth 2 values)) (if (setq b (ssget (list (cons 0 "INSERT") (cons 2 blockName)))) (progn (foreach b (entget b) (if (and (equal (cdr (assoc 2 b)) blockName) (equal (cdr (assoc 70 b)) 1)) (progn (if (setq a (ssget (list (cons 0 "ATTRIB") (cons 8 b) (list (cons 2 attribName))))) (progn (setq attribs (entget a)) (if (setq index (assoc 2 attribName attribs)) (progn (setq newAttribs (subst (cons 2 newValue) index attribs)) (entmod newAttribs) ) ; progn ) ; if ); progn ) ; if ) ; progn ) ; if ) ; foreach ) ; progn ) ; if ) ; progn ) ; if (close fp) (alert "Attributes replaced.") ) ; while (alert (strcat "File " filePath " not found.")) ) ; progn ) ; if ) ; defun

Re: Error: malformed list on input

pbejse — Thu, 02 Feb 2023 07:34:04 GMT

@paulo.barreraF8J36 wrote:

..

This is my first time working on AutoLISP so really anything could be wrong.

...

There's a couple of things you need to fix on top of the 'malformed list input' error, to name a few

(> (length line) 0)  should be (> (strlen line) 0)

line variable's vale would be a string, the length function accepts a list type rather than a string

(strsplit line ",") <--- pretty sure this is splitting the value of line variable to a list of string
(mapcar 'atoi (strsplit line ",")) <-- then you convert all items to an integer

By doing that, Block column would come out as 0 if the value is a string ( block name i assumed )

This is what you probably get if the items omn the list happens to be a mix of Numbers and Letters ( 0 0 0 0 0)

(setq b (ssget (list (cons 0 "INSERT") (cons 2 blockName)))) 
and
(entget b) <---- should be  (entget (ssname b 0))

As variable b is a selection set, you need to iterate thru the selection using an index , look into ssname

(foreach b (entget b)
(and (equal (cdr (assoc 2 b)) blockName)
			  (equal (cdr (assoc 70 b)) 1)
		     )

The above will note work at all, during foreach,you have only have access at one item at a time, since the result from entget is an entity's definition data similar to this

(-1 . <Entity name: 223b08e0dd0>) (0 . "INSERT") (67 . 1) (410 . "JUB-PH1-CLL-LD-DWG-31001") (8 . "0") (2 . "CLL_Revison Description") (10 0.0 0.0 0.0) (70 . 0) (71 . 0)

You cant have DXF 2 and 70 at the same run, besides ou should not use b as a variable for foreach, as that is already defined as the selection set.

Post a sample of the csv or perhaps a drawing so we could guide you and let you finish your code.

Re: Error: malformed list on input

paulo.barreraF8J36 — Thu, 02 Feb 2023 18:03:15 GMT

Thank you so much!

Re: Error: malformed list on input

paulo.barreraF8J36 — Thu, 02 Feb 2023 18:04:11 GMT

This is my sample csv. How must I change it to work?

Thank you for your help!

Re: Error: malformed list on input

paulo.barreraF8J36 — Thu, 02 Feb 2023 18:47:50 GMT

I have gotten it to load, but when I run the command c:replaceAttributes it is saying unknown command.

What would the reason be that it is not allowing me to use the command?

I have uploaded it to the startup suite as well as loaded it on the appload page. I also have the .lisp in an autocad supported folder specifically c:/program files/autodesk/Autocad 2023/Support

Re: Error: malformed list on input

Kent1Cooper — Thu, 02 Feb 2023 19:24:29 GMT

@paulo.barreraF8J36 wrote:

.... when I run the command c:replaceAttributes it is saying unknown command. ....

Don't include the c: -- that's not part of the command name.

Re: Error: malformed list on input

paulo.barreraF8J36 — Thu, 02 Feb 2023 20:04:36 GMT

Yes I figured that out quickly. The issue now is that it is saying I don't have enough arguments, but the way I changed the script should prompt for a file path:

(defun c:replaceAttributes ()
(setq filePath (open (strcat "Select Attribute Data CSV file: ")))
(if (not filePath) (exit))
(setq fileData (readFile filePath))

It doesn't do this, and I am not sure why

Re: Error: malformed list on input

pbejse — Fri, 03 Feb 2023 05:35:45 GMT

Thank you for posting the csv, if you don't mind also sharing the following items

Drawing file with target blocks listed on the csv
strsplit function
readFile function

Re: Error: malformed list on input

Kent1Cooper — Fri, 03 Feb 2023 12:34:55 GMT

@paulo.barreraF8J36 wrote:

... it is saying I don't have enough arguments, but the way I changed the script should prompt for a file path:

(defun c:replaceAttributes ()
(setq filePath (open (strcat "Select Attribute Data CSV file: ")))
....

Should your (strcat) function be (getstring) instead, so that it will prompt you? If so, investigate the (getfiled) function, in which you can navigate to the file you want and select it, rather than type in the entire path and file name.

Re: Error: malformed list on input

paulo.barreraF8J36 — Fri, 03 Feb 2023 18:25:10 GMT

Getstring worked to ask for the location of the file, now I just need to figure out how to get my command to run and do what I want it to do

Re: Error: malformed list on input

paulo.barreraF8J36 — Fri, 03 Feb 2023 18:31:53 GMT

Here is the drawing of the block.

Also aren't the other two functions you asked for just default functions in lisp?

I have also managed to get the code to ask for the file path but it does not complete the task I want it to. Here is the updated code:

(defun c:replaceAttributes ()
(setq filePath (open (getstring "Select Attribute Data CSV file: ")))
(if (not filePath) (exit))
(setq fileData (readFile filePath))
(progn
(while (setq line (read-line fp))
(if (> (length line) 0)
(progn
(setq values (mapcar 'atoi (strsplit line ",")))
(setq blockName (nth 0 values))
(setq attribName (nth 1 values))
(setq newValue (nth 2 values))
(if (setq b (ssget (list (cons 0 "INSERT") (cons 2 blockName))))
(progn
(foreach b (entget b)
(if (and (equal (cdr (assoc 2 b)) blockName) (equal (cdr (assoc 70 b)) 1))
(progn
(if (setq a (ssget (list (cons 0 "ATTRIB") (cons 8 b) (list (cons 2 attribName)))))
(progn
(setq attribs (entget a))
(if (setq index (assoc 2 attribName attribs))
(progn
(setq newAttribs (subst (cons 2 newValue) index attribs))
(entmod newAttribs)
)
)
)
)
)
)
)
)
)
)
)
(close fp)
(alert "Attributes replaced.")
)
(alert (strcat "File " filePath " not found."))
)
)

Re: Error: malformed list on input

Kent1Cooper — Fri, 03 Feb 2023 18:37:02 GMT

@paulo.barreraF8J36 wrote:

....

(setq filePath (open (getstring "Select Attribute Data CSV file: ")))
....

Read in the AutoLisp Reference about the (open) function, and what arguments you need to give it.

And answer the request for function definitions in Message 9.

Re: Error: malformed list on input

paulo.barreraF8J36 — Fri, 03 Feb 2023 19:30:33 GMT

Are those functions not already defined in lisp? This is my first project in lisp so I am unfamiliar with what functions are built in (if any) and what the request for me to send in those functions really meant.

Is there any way that I could hop on a zoom call with one of you since it may be easier to debug in real time then sending messages back and forth?

Re: Error: malformed list on input

Kent1Cooper — Fri, 03 Feb 2023 21:00:31 GMT

See the AutoLisp Functions Reference for the defined functions. No (readFile) or (strsplit). [There are some undocumented functions, but these are not among them, or we wouldn't get those pesky "; error: no function definition:" messages.] Somewhere do you have something that includes (defun readFile and/or (defun strsplit in it?

Re: Error: malformed list on input

paulo.barreraF8J36 — Fri, 03 Feb 2023 22:07:36 GMT

No I do not, the place that I call it is here:

(defun c:replaceAttributes ()
(setq filePath (open (getstring "Select Attribute Data CSV file: ") "r"))
(if (not filePath) (exit))
(setq fileData (readFile filePath))
(progn
(while (setq line (read-line fp))
(if (> (length line) 0)
(progn
(setq values (mapcar 'atoi (strsplit line ",")))
(setq blockName (nth 0 values))
(setq attribName (nth 1 values))
(setq newValue (nth 2 values))

So there is no place that I define them as a function. I will look over that documentation.

Re: Error: malformed list on input

pbejse — Sat, 04 Feb 2023 04:03:39 GMT

@paulo.barreraF8J36 wrote:

Here is the drawing of the block.

Also aren't the other two functions you asked for just default functions in lisp?

..

First of all, you choose not to follow the items i pointed out at post # 3 ( strlen, ssname, etc.).

As pointed out at post # 15, those are not defined Lisp functions in AutoCAD.

Let's analyze the csv and lisp code you posted.

Block			| ID 		| ID_value		| Attribute	| Attribute_Value.
--------------------------------------------------------------------------------------------------
DENSITY_OA1-SENSOR_FOV	| SENSOR_ID	| TIAA-NY-F06-OAS001	| SERIAL_NUMBER	| D2FRG089

(defun c:replaceAttributes ( / filePath ) (defun strsplit ( str d_ ) (while ; (setq filePath (open (getstring "Select Attribute Data CSV file: "))) (if (setq filePath (getfiled "Select Attribute Data CSV file" (getvar 'dwgprefix) " csv" 16)) ; (setq fileData (readFile filePath)) (progn (setq fp (open filePath "r")) (while (setq line (read-line fp)) ; (> (length line) 0) (if (and (> (strlen line) 0) ; (progn ; (setq values (mapcar 'atoi (strsplit line ","))) (setq values (strsplit line ",")) ; function still not posted (setq blockName (nth 0 values)) (setq attribName (nth 1 values)) (setq newValue (nth 2 values)) ; (if (setq b (ssget (list (cons 0 "INSERT") (cons 2 blockName)))) ....

Let's stop right there for now, if we use the sample CSV that you provided at post # 5, this is what you get as the first line (provided the function strsplit spits out 5 items)

("DENSITY_OA1-SENSOR_FOV" "SENSOR_ID" "TIAA-NY-F06-OAS001" "SERIAL_NUMBER" "D2FRG089")

(nth 0) blockName variable would be "DENSITY_OA1-SENSOR_FOV" | Block
(nth 1) attribName is "SENSOR_ID" | ID
(nth 2) newValue as "TIAA-NY-F06-OAS001" | ID_value

What about columns Attribute and Attribute_Value? this is for "SERIAL_NUMBER" tag.

The program prompts the user to select the target block on screen, if there's only one block name on the csv and the user know the block name beforehand then they can select it visually, nowhere in the code shows the name of the block for the user to identify which block object to select. and if that is the case and there are multiple blocks on screen, the which value goes to what block object?

Are you wanting to assign the ID_value based on an existing Attribute_value or vice versa automagically?

That is why its important to show the intent on a sample drawing, what you posted is a drawing that includes the block reference "DENSITY_OA1-SENSOR_FOV" but not the result you wanted. That sample will clear up any other question. And honestly the program is fairly easy, In fact its so easy, most of forum members here can replicate the two missing functions.

Help us help you @paulo.barreraF8J36

Re: Error: malformed list on input

Sea-Haven — Sat, 04 Feb 2023 07:00:55 GMT

(setq filePath (open (getstring "Select Attribute Data CSV file: ") "r")) also as suggested use Getfile this is to easy to just type the wrong answer then the code will not work.

Getfile supports look for csv as file type and where to start looking for the file.

Re: Error: malformed list on input

Kent1Cooper — Sat, 04 Feb 2023 14:14:12 GMT

@Sea-Haven wrote:

... as suggested use Getfile ... easy to just type the wrong answer ....

[My suggestion in Message 10 was to use the (getfiled) AutoLisp function. The d is for dialog box.]

Re: Error: malformed list on input

paulo.barreraF8J36 — Mon, 06 Feb 2023 18:37:25 GMT

So the way I intended it to be written was that it would automatically change the attribute value of the block based on the ID. I will supply my test file below.

Because all the blocks are the same the differentiating value is the ID, so the idea is to insert a specific attribute value or serial number for a specific ID as seen on the CSV.

I am sorry for not being extremely helpful in my explanation, I was a bit confused with what you were asking. Thank you for you assistance, it is much appreciated.