topic Re: Combine 2 Lisps with Yes/No and Add More Functionality in Visual LISP, AutoLISP and General Customization Forum

Combine 2 Lisps with Yes/No and Add More Functionality

IanYeager — Thu, 18 May 2023 16:44:11 GMT

Hello Everyone.

Could I please ask for some assistance? I am dangerous with LISP and I have tried using AI to do this but is seems AI does not have a lot of "I" quite yet.

I came across these 2 lisps here that are close to accomplishing my goal for Single Line HVAC duct (or whatever anyone else may find use for).

PLF2 draws a polyline and fillets the corners upon completion.

OBSTW offsets a polyline on both sides.

I would like to combine the 2 lisps and add the following:

I would like the lisp to ask "Insulate Full Y/N".

If yes, Offset the drawn polyline (250 as default) with polylines (Hidden linetype, Color 12, Width 0).

If no, ask "Insulate Part Y/N".

If yes, "pick 2 points" along the polyline and Offset the drawn polyline (250 as default) with polylines (Hidden linetype, Color 12, Width 0) and close the points.

If no, the original polyline is drawn and the command exits.

Hopefully this will be useful to others.

Thanks to @Kent1Cooper for OBSTW and the writer of PLF. You are all a big help to many.

Lisps and image of goal attached.

Re: Combine 2 Lisps with Yes/No and Add More Functionality

Sea-Haven — Fri, 19 May 2023 05:44:03 GMT

You need a 3rd program.

PLF2 draws a polyline and fillets the corners upon completion.

OBSTW offsets a polyline on both sides.

OBSTWP offsets a polyline on both sides for partial length of a pline

I would combine all 3 into one lisp start with PLF2, when finished ask full or partial offset then run correct defun. (OBSTW) or (OBSTWP).

Re partial offset just thinking offset full length then trim off ends and join the 2 ends.

Re: Combine 2 Lisps with Yes/No and Add More Functionality

komondormrex — Thu, 25 May 2023 14:45:51 GMT

hello,

check the code below. 'hidden' linetype should be loaded in document.

Re: Combine 2 Lisps with Yes/No and Add More Functionality

IanYeager — Tue, 23 May 2023 21:49:50 GMT

Thanks @komondormrex After I draw a polyline, I run set_insulator and and get the error:

Command: SET_INSULATOR
Pick target pline: ; error: bad argument type: numberp: nil

I am picking a polyline drawn with the PLF2 lisp which does radius the corners.

Re: Combine 2 Lisps with Yes/No and Add More Functionality

komondormrex — Wed, 24 May 2023 03:10:40 GMT

hi,

to check what is wrong attach target dwg.

Re: Combine 2 Lisps with Yes/No and Add More Functionality

komondormrex — Wed, 24 May 2023 08:53:33 GMT

oops, got it, no need for sample. check updated at #3. note if a starting point for insulator is not selected, whole pline will be insulated.

Re: Combine 2 Lisps with Yes/No and Add More Functionality

IanYeager — Wed, 24 May 2023 16:04:32 GMT

Thanks @komondormrex this is looking pretty good. Thank you! I have tweaked it a bit to keep the offset at a constant 125 rather than prompt for a value (on my local version). I do see one issue where the offset of a portion does not work if the ends of the polyline are not visible in your screen. The response is shown in the image attached. Possible to fix that? Thank you.

Re: Combine 2 Lisps with Yes/No and Add More Functionality

Sea-Haven — Thu, 25 May 2023 02:41:05 GMT

This is a partial offset picking 2 points along a pline etc. It has offset set to 250, would be best to have a enter offset.

; Offset both sides of pline between picked points. ; OBSTWP BY AlanH May 2023 (defun c:OBSTWP ( / alg-ang pt1 pt2 pt1a pt1b pt2 pt2a pt2b obj obj2 obj3 ang ent oldsnap ent2 ent3 l1 l2) (defun alg-ang (objpl pnt) (angle '(0. 0. 0.) (vlax-curve-getfirstderiv objpl (vlax-curve-getparamatpoint objpl pnt ) ) ) ) (setq oldsnap (getvar 'osmode)) (setvar 'osmode 512) (setq ent (entsel "Pick 1st point on pline ")) (setq obj (vlax-ename->vla-object (car ent ))) (setq pt1 (cadr ent)) (setq pt1 (vlax-curve-getclosestpointto obj pt1)) (setq pt2 (getpoint "\nPick 2nd point on pline ")) (setq pt2 (vlax-curve-getclosestpointto obj pt2)) (vla-offset obj 250) (setq ent2 (entlast)) (setq obj2 (vlax-ename->vla-object ent2)) (vla-offset obj -250) ; (setq ent3 (entlast)) (setq obj3 (vlax-ename->vla-object ent3)) (setq ang (+ (/ pi 2)(alg-ang obj pt1))) (setq pt1a (polar pt1 ang 250)) (setq pt1b (polar pt1 (+ ang pi) 250)) (command "line" pt1a pt1b "") (setq l1 (entlast)) (command "trim" (entlast) "" (vlax-curve-getstartPoint obj2) (vlax-curve-getstartPoint obj3) "") (setq ang (+ (/ pi 2)(alg-ang obj pt2))) (setq pt2a (polar pt2 ang 250)) (setq pt2b (polar pt2 (+ ang pi) 250)) (command "line" pt2a pt2b "") (setq l2 (entlast)) (command "trim" (entlast) "" (vlax-curve-getendPoint obj2) (vlax-curve-getendPoint obj3) "") (command "pedit" "join" ent2 l1 ent3 l2 "") (setvar 'osmode oldsnap) (princ) )

Re: Combine 2 Lisps with Yes/No and Add More Functionality

IanYeager — Thu, 25 May 2023 14:12:31 GMT

@Sea-Haven This routine is asking for 2 points to be picked but it is offsetting the entire pline and not closing the ends, unless I am doing something wrong?

Re: Combine 2 Lisps with Yes/No and Add More Functionality

Sea-Haven — Sat, 27 May 2023 03:41:31 GMT

Did you pick the ends it will do all the pline then, if you want a distance from ends that will need to be added.

Pick in from ends when asked.

Re: Combine 2 Lisps with Yes/No and Add More Functionality

komondormrex — Tue, 30 May 2023 14:49:49 GMT

check the following.

;******************************************************************************************************************************************************************** (defun set_insulator_properties (object) (vla-put-linetype object "HIDDEN") (vl-catch-all-apply 'vla-put-constantwidth (list object 0)) (vla-put-color object 12) ) ;******************************************************************************************************************************************************************** (defun draw_insulator_borders (point target_pline one_side_offset) (setq 1st_derivative (vlax-curve-getfirstderiv target_pline (vlax-curve-getparamatpoint target_pline (trans point 1 0))) 1st_derivative_angle (angle (trans '(0 0 0) 0 1) (trans 1st_derivative 0 1)) ) (vla-addline (vla-get-block (vla-get-activelayout (vla-get-activedocument (vlax-get-acad-object)))) (vlax-3d-point (polar (trans point 1 0) (+ 1st_derivative_angle (* 0.5 pi)) one_side_offset)) (vlax-3d-point (polar (trans point 1 0) (- 1st_derivative_angle (* 0.5 pi)) one_side_offset)) ) ) ;******************************************************************************************************************************************************************** (defun c:set_insulator (/ target_pline init start_insulation_point end_insulation_point offset_pline_1 offset_pline_2 start_point_parameter end_point_parameter border_1_line border_2_line offset_pline_1_1 offset_pline_1_2 offset_pline_2_1 offset_pline_2_2 skip one_side_offset_saved ) (vla-startundomark (vla-get-activedocument (vlax-get-acad-object))) (if (null one_side_offset) (setq one_side_offset 125)) (setq target_pline (vlax-ename->vla-object (car (entsel "\nPick target pline: "))) one_side_offset_saved one_side_offset init (initget 6) one_side_offset (getreal (strcat "\nEnter one side offset (Space to confirm) <" (rtos one_side_offset) ">: ")) start_insulation_point (getpoint "\nPick start insulation point on target pline (Space to insulate whole pline): ") offset_pline_1 (vlax-vla-object->ename (car (vlax-invoke target_pline 'offset (if (null one_side_offset) (setq one_side_offset one_side_offset_saved))))) offset_pline_2 (vlax-vla-object->ename (car (vlax-invoke target_pline 'offset (* -1.0 one_side_offset)))) ) (set_insulator_properties (vlax-ename->vla-object offset_pline_1)) (set_insulator_properties (vlax-ename->vla-object offset_pline_2)) (if (and start_insulation_point (setq start_point_parameter (vlax-curve-getparamatpoint target_pline (trans start_insulation_point 1 0))) (setq border_1_line (draw_insulator_borders start_insulation_point target_pline one_side_offset)) ) (progn (setq end_insulation_point (getpoint "\nPick end insulation point on target pline: ") end_point_parameter (vlax-curve-getparamatpoint target_pline (trans end_insulation_point 1 0)) border_2_line (draw_insulator_borders end_insulation_point target_pline one_side_offset) ) (set_insulator_properties border_1_line) (set_insulator_properties border_2_line) (setq skip nil) (if (and (/= start_point_parameter (vlax-curve-getstartparam target_pline)) (/= start_point_parameter (vlax-curve-getendparam target_pline)) ) (progn (command "_breakatpoint" offset_pline_1 (trans start_insulation_point 0 1)) (if (> start_point_parameter end_point_parameter) (setq offset_pline_1_1 (entlast)) (setq offset_pline_1_1 offset_pline_1 offset_pline_1 (entlast)) ) ) (setq skip t) ) (if (and (/= end_point_parameter (vlax-curve-getstartparam target_pline)) (/= end_point_parameter (vlax-curve-getendparam target_pline)) ) (progn (command "_breakatpoint" (if skip offset_pline_1 (if (> start_point_parameter end_point_parameter) offset_pline_1 (entlast) ) ) (trans end_insulation_point 0 1) ) (if (> start_point_parameter end_point_parameter) (setq offset_pline_1_2 offset_pline_1 offset_pline_1 (entlast)) (setq offset_pline_1_2 (entlast)) ) ) ) (setq skip nil) (if (and (/= start_point_parameter (vlax-curve-getstartparam target_pline)) (/= start_point_parameter (vlax-curve-getendparam target_pline)) ) (progn (command "_breakatpoint" offset_pline_2 (trans start_insulation_point 0 1)) (if (> start_point_parameter end_point_parameter) (setq offset_pline_2_1 (entlast)) (setq offset_pline_2_1 offset_pline_2 offset_pline_2 (entlast)) ) ) (setq skip t) ) (if (and (/= end_point_parameter (vlax-curve-getstartparam target_pline)) (/= end_point_parameter (vlax-curve-getendparam target_pline)) ) (progn (command "_breakatpoint" (if skip offset_pline_2 (if (> start_point_parameter end_point_parameter) offset_pline_2 (entlast) ) ) (trans end_insulation_point 0 1) ) (if (> start_point_parameter end_point_parameter) (setq offset_pline_2_2 offset_pline_2 offset_pline_2 (entlast)) (setq offset_pline_2_2 (entlast)) ) ) ) (if offset_pline_1_1 (vla-erase (vlax-ename->vla-object offset_pline_1_1))) (if offset_pline_1_2 (vla-erase (vlax-ename->vla-object offset_pline_1_2))) (if offset_pline_2_1 (vla-erase (vlax-ename->vla-object offset_pline_2_1))) (if offset_pline_2_2 (vla-erase (vlax-ename->vla-object offset_pline_2_2))) (command "_pedit" offset_pline_1 "_j" (vlax-vla-object->ename border_1_line) offset_pline_2 (vlax-vla-object->ename border_2_line) "" "" ) ) ) (vla-endundomark (vla-get-activedocument (vlax-get-acad-object))) (princ) ) ;********************************************************************************************************************************************************************

Re: Combine 2 Lisps with Yes/No and Add More Functionality

IanYeager — Tue, 30 May 2023 16:27:08 GMT

Thank you very much @komondormrex and @Kent1Cooper for the help and the original code. It's very much appreciated!!!

Re: Combine 2 Lisps with Yes/No and Add More Functionality

smallƑish — Mon, 27 Nov 2023 08:46:47 GMT

You are always a magician with your codes. 😱