topic Re: Do Loop Error in VBA Forum

Do Loop Error

Anonymous — Thu, 13 Jul 2000 12:29:11 GMT

Why do I get a "Compile Error: Loop without Do"?

Option Explicit
'Dim insertionpnt(0 To 2) As Double
'Dim blkscale(0 To 2) As Double
Dim respon As String
'Dim tmpPoint
'Dim BlkName As String
'Public blockrefobj As AcadBlockReference
'Dim intSizeNew As Integer
'Dim scale1 As Double
Dim ss As AcadSelectionSet
Dim atts As Variant
Dim I As Long
Dim j As Long
Dim fType(0 To 1) As Integer
Dim fData(0 To 1) As Variant
'Dim Csize1 As Boolean
'Dim strgroup As String, strtitle1 As String, strtitle2 As String, strprojno
As String, strDwnBy As String
'Dim dtmdatedwn As Date, strDwgNo As String, strDwgScale, strChkBy As
String, strRevision As String, strNextAssy As String, strBillMatl As String
Public intBlocksize As Integer

Sub FormCheck()
Dim dirName As String
Dim tmp As String, acadApp As AcadApplication
dirName = "F:\"
If Right(dirName, 1) <> "\" Then dirName = dirName & "\"
Set acadApp = ThisDrawing.Application
acadApp.Documents.Close
tmp = Dir$(dirName & "*.dwg")

Do While tmp <> ""
Application.Documents.Open dirName & tmp
intBlocksize = ThisDrawing.GetVariable("useri1")
If intBlocksize = 0 Then
On Error Resume Next
Set ss = ThisDrawing.SelectionSets("ss")
If Err Then
Err.Clear
On Error GoTo 0
Set ss = ThisDrawing.SelectionSets.Add("ss")
End If
ss.Clear
fType(0) = 0: fData(0) = "INSERT"
fType(1) = 2: fData(1) = "buffind-*"
ss.Select acSelectionSetAll, , , fType, fData

If ss.Count = 0 Then
' Me.Hide
respon = MsgBox("You must insert a Drawing form First.", vbOKOnly,
"Drawing Form")
' Drawingforminsert.Show
' End
ElseIf ss.Item(0).Name = "buffind-c1 new" Or ss.Item(0).Name =
"BUFFIND-c1 new" Then
' csize = True
' intBlocksize = 2
ThisDrawing.SetVariable "useri1", 2
' BlkName = "buffind-c1 new"
ElseIf ss.Item(0).Name = "buffind-c1" Or ss.Item(0).Name =
"BUFFIND-c1" Then
' csize = True
' intBlocksize = 22
ThisDrawing.SetVariable "useri1", 2
' BlkName = "buffind-c1"
ElseIf ss.Item(0).Name = "buffind-d1 new" Or ss.Item(0).Name
= "BUFFIND-d1 new" Then
' dsize = True
' intBlocksize = 3
ThisDrawing.SetVariable "useri1", 3
' BlkName = "buffind-d1 new"
ElseIf ss.Item(0).Name = "buffind-d1" Or ss.Item(0).Name
= "BUFFIND-d1" Then
' dsize = True
' intBlocksize = 33
ThisDrawing.SetVariable "useri1", 3
' BlkName = "buffind-d1"
ElseIf ss.Item(0).Name = "buffind-b1 new" Or
ss.Item(0).Name = "BUFFIND-b1 new" Then
' bsize = True
' intBlocksize = 1
ThisDrawing.SetVariable "useri1", 1
' BlkName = "buffind-b1 new"
ElseIf ss.Item(0).Name = "buffind-c1" Or
ss.Item(0).Name = "BUFFIND-c1" Then
' bsize = True
' intBlocksize = 11
ThisDrawing.SetVariable "useri1", 1
' BlkName = "buffind-b1"
End If
tmp = Dir$()
Loop
End Sub

Re: Do Loop Error

Anonymous — Thu, 13 Jul 2000 13:05:05 GMT

You were missing an end if statement. I would suggest outdenting all you
control statements. It makes it easier to identify beginning and end of
control logic.

example:
if bla bla bla then
bla bla......
bla bla......
end if

here is the compilable (is that a word).

Option Explicit
'Dim insertionpnt(0 To 2) As Double
'Dim blkscale(0 To 2) As Double
Dim respon As String
'Dim tmpPoint
'Dim BlkName As String
'Public blockrefobj As AcadBlockReference
'Dim intSizeNew As Integer
'Dim scale1 As Double
Dim ss As AcadSelectionSet
Dim atts As Variant
Dim I As Long
Dim j As Long
Dim fType(0 To 1) As Integer
Dim fData(0 To 1) As Variant
'Dim Csize1 As Boolean
'Dim strgroup As String, strtitle1 As String, strtitle2 As String, strprojno
As String, strDwnBy As String
'Dim dtmdatedwn As Date, strDwgNo As String, strDwgScale, strChkBy As
String, strRevision As String, strNextAssy As String, strBillMatl As String
Public intBlocksize As Integer

Sub FormCheck()
Dim dirName As String
Dim tmp As String, acadApp As acadapplication
dirName = "F:\"
If Right(dirName, 1) <> "\" Then dirName = dirName & "\"
Set acadApp = ThisDrawing.Application
acadApp.Documents.Close
tmp = Dir$(dirName & "*.dwg")
Do While tmp <> ""
Application.Documents.Open dirName & tmp
intBlocksize = ThisDrawing.GetVariable("useri1")
If intBlocksize = 0 Then
On Error Resume Next
Set ss = ThisDrawing.SelectionSets("ss")
If Err Then
Err.Clear
On Error GoTo 0
Set ss = ThisDrawing.SelectionSets.Add("ss")
End If
ss.Clear
fType(0) = 0: fData(0) = "INSERT"
fType(1) = 2: fData(1) = "buffind-*"
ss.Select acSelectionSetAll, , , fType, fData

If ss.Count = 0 Then
' Me.Hide
respon = MsgBox("You must insert a Drawing form First.",
vbOKOnly, "Drawing Form")
' Drawingforminsert.Show
' End
ElseIf ss.Item(0).Name = "buffind-c1 new" Or ss.Item(0).Name =
"BUFFIND-c1 new" Then
' csize = True
' intBlocksize = 2
ThisDrawing.SetVariable "useri1", 2
' BlkName = "buffind-c1 new"
ElseIf ss.Item(0).Name = "buffind-c1" Or ss.Item(0).Name =
"BUFFIND-c1" Then
' csize = True
' intBlocksize = 22
ThisDrawing.SetVariable "useri1", 2
' BlkName = "buffind-c1"
ElseIf ss.Item(0).Name = "buffind-d1 new" Or ss.Item(0).Name =
"BUFFIND-d1 new" Then
' dsize = True
' intBlocksize = 3
ThisDrawing.SetVariable "useri1", 3
' BlkName = "buffind-d1 new"
ElseIf ss.Item(0).Name = "buffind-d1" Or ss.Item(0).Name =
"BUFFIND-d1" Then
' dsize = True
' intBlocksize = 33
ThisDrawing.SetVariable "useri1", 3
' BlkName = "buffind-d1"
ElseIf ss.Item(0).Name = "buffind-b1 new" Or ss.Item(0).Name =
"BUFFIND-b1 new" Then
' bsize = True
' intBlocksize = 1
ThisDrawing.SetVariable "useri1", 1
' BlkName = "buffind-b1 new"
ElseIf ss.Item(0).Name = "buffind-c1" Or ss.Item(0).Name =
"BUFFIND-c1" Then
' bsize = True
' intBlocksize = 11
ThisDrawing.SetVariable "useri1", 1
' BlkName = "buffind-b1"
End If
tmp = Dir$()
End If 'this is the missing end if
Loop
End Sub

Regards,

Sergio DeAlbuquerque
President

Matrix Technical Services Inc.
172 N.Bicycle Path
Selden, NY 11784

Ph: 631-736-9001
Fax: 631-696-8538

http://www.matrixengg.com
sdealbuquerq@matrixengg.com
"CAD services, machine design, and VBA application development"

Re: Do Loop Error

Anonymous — Thu, 13 Jul 2000 16:38:39 GMT

Have you considered using a Select Case to replace all those If statements?
Sure would make it easier to read. In addition, rather than repeating all
the same statements in every case, I would recommend you use an itermediate
variable then make your changes outside the Select Case structure:

Select Case x
Case 1
tmp = 5

Case 2, 3
tmp = 10

Case Else
tmp = 15

End Select

ThisDrawing.SetVariable("Whatever", tmp)

--
Attitudes are contagious. Is yours worth catching?
http://www.acadx.com

"David M. Gardner" wrote in message
news:ef2aeab.-1@WebX.SaUCah8kaAW...
> Why do I get a "Compile Error: Loop without Do"?
>
>
> Option Explicit
> 'Dim insertionpnt(0 To 2) As Double
> 'Dim blkscale(0 To 2) As Double
> Dim respon As String
> 'Dim tmpPoint
> 'Dim BlkName As String
> 'Public blockrefobj As AcadBlockReference
> 'Dim intSizeNew As Integer
> 'Dim scale1 As Double
> Dim ss As AcadSelectionSet
> Dim atts As Variant
> Dim I As Long
> Dim j As Long
> Dim fType(0 To 1) As Integer
> Dim fData(0 To 1) As Variant
> 'Dim Csize1 As Boolean
> 'Dim strgroup As String, strtitle1 As String, strtitle2 As String,
strprojno
> As String, strDwnBy As String
> 'Dim dtmdatedwn As Date, strDwgNo As String, strDwgScale, strChkBy As
> String, strRevision As String, strNextAssy As String, strBillMatl As
String
> Public intBlocksize As Integer
>
> Sub FormCheck()
> Dim dirName As String
> Dim tmp As String, acadApp As AcadApplication
> dirName = "F:\"
> If Right(dirName, 1) <> "\" Then dirName = dirName & "\"
> Set acadApp = ThisDrawing.Application
> acadApp.Documents.Close
> tmp = Dir$(dirName & "*.dwg")
>
> Do While tmp <> ""
> Application.Documents.Open dirName & tmp
> intBlocksize = ThisDrawing.GetVariable("useri1")
> If intBlocksize = 0 Then
> On Error Resume Next
> Set ss = ThisDrawing.SelectionSets("ss")
> If Err Then
> Err.Clear
> On Error GoTo 0
> Set ss = ThisDrawing.SelectionSets.Add("ss")
> End If
> ss.Clear
> fType(0) = 0: fData(0) = "INSERT"
> fType(1) = 2: fData(1) = "buffind-*"
> ss.Select acSelectionSetAll, , , fType, fData
>
> If ss.Count = 0 Then
> ' Me.Hide
> respon = MsgBox("You must insert a Drawing form First.", vbOKOnly,
> "Drawing Form")
> ' Drawingforminsert.Show
> ' End
> ElseIf ss.Item(0).Name = "buffind-c1 new" Or ss.Item(0).Name =
> "BUFFIND-c1 new" Then
> ' csize = True
> ' intBlocksize = 2
> ThisDrawing.SetVariable "useri1", 2
> ' BlkName = "buffind-c1 new"
> ElseIf ss.Item(0).Name = "buffind-c1" Or ss.Item(0).Name =
> "BUFFIND-c1" Then
> ' csize = True
> ' intBlocksize = 22
> ThisDrawing.SetVariable "useri1", 2
> ' BlkName = "buffind-c1"
> ElseIf ss.Item(0).Name = "buffind-d1 new" Or
ss.Item(0).Name
> = "BUFFIND-d1 new" Then
> ' dsize = True
> ' intBlocksize = 3
> ThisDrawing.SetVariable "useri1", 3
> ' BlkName = "buffind-d1 new"
> ElseIf ss.Item(0).Name = "buffind-d1" Or
ss.Item(0).Name
> = "BUFFIND-d1" Then
> ' dsize = True
> ' intBlocksize = 33
> ThisDrawing.SetVariable "useri1", 3
> ' BlkName = "buffind-d1"
> ElseIf ss.Item(0).Name = "buffind-b1 new" Or
> ss.Item(0).Name = "BUFFIND-b1 new" Then
> ' bsize = True
> ' intBlocksize = 1
> ThisDrawing.SetVariable "useri1", 1
> ' BlkName = "buffind-b1 new"
> ElseIf ss.Item(0).Name = "buffind-c1" Or
> ss.Item(0).Name = "BUFFIND-c1" Then
> ' bsize = True
> ' intBlocksize = 11
> ThisDrawing.SetVariable "useri1", 1
> ' BlkName = "buffind-b1"
> End If
> tmp = Dir$()
> Loop
> End Sub
>
>

Re: Do Loop Error

Anonymous — Thu, 27 Jul 2000 11:56:31 GMT

Dear David M. Gardner
Check the following code it will help you.
In the code you had written having 2 errore
1. it was closing all drawing includeing the active drawing, so
automatically the VBA editor also goes out of scope
2. all the drawings in the specified path gets loaded one by one. If
the directory is having many drawings then it is difficult to load all
drawings, machine may hang

try the following on your machine, and send me the feedback
SAJJAD
sajjad_mulla@onwardgroup.com

Option Explicit
'Dim insertionpnt(0 To 2) As Double
'Dim blkscale(0 To 2) As Double
Dim respon As String
'Dim tmpPoint
'Dim BlkName As String
'Public blockrefobj As AcadBlockReference
'Dim intSizeNew As Integer
'Dim scale1 As Double
Dim ss As AcadSelectionSet
Dim atts As Variant
Dim I As Long
Dim j As Long
Dim fType(0 To 1) As Integer
Dim fData(0 To 1) As Variant
'Dim Csize1 As Boolean
'Dim strgroup As String, strtitle1 As String, strtitle2 As String, strprojno
As String, strDwnBy As String
'Dim dtmdatedwn As Date, strDwgNo As String, strDwgScale, strChkBy As
String, strRevision As String, strNextAssy As String, strBillMatl As String
Public intBlocksize As Integer

Sub FormCheck()
Dim dirName As String
Dim tmp As String, acadApp As AcadApplication
dirName = "c:\My_project\"
If Right(dirName, 1) <> "\" Then dirName = dirName & "\"
Set acadApp = ThisDrawing.Application
' acadApp.Documents.Close
tmp = Dir(dirName & "*.dwg")
Dim flag As Boolean
flag = False
Do While tmp <> ""
If flag Then
Application.ActiveDocument.Close
End If
Application.Documents.Open dirName & tmp
Dim intBlocksize As Integer
intBlocksize = ThisDrawing.GetVariable("useri1")
If intBlocksize = 0 Then
On Error Resume Next
Set ss = ThisDrawing.SelectionSets("ss")
If Err Then
Err.Clear
On Error GoTo 0
Set ss = ThisDrawing.SelectionSets.Add("ss")
End If
ss.Clear
fType(0) = 0: fData(0) = "INSERT"
fType(1) = 2: fData(1) = "ba-*"
ss.Select acSelectionSetAll, , , fType, fData

If ss.Count = 0 Then
' Me.Hide
respon = MsgBox("You must insert a Drawing form First.", vbOKOnly,
"Drawing Form")
' Drawingforminsert.Show
' End
ElseIf ss.Item(0).Name = "buffind-c1 new" Or ss.Item(0).Name =
"BUFFIND-c1 new" Then
' csize = True
' intBlocksize = 2
ThisDrawing.SetVariable "useri1", 2
' BlkName = "buffind-c1 new"
ElseIf ss.Item(0).Name = "buffind-c1" Or ss.Item(0).Name = "BUFFIND-c1"
Then
' csize = True
' intBlocksize = 22
ThisDrawing.SetVariable "useri1", 2
' BlkName = "buffind-c1"
ElseIf ss.Item(0).Name = "buffind-d1 new" Or ss.Item(0).ObjectName =
"BUFFIND-d1 new" Then
' dsize = True
' intBlocksize = 3
ThisDrawing.SetVariable "useri1", 3
' BlkName = "buffind-d1 new"
ElseIf ss.Item(0).Name = "buffind-d1" Or ss.Item(0).Name = "BUFFIND-d1"
Then
' dsize = True
' intBlocksize = 33
ThisDrawing.SetVariable "useri1", 3
' BlkName = "buffind-d1"
ElseIf ss.Item(0).Name = "buffind-b1 new" Or ss.Item(0).Name =
"BUFFIND-b1 new" Then
' bsize = True
' intBlocksize = 1
ThisDrawing.SetVariable "useri1", 1
' BlkName = "buffind-b1 new"
ElseIf ss.Item(0).Name = "buffind-c1" Or ss.Item(0).Name = "BUFFIND-c1"
Then
' bsize = True
' intBlocksize = 11
ThisDrawing.SetVariable "useri1", 1
' BlkName = "buffind-b1"
End If
tmp = Dir()
End If
flag = True
Loop
End Sub

Re:

Anonymous — Thu, 27 Jul 2000 12:45:11 GMT

I don't not recall what exactly changed but I had and extra if statement
that did not have an end if. I would post my new code but it would be not
do any good as the code changed as I cleaned it up. Thanks for the help
though.

David M. Gardner

"SAJJAD" wrote in message
news:ef2aeab.2@WebX.SaUCah8kaAW...
> Dear David M. Gardner
> Check the following code it will help you.
> In the code you had written having 2 errore
> 1. it was closing all drawing includeing the active drawing, so
> automatically the VBA editor also goes out of scope
> 2. all the drawings in the specified path gets loaded one by one.
If
> the directory is having many drawings then it is difficult to load all
> drawings, machine may hang
>
> try the following on your machine, and send me the feedback
> SAJJAD
> sajjad_mulla@onwardgroup.com
>
> Option Explicit
> 'Dim insertionpnt(0 To 2) As Double
> 'Dim blkscale(0 To 2) As Double
> Dim respon As String
> 'Dim tmpPoint
> 'Dim BlkName As String
> 'Public blockrefobj As AcadBlockReference
> 'Dim intSizeNew As Integer
> 'Dim scale1 As Double
> Dim ss As AcadSelectionSet
> Dim atts As Variant
> Dim I As Long
> Dim j As Long
> Dim fType(0 To 1) As Integer
> Dim fData(0 To 1) As Variant
> 'Dim Csize1 As Boolean
> 'Dim strgroup As String, strtitle1 As String, strtitle2 As String,
strprojno
> As String, strDwnBy As String
> 'Dim dtmdatedwn As Date, strDwgNo As String, strDwgScale, strChkBy As
> String, strRevision As String, strNextAssy As String, strBillMatl As
String
> Public intBlocksize As Integer
>
> Sub FormCheck()
> Dim dirName As String
> Dim tmp As String, acadApp As AcadApplication
> dirName = "c:\My_project\"
> If Right(dirName, 1) <> "\" Then dirName = dirName & "\"
> Set acadApp = ThisDrawing.Application
> ' acadApp.Documents.Close
> tmp = Dir(dirName & "*.dwg")
> Dim flag As Boolean
> flag = False
> Do While tmp <> ""
> If flag Then
> Application.ActiveDocument.Close
> End If
> Application.Documents.Open dirName & tmp
> Dim intBlocksize As Integer
> intBlocksize = ThisDrawing.GetVariable("useri1")
> If intBlocksize = 0 Then
> On Error Resume Next
> Set ss = ThisDrawing.SelectionSets("ss")
> If Err Then
> Err.Clear
> On Error GoTo 0
> Set ss = ThisDrawing.SelectionSets.Add("ss")
> End If
> ss.Clear
> fType(0) = 0: fData(0) = "INSERT"
> fType(1) = 2: fData(1) = "ba-*"
> ss.Select acSelectionSetAll, , , fType, fData
>
> If ss.Count = 0 Then
> ' Me.Hide
> respon = MsgBox("You must insert a Drawing form First.", vbOKOnly,
> "Drawing Form")
> ' Drawingforminsert.Show
> ' End
> ElseIf ss.Item(0).Name = "buffind-c1 new" Or ss.Item(0).Name =
> "BUFFIND-c1 new" Then
> ' csize = True
> ' intBlocksize = 2
> ThisDrawing.SetVariable "useri1", 2
> ' BlkName = "buffind-c1 new"
> ElseIf ss.Item(0).Name = "buffind-c1" Or ss.Item(0).Name =
"BUFFIND-c1"
> Then
> ' csize = True
> ' intBlocksize = 22
> ThisDrawing.SetVariable "useri1", 2
> ' BlkName = "buffind-c1"
> ElseIf ss.Item(0).Name = "buffind-d1 new" Or ss.Item(0).ObjectName =
> "BUFFIND-d1 new" Then
> ' dsize = True
> ' intBlocksize = 3
> ThisDrawing.SetVariable "useri1", 3
> ' BlkName = "buffind-d1 new"
> ElseIf ss.Item(0).Name = "buffind-d1" Or ss.Item(0).Name =
"BUFFIND-d1"
> Then
> ' dsize = True
> ' intBlocksize = 33
> ThisDrawing.SetVariable "useri1", 3
> ' BlkName = "buffind-d1"
> ElseIf ss.Item(0).Name = "buffind-b1 new" Or ss.Item(0).Name =
> "BUFFIND-b1 new" Then
> ' bsize = True
> ' intBlocksize = 1
> ThisDrawing.SetVariable "useri1", 1
> ' BlkName = "buffind-b1 new"
> ElseIf ss.Item(0).Name = "buffind-c1" Or ss.Item(0).Name =
"BUFFIND-c1"
> Then
> ' bsize = True
> ' intBlocksize = 11
> ThisDrawing.SetVariable "useri1", 1
> ' BlkName = "buffind-b1"
> End If
> tmp = Dir()
> End If
> flag = True
> Loop
> End Sub
>