topic Re: For next slow why? in VBA Forum

For next slow why?

Anonymous — Sat, 22 Dec 2012 18:28:26 GMT

Why is the for next so slow?

I have a form with combobox filled up with 40 layers. The layers are from the layermanager.

The form has a command button too.

When I run this code. It's very slow to lock all layers.

Is there a solution for that?

Private Sub CommandButton1_Click()
On Error Resume Next    'handle exceptions inline
Dim objlayer As AcadLayer

'make the layer selected in the combobox current
ThisDrawing.ActiveLayer = ThisDrawing.Layers.Item(ComboBox1.Text)
For Each objlayer In ThisDrawing.Layers
    objlayer.LayerOn = False    'turn off all the layers
Next objlayer
Set objlayer = ThisDrawing.Layers.Item(ComboBox1.Text)
If objlayer Is Nothing Then
    MsgBox "layer does not exist"
    Exit Sub    'exit if layer not found
End If

objlayer.LayerOn = True 'turn on the desired layer
End Sub

Private Sub UserForm_Initialize()
 Dim layerColl As AcadLayers
 Dim objlayer As AcadLayer


  'fill combobox
 Set layerColl = ThisDrawing.Layers
 For Each objlayer In layerColl
    ComboBox1.AddItem objlayer.Name
 Next
 End Sub

gr. Laszlo

Re: For next slow why?

Hallex — Mon, 24 Dec 2012 22:03:23 GMT

I repeat again, definelayer collection once then iterate through it, eg.: Option Explicit Private Sub CommandButton1_Click() On Error Resume Next 'handle exceptions inline Dim objlayers As AcadLayers Dim objlayer As AcadLayer Set objlayers = ThisDrawing.Layers 'make the layer selected in the combobox current ThisDrawing.ActiveLayer = objlayers.Item(ComboBox1.Text) For Each objlayer In objlayers objlayer.LayerOn = False 'turn off all the layers Next objlayer Set objlayer = objlayers.Item(ComboBox1.Text) If objlayer Is Nothing Then MsgBox "layer does not exist" Exit Sub 'exit if layer not found End If objlayer.LayerOn = True 'turn on the desired layer MsgBox "Done" End Sub Private Sub UserForm_Initialize() Dim layerColl As AcadLayers Dim objlayer As AcadLayer 'fill combobox Set layerColl = ThisDrawing.Layers For Each objlayer In layerColl ComboBox1.AddItem objlayer.Name Next End Sub

Re: For next slow why?

Anonymous — Tue, 25 Dec 2012 07:28:08 GMT

Thank you Hallex for patient.

Its still slow but maybe an other way than you mean.

The problem is the for...next:

For Each objlayer In objlayers
objlayer.Lock = True 'lock all the layers
Next objlayer.

I have 40 layers.

Maybe I have to use the sendcommand method for that?

ps. I changed "turn off" in "lock = true" too

Have a nice christmas!

Option Explicit
Private Sub CommandButton1_Click()

On Error Resume Next 'handle exceptions inline
Dim objlayers As AcadLayers
Dim objlayer As AcadLayer
Set objlayers = ThisDrawing.Layers 'make the layer selected in the combobox current
ThisDrawing.ActiveLayer = objlayers.Item(ComboBox1.Text)
For Each objlayer In objlayers
objlayer.Lock = True 'lock all the layers
Next objlayer
Set objlayer = objlayers.Item(ComboBox1.Text)
If objlayer Is Nothing Then
MsgBox "layer does not exist"
Exit Sub 'exit if layer not found
End If

objlayer.Lock = False 'unlock the desired layer MsgBox "Done"
End Sub

Private Sub UserForm_Initialize()

Dim layerColl As AcadLayers
Dim objlayer As AcadLayer
'fill combobox

Set layerColl = ThisDrawing.Layers

For Each objlayer In layerColl
ComboBox1.AddItem objlayer.Name
Next
End Sub

Re: For next slow why?

Hallex — Tue, 25 Dec 2012 07:51:21 GMT

Hi gr. Laszlo, I tested my code on drawing with about 125 layers for the test seems it's working very fast (something like less then 0.5 second) No problem if your code with SendCommand will do your job though Happy Holydays, ~'J'~

Re: For next slow why?

Alexander.Rivilis — Fri, 28 Dec 2012 10:01:07 GMT

Are you using AutoCAD x64?

64 Bit VBA Performance Issue

Re: For next slow why?

Anonymous — Fri, 28 Dec 2012 20:00:52 GMT

Yes I do.....

???

Re: For next slow why?

Alexander.Rivilis — Fri, 28 Dec 2012 20:24:02 GMT

@Anonymous wrote:

Yes I do.....

???

Then read: http://adndevblog.typepad.com/autocad/2012/05/64-bit-vba-performance-issue.html