topic Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector in Revit API Forum

Revit 2025.4 is crashing if I use results of FilteredElementCollector

sriram_rajagopal07 — Wed, 12 Nov 2025 07:23:30 GMT

When using a Filtered Element Collector to get elements from a linked model, everything works perfectly when the same code is executed through the Add-In Manager.

(view in My Videos)

However, when I run it in debug mode (from Visual Studio) or after installing the add-in normally, Revit throws this error and crashes:

System.AccessViolationException: Attempted to read or write protected memory.

(view in My Videos)

Here’s the core part of the code:

FilteredElementCollector fec = new FilteredElementCollector( doc, choosenView.Id, revitLinkInstance.Id ); List<Element> elmns = new List<Element>( fec.WhereElementIsNotElementType().ToElement() );

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

ricaun — Wed, 12 Nov 2025 15:02:27 GMT

Never used this FilteredElementCollector(Document hostDocument, ElementId viewId, ElementId linkId) and looks like was added in Revit 2024.

https://www.revitapidocs.com/2024/968b52a0-de55-2f96-de40-968812bc41c7.htm

That's fun, I was not able to make work in any version. And is a little strange that works in your Add-In Manager works for some reason...

I tried in Revit 2024 and I have a different exception incited of the AccessViolationException with Revit crash.

Autodesk.Revit.Exceptions.InternalException: A managed exception was thrown by Revit or by one of its external applications.

I create this unit test and always fails, and in Revit 2025+ crash happens...

https://github.com/ricaun-io/RevitTest.FilteredLink.Tests

I wonder what Add-In Manager is doing to make work FilteredElementCollector(Document hostDocument, ElementId viewId, ElementId linkId) work...

Did you test in Revit 2024 with Add-In Manager?

Feels like FilteredElementCollector(Document hostDocument, ElementId viewId, ElementId linkId) was shipped buggy,

Looks like before Revit 2024 user use this:

https://forums.autodesk.com/t5/revit-api-forum/filter-visible-elements-from-linked-revit-model/td-p/11892735

@Mohamed_Arshad did you have some issue with FilteredElementCollector(Document hostDocument, ElementId viewId, ElementId linkId)?

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

ctm_mka — Wed, 12 Nov 2025 20:41:14 GMT

@sriram_rajagopal07 thank you for the videos, they provided much needed clarity from the original post. Looks like then the problem is not necessarily with the fec, but what you are doing with it. So, i would ask, if you debug, and expand the fec, and the results view, do you see all the elements from the linked file? aka is it actually collecting what it should?

@ricaun super weird, i got the simplified version to run while debugging in both 2023 & 2024 (visual studio 2022 if it matters?), here's the code i tried:

_uidoc = commandData.Application.ActiveUIDocument; _doc = _uidoc.Document; _active = _uidoc.ActiveView; ICollection<ElementId> linkedid = new FilteredElementCollector(_doc, _active.Id).OfClass(typeof(RevitLinkInstance)).ToElementIds(); FilteredElementCollector fec = new FilteredElementCollector(_doc, _active.Id, linkedid.First()); List<Element> elems = new List<Element>(fec.WhereElementIsNotElementType().ToList());

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

sriram_rajagopal07 — Thu, 13 Nov 2025 05:53:15 GMT

Finally found the solution for this by using Dispose() method after utilizing the results of FEC

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

ricaun — Thu, 13 Nov 2025 14:27:18 GMT

@ctm_mka wrote:
@ricaun super weird, i got the simplified version to run while debugging in both 2023 & 2024 (visual studio 2022 if it matters?), here's the code i tried:

I'm my code I was not selection the RevitLinkInstance using the ViewId argument, I add that and the issue is gone...

I guess if you remove the "_active.Id" in your sample the exception gonna happen, like:

_uidoc = commandData.Application.ActiveUIDocument; _doc = _uidoc.Document; _active = _uidoc.ActiveView; ICollection<ElementId> linkedid = new FilteredElementCollector(_doc).OfClass(typeof(RevitLinkInstance)).ToElementIds(); FilteredElementCollector fec = new FilteredElementCollector(_doc, _active.Id, linkedid.First()); List<Element> elems = new List<Element>(fec.WhereElementIsNotElementType().ToList());

@sriram_rajagopal07wrote:
Finally found the solution for this by using Dispose() method after utilizing the results of FEC

@sriram_rajagopal07 what you mean by using Dispose? A sample please.

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

vitalij.marcukov2BP2F — Sun, 16 Nov 2025 11:46:06 GMT

Has this been resolved?

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

sriram_rajagopal07 — Tue, 18 Nov 2025 10:11:20 GMT

@ricaun The simple way is to use the FEC in an using statement as below

List<FamilyInstance> createdCaps = new List<FamilyInstance>(); using (FilteredElementCollector fecDucts = new FilteredElementCollector(doc) .OfCategory(BuiltInCategory.OST_DuctCurves) .WhereElementIsNotElementType()) { foreach (Duct duct in fecDucts) { if (duct != null) { FamilySymbol familySymbol = FetchSymbol(doc, duct); if (familySymbol != null) { ConnectorSet openConnectors = duct.ConnectorManager.UnusedConnectors; if (openConnectors.Size >= 1) { FamilyInstance createdCap = DuctEndCapDef(doc, duct, familySymbol); createdCaps.Add(createdCap); } } } } }

And the manual method is as below

List<FamilyInstance> createdCaps = new List<FamilyInstance>(); FilteredElementCollector fecDucts = new FilteredElementCollector(doc) .OfCategory(BuiltInCategory.OST_DuctCurves) .WhereElementIsNotElementType(); try { foreach (Duct duct in fecDucts) { if (duct != null) { FamilySymbol familySymbol = FetchSymbol(doc, duct); if (familySymbol != null) { ConnectorSet openConnectors = duct.ConnectorManager.UnusedConnectors; if (openConnectors.Size >= 1) { FamilyInstance createdCap = DuctEndCapDef(doc, duct, familySymbol); createdCaps.Add(createdCap); } } } } } finally { fecDucts.Dispose();

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

sriram_rajagopal07 — Tue, 18 Nov 2025 10:10:53 GMT

Yes @vitalij.marcukov2BP2F

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

ricaun — Tue, 18 Nov 2025 14:30:35 GMT

@sriram_rajagopal07 wrote:
@ricaun The simple way is to use the FEC in an using statement as below

What your sample have to do with the FilteredElementCollector(Document hostDocument, ElementId viewId, ElementId linkId) problem, you just added Dispose in some random FEC code.

The only workaround I found is call FilteredElementCollector(Document hostDocument, ElementId viewId) before FilteredElementCollector(Document hostDocument, ElementId viewId, ElementId linkId) and the issue is gone.

public IList<Element> GetElementInViewLink(Document document, View view, RevitLinkInstance revitLinkInstance) { // This `FilteredElementCollector` is created to make the exception not happening when using viewId and linkId. A filter is required to be added. new FilteredElementCollector(document, view.Id) .WhereElementIsNotElementType(); return new FilteredElementCollector(document, view.Id, revitLinkInstance.Id) .WhereElementIsNotElementType() .ToElements(); }

That was the only way I was able to fix the issue in my test project:

https://github.com/ricaun-io/RevitTest.FilteredLink.Tests

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

vitalij.marcukov2BP2F — Wed, 24 Dec 2025 00:31:34 GMT

I had to use this FEC for one of my scripts (tag rooms) and was also getting an error. The solution I have found (which works for my script) is changing the active view - uidoc.ActiveView=view. See example code below.

with revit.TransactionGroup('Tag Rooms'):
for view in views_data:
room_tags = []

uidoc.ActiveView = view # <-- fix that worked for me

for rvt_link in rvt_links_data:
rvt_link_rooms = get_links_rooms(doc, view.Id, rvt_link.Id)

if rvt_link_rooms:
with revit.Transaction('Room Tags'):
for rlr in rvt_link_rooms:
...

Note: this is an example from my setup and may not apply to every project/version. Please validate in your own environment and test on a backup model. Shared for educational purposes, as-is, without warranty or liability.

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

sriram_rajagopal07 — Wed, 07 Jan 2026 05:28:39 GMT

Dear @vitalij.marcukov2BP2F, Thank you for your suggestion & sharing the sample code. This will work in most of the scenario, but for this version it's not working as expected.

The solution suggested by @ricaun is working fine here

Re: Revit 2025.4 is crashing if I use results of FilteredElementCollector

alexey9L7TK — Tue, 20 Jan 2026 15:43:07 GMT

I'm experiencing the same issue on some of the clients' files, on both Revit 2025.4 and Revit 2026.

Here's a short Revit Python Shell example to trigger the issue.

import clr clr.AddReference("RevitAPI") clr.AddReference("RevitAPIUI") from Autodesk.Revit.DB import * # noqa: F403 uidoc = __revit__.ActiveUIDocument # type: ignore # noqa: F821 doc = uidoc.Document view = doc.ActiveView # Pick first link instance (if any) link_instances = list(FilteredElementCollector(doc).OfClass(RevitLinkInstance).ToElements()) link_inst = link_instances[0] if link_instances else None link_doc = link_inst.GetLinkDocument() if link_inst else None link_elems = ( FilteredElementCollector(doc, view.Id, link_inst.Id).ToElements() )

Unfortunately, it happens only on specific revit files (that are usually tied to Central or some other cloud storage), and I can't yet share a revit file to reproduce that.

I can share some information from Visual Studio catching the crash. I've attached to the Revit process. Here's what I get when Revit crashes:

I've tried all of the hacks suggested in this thread (call Dispose, avoid calling ToElements/ToElementIds, temporary 2-arg FilteredElementCollector) – it still crashes.

If I use FilteredElementCollector(host_doc, host_view.Id, link.Id) togeher with OfCategory or OfCategoryId, it produces an slightly different stack trace on crash:

{The input argument "categoryId" of function Autodesk::Revit::Proxy::DB::FilteredElementCollectorProxy::OfCategoryId or one item in the collection is null at line 524 of file F:\Ship26.2\2026_px64\Source\Revit\RevitDBAPI\gensrc\APIFilteredElementCollectorProxy.cpp.}

However, categoryId isn't null in that case, as can be clearly seen on the MSVS screenshot.

Most likely, there's some heisenbug inside the new FilteredElementCollector(host_doc, host_view.Id, link.Id).

Dear Autodesk, please look into this issue as there's not much workarounds here. Replicating the behaviour of 3-arg FilteredElementCollector is rather hard and very error-prone.

Thank you!