topic Re: Changes cannot be shown until the external command ends in Revit API Forum

Changes cannot be shown until the external command ends

Anonymous — Wed, 26 Jun 2013 21:55:04 GMT

I have a command that is triggered by button in a ribbon. This command creates multiple ViewPlans automatically, the issue that I'm facing is that when I run the command the form shows fine I create the new Views but the changes are not shown until I close the form and the external command ends.

How can I do the same task but being able to see the changes instantly in the background without having to close the form? I have seen that in other addins but I don't know what I'm doing different.

Here is some of my code.

    [Transaction(TransactionMode.Automatic)]    
    public class Command : IExternalCommand
    {
        Result IExternalCommand.Execute(
            ExternalCommandData commandData,
            ref string message,
            ElementSet elements) 
        {
            ViewCreator myViews = new ViewCreator(commandData);            

            try
            {
                ProjectSetupForm myForm = new ProjectSetupForm(myViews);
                myForm.ShowDialog();
                return Result.Succeeded;
            }
            catch (Exception ex)
            {
                message = ex.Message;
                return Result.Failed;
            }
        }  
    }

ViewCreator is my class where I have all my properties and methods.

I create all de ViewPlans inside the form with all the data that the user inputs.

I really apreciate your help.

Thanks,

Marc

Re: Changes cannot be shown until the external command ends

ollikat — Thu, 27 Jun 2013 05:37:46 GMT

Hi.

Document.Regenerate() function usually does what you are looking for.

Re: Changes cannot be shown until the external command ends

Anonymous — Thu, 27 Jun 2013 13:27:30 GMT

Thanks for your help ollikat I really appreciate it.

I have tried to use the Document.Regenerate() method but it doesn't seams to work for my program.

Do you think that it has something to do with opening the form in modal?

If I try to show the form modless like this

myForm.Show();

The program crashes in this line of code when I use ViewPlan.Create method.

ViewPlan vPlan = ViewPlan.Create(_doc, vft.Id, levelID);

Thanks again for your help!

Re: Changes cannot be shown until the external command ends

ollikat — Fri, 28 Jun 2013 06:37:10 GMT

Sorry to hear that Regenerate doesn't help.

No I don't think that modal dialog has any effect on your issue...at least directly. You might be able to do some magic with modeless dialog and idling event etc. but tha's not my strongest area currently.

As far as I know, only option you have left is that you commit the transaction where you have created those objects. It should refresh the project up to date.

Although I have to admit that I'm not perfectly aware how those view plans should appear. Someone else in this forum was askin whether changing the selection trough API would cause property palette to update, but that wasn't possible while external command was executing. So maybe there's something similar here (?).

Re: Changes cannot be shown until the external command ends

Anonymous — Fri, 28 Jun 2013 13:58:31 GMT

Hi,

Thanks again for your help! I'll try to play with it and see how it goes. No luck so far.

If I find a way to fix it I'll reply back the solution.

Thanks

Re: Changes cannot be shown until the external command ends

Joe.Ye — Tue, 02 Jul 2013 09:49:46 GMT

Hi,

Because you are using the automatic transaction model. So the model will not get updated until the command end and the automatica transaction commited.

The solution is to use the manual external transaction mode. And start the transaction before changing the model. Then just afte the change, Commit the transaction immediately in the handler of the button.

This should be able to update the model when the form is visible.

______________________________________________________________

If my post answers your question, please click the "Accept as Solution" button. This helps everyone find answers more quickly!

Re: Changes cannot be shown until the external command ends

Anonymous — Tue, 02 Jul 2013 22:04:31 GMT

Thanks for your help. I can't get the model update until the command ends. This is what I've changed so far, but is not updating the model because all changes are happening inside the form.

How can I make sure that I commit those changes multiple times inside the form?

    [Transaction(TransactionMode.Manual)]
    [Regeneration(RegenerationOption.Manual)]
    public class Command : IExternalCommand
    {
        Result IExternalCommand.Execute(
            ExternalCommandData commandData,
            ref string message,
            ElementSet elements) 
        {
            Document _doc = commandData.Application.ActiveUIDocument.Document;

            ViewCreator myViews = new ViewCreator(commandData);            

            try
            {
                using (Transaction trans = new Transaction(_doc,"CreateViews"))
                {
                    trans.Start();

                    ProjectSetupForm myForm = new ProjectSetupForm(myViews);
                    myForm.ShowDialog();

                    trans.Commit();
                }
                
                return Result.Succeeded;
            }
            catch (Exception ex)
            {
                message = ex.Message;
                return Result.Failed;
            }
        }

Thanks again for any help provided!

Marc

Re: Changes cannot be shown until the external command ends

Joe.Ye — Thu, 04 Jul 2013 06:21:23 GMT

Hi Marc,

Would you try start transaction in the button handler, and commit it within the button handler too? You need to pass in the current document to ProjectSetupForm class. So transaction can be started within class ProjectSetupForm.

Hope this helps.

Re: Changes cannot be shown until the external command ends

Anonymous — Tue, 09 Jul 2013 16:16:18 GMT

Hi,

Thanks again! This time worked perfectly! For some reason I thought that I had to do the transaction within the Command class.

I changed the transaction to Manual

    [Transaction(TransactionMode.Manual)]
    [Regeneration(RegenerationOption.Manual)]
    public class Command : IExternalCommand
    {
        Result IExternalCommand.Execute(
            ExternalCommandData commandData,
            ref string message,
            ElementSet elements)
        {
            ViewCreator myViews = new ViewCreator(commandData);          

            try
            {
                ProjectSetupForm myForm = new ProjectSetupForm(myViews);
                myForm.ShowDialog();
                return Result.Succeeded;
            }
            catch (Exception ex)
            {
                message = ex.Message;
                return Result.Failed;
            }
        }
    }

And then inside my ViewCreator class I did the transaction with the method that creates every view.


using (Transaction trans = new Transaction(_doc, "CreateViews"))
{
    trans.Start();

    // Code ...

    trans.Commit();
}

Thanks a lot for your help!!

Marc