topic Re: Is it possible to change the walltype name through API? in Revit API Forum

Is it possible to change the walltype name through API?

Anonymous — Mon, 28 Jul 2014 23:57:40 GMT

I am trying to change the WallType for all walls in the selection.

I am trying to implement it in the following way:

Selection selection = uidoc.Selection;
ElementSet collection = selection.Elements;

List<WallType> type=new List<Walltype>();

int index =0;

Transaction trans = new Transaction(doc);
                trans.Start("Wall Type");
                foreach (Element collectedElem in collection)
                {

if (collectedElem.GetType().Name == "Wall")
                    {
                        Wall wall = null;
                        wall = (Wall)collectedElem;

string wallValue = collectedElem.Name.ToUpper() + ":" + collectedElem.Level.Name;

//excelWallInfo is a string list loaded from external excel file. Each entry is in the format WalltypeName+":"+Level+":"+NewName

                    foreach (string entry in excelWallInfo)
                        {
                            if (entry.Contains(wallValue) == true)
                            {

                                string[] entryElements = entry.Split(':');
                                string newWallTypeName = entryElements[2];
                                if (newWallTypeName == "None" || newWallTypeName == null)
                                {
                                    newWallTypeName = "EmptyName";
                                }

                              type.Add((WallType)wall.WallType.Duplicate(newWallTypeName)); //This line has problem in the second iteration.

                                TaskDialog.Show("Duplicated Element Type", type[index].Name);
                                  wall.WallType = type[index];

                                  index ++;

                            }

                        }

                    }
                    trans.Commit();

                }

The above code stopped in the second iteration. The first change is successful. However, in the second iteration. The revit software throughs it into the exception.

Any help is appreciated! Thanks very much!

Re: Is it possible to change the walltype name through API?

Anonymous — Mon, 28 Jul 2014 23:59:11 GMT

I am not just want to change the WallType.Name, since it will change the name of all walls of the same type. I am trying to give each wall a new name.

Thank you very much!

Re: Is it possible to change the walltype name through API?

jeremytammik — Tue, 29 Jul 2014 07:09:25 GMT

Dear Jeffreybo.liu,

I see several issues with your code.

Before addressing those, though, are you absolutely sure that you know what you are doing?

Waht you are trying to achieve sounds rather questionable to me.

Do you have an in depth understanding of the underlying Revit BIM paradigm and best practices?

Anyway, if you really wnat to achieve what you say, I have the following suggestions:

I recommend encapsulating the transaction instantiation in a C# 'using' statement:

http://thebuildingcoder.typepad.com/blog/2012/04/using-using-automagically-disposes-and-rolls-back.html

http://thebuildingcoder.typepad.com/blog/2012/11/temporary-transaction-trick-touchup.html

Furthermore, it will probably clarify and simplify things if you separate the different steps of your operation, instead of lumping them all into one single big iteration, e.g.:

Iterate over the selection and collect the walls that need updating. Close the iteration.
Iterate over excelWallInfo and determine the required wall types. Close the iteration.
Open a transaction.
Duplicate the required wall types.
Iterate over the walls that need modifying and do the dirty deed.
Commit the transaction.

I hope this helps.

Cheers,

Jeremy

Re: Is it possible to change the walltype name through API?

fernadonoso — Thu, 25 May 2023 16:36:59 GMT

I am thinking in develop a Script that change all Walls types names based in properties of the walls types, is not first time that the name of the type mentions 30cm Thickness wall and it does not match to the real thickness of the wall type, so in my script the name of the wall type will be generated taking the function (exterior, interior , etc) the material of each layer of the wall and thickness and the total wall thickness.

For example InteriorWall_Concrete-100, for a one layer interior wall and 100mm thickness or

ExteriorWall_Concrete-100_Bricks-100_200.

My I ask why is that against best practices?

With that plugging I will avoid have different naming system and I will be sure that the name of the type is matching to the real properties... sounds a crazy thing for you? or super complicated task?

I will appreciate your advice 🙂

Re: Is it possible to change the walltype name through API?

jeremy_tammik — Thu, 25 May 2023 18:04:15 GMT

For me as a programmer, that makes perfect sense and is perfectly feasible.

However, I am not a BIM expert and cannot advise you on best practices.

I would suggest that you raise that question in the generic architectural forum instead.

Re: Is it possible to change the walltype name through API?

GaryOrrMBI — Thu, 25 May 2023 19:25:31 GMT

To respond to the comment made by @jeremy_tammik concerning going over to the Arch group and asking the question again... I might be able to add a bit of info for you...

My primary job is Revit tech (and support) in an Architectural firm (I just do a little coding when needed to get things working the way we need them to) and I have worked as CAD/BIM Manager at a couple of firms over the many years and I can tell you:

That is an excellent idea and will greatly benefit those working in the model(s).

-Gary

Re: Is it possible to change the walltype name through API?

TripleM-Dev.net — Thu, 25 May 2023 21:12:58 GMT

Hi @Anonymous ,

I can't follow the code completely some context is missing, but from what I think it does I would not recommend it.

Couple of things with the code / logic:

1. It tries to Duplicate a WallType X each time with a Wall Type Named Y, this fails because Wall Type Y already exists.

You should first retrieve all walltypes and if Wall Type Y already exists it can't be recreated!

Imagine creating a second walltype "EmptyName", that won't work either.

2. Why create a new Walltype altogether?, it's based on it's type properties, then just rename it.

do check if the name already exists, .... what action to take if it already exist??

3. Level, what does this have to do with the Type name of a wall, from what I see the Level is stripped from the new name, so 2 walls with identical types but on different levels would have different names (?) in the ExcelWallInfo but would be renamed identicall, again each name can only exist once in project.

4. The ExcelWallInfo list, how is this built, seems it doesn't take the layers, thickness, interior into account

5. Model Groups; walls in groups can't have their walltype changed by API etc...

6. Can't read the code clearly, (use the forums Code insert button), looks that the commit happens each iteration of the selected walls, call the Commit after all walls are processed.

+ If all this could be corrected you would end up with a lot of WallTypes....and what about the description or other text fields?

If I would need to force a naming structure just iterate the WallTypes in the project and base it's name on the properties as total width (as in you're other post), with maybe a translation dictionary if certain materials(names) are used in layers.

- Michel

Re: Is it possible to change the walltype name through API?

RPTHOMAS108 — Fri, 26 May 2023 01:16:18 GMT

This is one of the fundamental things we all want to do at some point: reduce what a type is to a string value of the main things that define it. The idea works fine until there is a certain minor detail which distinguishes two types. In the end human beings use Revit models not robots. So there is only a certain extent to which you can codify such things and it still be readable and fit on screen where it is read. What features are most important to represent and in which order, that is always the endless discussion.

Regarding original post from 2014 by others the issue is likely related to:

They are also using the name from GetType rather than Revit parameter value or API property i.e. not using something written specifically for RevitAPI but instead depending on a general programming feature (things inherited from object).

Re: Is it possible to change the walltype name through API?

jeanmarc.couffin — Fri, 02 Jun 2023 08:51:30 GMT

Interesting idea and pretty funny to see this poping from 2014

me: I could code that and make it a pyRevit tool, I could grab the parameters list, let the people select and build a naming convention and set types for specific categories... <Type Mark>-<Thickness>mm-<Fire Rating>h

... 5 min later

I'd rather have that built in Revit itself -> idea station

...5 min later: ideas station search:

So it seems that without even digging too much, the idea makes sense for a lot of people, it got 100s of votes and no implementation consideration from the revit dev team so far.

sic.

Re: Is it possible to change the walltype name through API?

jeanmarc.couffin — Fri, 02 Jun 2023 09:08:59 GMT

I extended the conversation to the revit preview forum https://feedback.autodesk.com/project/forum/thread.html?cap=cb0fd5af18bb49b791dfa3f5efc47a72&forid={590BECF7-C1AB-4BC2-9D4E-E8F14960D657}&topid={768DD734-CFCF-4537-B15E-3F31071F55B6}

Re: Is it possible to change the walltype name through API?

jeremy_tammik — Mon, 05 Jun 2023 12:18:20 GMT

Thank you for collecting all these requests. I pointed it out to the development team... no response yet, though.

Re: Is it possible to change the walltype name through API?

jeanmarc.couffin — Mon, 05 Jun 2023 12:23:44 GMT

Thanks for that

@jeremy_tammik