Update Revit errors

Anonymous — Thu, 11 Sep 2014 00:45:50 GMT

The red text are the errors. Using Revit 2015 and C# 2012 had this running with earlier External Tools trying to update.

Public Result Execute(ExternalCommandData commandData,ref string message,ElementSet elements)

{

Document rvtDoc = application.ActiveDocument;

Revit.ElementSet selSet = rvtDoc.Selection.Elements;

Revit.Element elem = default(Revit.Element);

Revit.ElementSet selSet = rvtDoc.Selection.Elements;

using System; using System.Collections.Generic;

using System.Diagnostics; using Autodesk.Revit.ApplicationServices;

using Autodesk.Revit.Attributes;

using Autodesk.Revit.DB;

using Autodesk.Revit.UI;

using Autodesk.Revit.UI.Selection;

Any help would be appreciated.

Bob V

Re: Update Revit errors

Anonymous — Thu, 11 Sep 2014 04:49:55 GMT

It looks like you have some confusion regarding the different types of document objects and the namespace of certain classes.

I'll run quickly through the issues I can see in order and then provide a working example below.

I can't see the application object being declared or passed into your method, is it declared in the class itself? What is its type? It doesn't look to be a standard API class so I'm assuming it's a custom container / helper class. To get at the Database level document you need to dive into the commandData parameter that is passed into the method by the API. commandData.Application.ActiveUIDocument.Document is what you need for that, but as I note in my next point I don't think this is actually what you wanted to do.

The rvtDoc object looks to be of the wrong class for what you are trying to do with it. The UI level document class is the one that contains the Selection property, you are trying to use the DB level document.

ElementSet is found in the Autodesk.Revit.DB namespace, not Revit. You already have the DB namespace declared so ElementSet alone will suffice.

As above, Element is also a member of the Autodesk.Revit.DB namespace, you already have this declared, so Element is just fine

You are defining selSet twice in the same context, the second declaration and assignment looks to be unintentional and not needed, remove it.

Selection.Elements has been depreciated in the 2015 API, it will still work, but you'll need to revisit any code that uses it in a future release as it will no doubt be removed at some point. Best to use Selection.GetElementIds() instead and then use the ids to query the database Document for the actual Elements. For simplicity, I'll leave this alone in my example.

I am assuming that the using directives are at the top your file and you have just pasted them below for readability, if not, move them to the top of the source file, outside of the class declaration.

As promised here's one that will work better.

Public Result Execute(ExternalCommandData commandData,ref string message,ElementSet elements)
{
UIDocument rvtDoc = commandData.Application.ActiveUIDocument;
ElementSet selSet = rvtDoc.Selection.Elements;
Element elem = default(Element);

While this will fix the code snippet you pasted, if further down the method you are dealing with rvtDoc as if it was a database document, you will get a new set of errors. If this happens just add Document dbDoc = commandData.Application.ActiveUIDocument.Document; at the top of the method and update the affected code to suit.

topic Re: Update Revit errors in Revit API Forum

Update Revit errors

Re: Update Revit errors