topic Re: Revit freezes using Element.Delete() on a Revit Link Type? (Code included) in Revit API Forum

Revit freezes using Element.Delete() on a Revit Link Type? (Code included)

Anonymous — Wed, 03 Jun 2015 09:04:26 GMT

Hi, I am trying to remove all revit links from a revit file and for some reason when i call delete on the revit link type revit freezes and asks me if i would like to create a recovery file. my experience with revit is not huge so apologies if this is a stupid question.

Here is my code(Ignore commented code)

Thank you in advance, you guys are always great.

Jack

Re: Revit freezes using Element.Delete() on a Revit Link Type? (Code included)

jeremytammik — Wed, 03 Jun 2015 09:08:21 GMT

Dear Jack,

Thank you for reporting this.

It sounds as if you are hitting some internal element that should not be removed.

Maybe you can add some additional filter checks to avoid hitting the sensitive element that is causing this behaviour.

Anyway, since you are checking the CanBeDeleted predicate before attempting to delete, this sounds like an error to me.

Can you please provide a full reproducible case, i.e. the entire Visual Studio solution, add-in manifest, and minimal sample model to run this in?

http://thebuildingcoder.typepad.com/blog/about-the-author.html#1b

Then I'll raise an issue with the development team to explore in more depth for you.

Thank you!

Cheers,

Jeremy

Re: Revit freezes using Element.Delete() on a Revit Link Type? (Code included)

Anonymous — Thu, 04 Jun 2015 09:04:18 GMT

Thank you Jeremy, here is everything you requested, If there is any problems let me know.
Thanks again,
Jack

Re: Revit freezes using Element.Delete() on a Revit Link Type? (Code included)

jeremytammik — Thu, 04 Jun 2015 11:07:56 GMT

Dear Jack,

Thank you for your sample material.

I created a cleaned up version of your sample add-in, attached it below in PurgeLinksFreeze.zip, and can reproduce the behaviour you describe.

I'll pass it on to the development team as soon as I can. I don't have access to the system right now due to travels.

I'll let you know as soon as I have any news.

Cheers,

Jeremy

Re: Revit freezes using Element.Delete() on a Revit Link Type? (Code included)

jeremytammik — Thu, 04 Jun 2015 11:30:39 GMT

Sorry, Jack, it seems it was your own fault after all.

You must not modify elements that you are iterating over.

That corrupts the iteration process.

Look at the new attached solution that achieves the deletion with no freeze:

  UIApplication uiapp = commandData.Application;
  UIDocument uidoc = uiapp.ActiveUIDocument;
  Document doc = uidoc.Document;

  FilteredElementCollector links 
    = new FilteredElementCollector( doc )
      .OfClass( typeof( RevitLinkType ) );

  ICollection<ElementId> ids = links.ToElementIds();

  using( Transaction t = new Transaction( doc ) )
  {
    t.Start( "Delete Links" );
    doc.Delete( ids );
    t.Commit();
  }

  return Result.Succeeded;

I attached the complete solution, source code and add-in manifest below.

Cheers,

Jeremy

Re: Revit freezes using Element.Delete() on a Revit Link Type? (Code included)

Anonymous — Thu, 04 Jun 2015 14:11:42 GMT

Thanks a million jeremy, You have been very helpful, I am still learning.

Jack