topic Re: Trigger when adding new element. in Revit API Forum

Trigger when adding new element.

mohd.fadel — Tue, 15 Dec 2015 13:31:19 GMT

Hello everyone,

I'm still not quite sure if i get this right. Using a Dynamic Model Update, the GetAddedElementIds() function retrieves added parameters, or added elements?

I mean, when i'm using GetAddedElementIds(), i'm waiting for a parameter to be added to the element, or i'm waiting for the user to draw a new element?

I'm trying to set a parameter's value for newly drawn elements.

This is my code:

                foreach (ElementId id in
                  data.GetAddedElementIds())//.GetModifiedElementIds())
                {
                     Element elem = doc.GetElement(id);
                     ParameterSet parameters = elem.Parameters;

                     foreach (Parameter param in parameters)
                     {
                         if (param.Definition.Name == "TEST")
                         {
                             switch (param.StorageType)
                             {
                                  case Autodesk.Revit.DB.StorageType.String:
                                      if (!String.IsNullOrWhiteSpace(param.AsString()))
                                      {
                                          param.SetValueString(elem.UniqueId.ToString());
                                          param.Set(elem.UniqueId.ToString());
                                      }
                                  break;
                             }
                         }
                     }
                }

Note: I'm able to set the value if i use GetModifiedElementIds() and just try to modify an exiting element's parameter.

Any help is appreciated.

M.Fadel

Re: Trigger when adding new element.

jeremytammik — Tue, 15 Dec 2015 14:47:56 GMT

Dear M. Fadel,

A simpler way of obtaining newly added elements is to subscribe to the DocumentChanged method.

However, it does not allow you to modify the document in the same transaction as the action that triggered it, like the dynamic model update does.

Here is a comparison of the two approaches:

http://thebuildingcoder.typepad.com/blog/2012/06/documentchanged-versus-dynamic-model-updater.html

Best regards,

Jeremy

Re: Trigger when adding new element.

mohd.fadel — Tue, 15 Dec 2015 15:17:07 GMT

Hello Jeremy,

Thank you for your reply. I'm aware of both approaches and how the first is read-only (that was my starting point).

I was able to work with the IUpdater class after a long struggle (not easy to work with). But like i said, i'm only being able to GetModifiedElementIds().

If i try GetAddedElementIds() to simply output a message:

          foreach (ElementId id in data.GetAddedElementIds())
                {
                    System.Windows.Forms.MessageBox.Show("Hello");
                }

it's not working. Is there a special way to draw a new element (for example Column) to the Revit project?!

M.Fadel

Re: Trigger when adding new element.

jeremytammik — Tue, 15 Dec 2015 15:45:24 GMT

Thank you for your appreciation.

Glad you know what you are doing.

Of course it is not working!

Every call to the method returns a new list.

If you call it several times in a row, all except the first call will return an empty list.

Store the result of the first call to GetAddedElementIds in a suitable container, and then iterate over that instead of calling it anew every time.

Cheers,

Jeremy

Re: Trigger when adding new element.

mohd.fadel — Tue, 15 Dec 2015 15:57:39 GMT

Oh!! I thought GetAddedElementIds() was the final list (usable by the program).

OK, I have 2 questions in this case:)

1- How come you used the Id directly in your code in your blog:

 foreach( ElementId id in 
      data.GetAddedElementIds() )
    {
      View view = doc.GetElement( id ) as View;
 
      if( null != view 
        && ViewType.Elevation == view.ViewType )
      {
        TaskDialog.Show( "ElevationWatcher Updater",
          string.Format( "New elevation view '{0}'",
            view.Name ) );
      }
    }

2- How come the GetModifiedElementIds() is usable as a list and the GetAddedElementIds() is not?! Is it because there's a chance of deciding to delete the new element?

Thank you for your help! I'm kind of finishing up here at the office now. Will check it first thing tomorrow!:)

M. Fadel

Re: Trigger when adding new element.

jeremytammik — Tue, 15 Dec 2015 16:09:42 GMT

'Oh', from me too.

I think I was just plain wrong.

An all-too-quick assumption.

But if that is not it, then in what way is it not working for yoou?

By the way, if you are having any problems with DMU, you should always try out ChangeTypeAny and see whether that improves things.

Cheers,

Jeremy

Re: Trigger when adding new element.

mohd.fadel — Tue, 15 Dec 2015 17:34:08 GMT

Hahahah. No problem.

What's not working is that when i add (draw) an element and not a parameter, my code doesn't work:

foreach (ElementId id in data.GetAddedElementIds())
                {
                    System.Windows.Forms.MessageBox.Show("Hello");
                }

However, if the element already exists, and i'm trying to modify a parameter in this element (using GetModifiedElementIds()) it works.

So again, my initial question is this:

Is the GetAddedElementIds and GetModifiedElementIds functions at the level of adding, modifying, and deleting parameters, or on the level of adding, modifying, and deleting elements?!

Note: I tried to answer myself this question. I added a new parameter to my element (because modifying a parameter worked for me) to see if the message "Hello" will work, but it didn't! So this made me wonder even more!!:p On which level do these functions work?!!!

And one last thing, i can't use ChangeTypeAny because again, i'm trying to update my parameters. So i can't be using the DocumentChanged method.

Thanks in advance:)

M. Fadel

Re: Trigger when adding new element.

jeremytammik — Tue, 15 Dec 2015 18:16:38 GMT

The element ids always refer to database elements, not to parameters.

Yes you can use ChangeTypeAny.

That defines your trigger, and means that it reacts to any change, including parameter modifications.

Re: Trigger when adding new element.

Revitalizer — Wed, 16 Dec 2015 08:08:38 GMT

Hi,

may this thread help you ?

http://forums.autodesk.com/t5/revit-api/set-instance-parameters-at-insertion-or-modification/m-p/5715477/highlight/true#M10776

Revitalizer

Re: Trigger when adding new element.

mohd.fadel — Wed, 16 Dec 2015 09:43:07 GMT

Hello Revitalizer,

Thanks for your post.. I followed Tim's code. Again, it's only working when modifying an element. But not when the element is newly added (drawn). And when i replaced:

Element.GetChangeTypeAny()

with

ChangeType.ConcatenateChangeTypes(Element.GetChangeTypeGeometry(), Element.GetChangeTypeElementAddition())

like you suggested, i got this error:

Third party updater 'WatcherUpdater' has experienced a problem and its action had to be canceled.

I attached my complete code in this post. If you can have a look i would really appreciate it!

M. Fadel

Re: Trigger when adding new element.

Revitalizer — Wed, 16 Dec 2015 10:03:13 GMT

Hi,

you cannot modify an Element in the "OnModified"-Updater since it would generate a circular reference.

Modifying would trigger the Updater again and again and again...

Revitalizer

Re: Trigger when adding new element.

mohd.fadel — Wed, 16 Dec 2015 10:15:58 GMT

Hey,

So you think i should ommit Elmnts.AddRange(data.GetModifiedElementIds())?

I did, the same error occured.

M.Fadel

Re: Trigger when adding new element.

Revitalizer — Wed, 16 Dec 2015 10:45:17 GMT

Hi,

my fault.

You can indeed modify Elements in the Execute method, but you cannot create new ones.

May it be that your ElementCategoryFilter is too common ?

In this version, you monitor thousands of elements without need.

Revitalizer

Re: Trigger when adding new element.

mohd.fadel — Wed, 16 Dec 2015 12:34:09 GMT

Hello again,

That's it! I tried applying a BuiltInCategory.OST_StructuralColumns as the filter. It worked fine!

Should i just add all categories manually? As i understand i can't use the AllowsBoundParameters function to get all my needed Categories on StartUp.

Is there any easier approach to this?

M.Fadel

Re: Trigger when adding new element.

mohd.fadel — Wed, 16 Dec 2015 12:42:55 GMT

Hello again Jeremy,

Just wanted to let you know that Revitalizer helped me out with this problem. Actually, he showed me a post you participated in a couple of months ago. I think you were right the first time! I believe this solved the issue:

                List<ElementId> Elmnts = new List<ElementId>();
                Elmnts.AddRange(data.GetAddedElementIds());

I'm really not able to comprehend all this. I hope i will have an in-depth understanding of this once i am done with the work at my hand.

I appreciate your help!:)

M.Fadel

Re: Trigger when adding new element.

Revitalizer — Wed, 16 Dec 2015 12:55:04 GMT

Hi,

I thought that you already use this get-BuiltInCategories-one-time-approach:

http://forums.autodesk.com/t5/revit-api/retrieve-all-elements-on-start-up/m-p/5844763/highlight/true#M12107

What's so complicated in getting a document's categories, checking one property and casting the category's Id.IntegerValue to a BuiltInCategory ?

As already said, such a function would only to be run one single time in document context.

A throw-away macro.

The resulting list of BuiltInCategories (to whom a parameter could be added) is document independent, thus can be used OnStartup to initialize your MultiCategoryFilter.

Revitalizer

Re: Trigger when adding new element.

mohd.fadel — Wed, 16 Dec 2015 13:15:54 GMT

Hahaha! Good memory!!

I was using this method.. But it got complicated once i used the DocumentOpenedEventArgs, DocumentChangedEventArgs, and a OnStartUp methods. I'm not saying it didn't work! I made it work.

But i saw Tim's solution, and found it much easier! I thought maybe it would work (appartently for specific categories:s)! This made me forget about my initial dilemna!

For that i apologize! Thanks for your help yet again:)

M.Fadel