topic Re: GetEndPointReference() Returns invalid operation in Revit API Forum

GetEndPointReference() Returns invalid operation

Anonymous — Fri, 24 Jun 2016 16:41:13 GMT

Hi.

I am trying to create a sweep inside a family document and add some dimensions to its end points.

But I am getting some unexpected behaviour.

If I create manually the sweep I can programatically add dimensions, but if the sweep has been programatically created it refuese to do it.

I attach both codes. The first one lets you pick a sweep and adds the dimensions inside. The second one creates the sweep and then tries to add dimensiosn to it. And of course fails.

I am working with Revit 2016

Does anyone know how to solve this?

These two samples are intender to work under the sharpdevelop macro IDE.

Thanks in advance to all.

Jose Ignacio Montes (AvatarBIM)

        public void DimSweepLines()
        {
            Document doc =this.ActiveUIDocument.Document;
            Reference reference = this.ActiveUIDocument.Selection.PickObject(ObjectType.Element);
            Sweep sweep = doc.GetElement(reference) as Sweep;

            Sketch sketch = sweep.PathSketch;
            DimensionType dimType = (from d in new FilteredElementCollector(doc).WhereElementIsElementType().OfType<DimensionType>()
                                     select d).FirstOrDefault();
            foreach (CurveArray array in sketch.Profile)
            {
                Line l =null;
                ReferenceArray refArray = null;
                foreach (Curve curve in array)
                {
                    l = Line.CreateBound(curve.GetEndPoint(0),curve.GetEndPoint(1));
                    refArray = new ReferenceArray();
                    refArray.Append(curve.GetEndPointReference(0));
                    refArray.Append(curve.GetEndPointReference(1));
                    Transaction te = new Transaction(doc);
                te.Start("FamilyDim");
                Dimension dim = doc.FamilyCreate.NewDimension(doc.ActiveView,l,refArray,dimType);
                te.Commit();
                }
            }
        }

        public void CreateAndDimSweep()
        {
            UIApplication uiapp = this;
            UIDocument uidoc = uiapp.ActiveUIDocument;
            Document fdoc =uidoc.Document;
            if(!fdoc.IsFamilyDocument) return;
            Transaction t = new Transaction( fdoc,
                     "Create sweep inside family" );

            t.Start();
            Sweep sweep = Createsweep(fdoc);
            sweep.Pinned = false;
            t.Commit();

            Sketch sketch = sweep.PathSketch;
            DimensionType dimType = (from d in
                                     new FilteredElementCollector(fdoc)
                                     .WhereElementIsElementType()
                                     .OfType<DimensionType>()
                                     select d).FirstOrDefault();
            foreach (CurveArray array in sketch.Profile)
            {
                Line l =null;
                ReferenceArray refArray = null;
                foreach (Curve curve in array)
                {
                    l = Line.CreateBound
                        (curve.GetEndPoint(0),curve.GetEndPoint(1));
                    refArray = new ReferenceArray();
                    Reference refe = curve.Reference;
                    try {
                        Transaction te = new Transaction(fdoc);
                        te.Start("FamilyDim");
                        refArray.Append(curve.GetEndPointReference(0));
                        refArray.Append(curve.GetEndPointReference(1));
                        Dimension dim = fdoc.FamilyCreate
                            .NewDimension(fdoc.ActiveView,l,refArray,dimType);
                        te.Commit();

                    } catch (Exception e) {

                        string error = e.Message;
                        throw;
                    }
                }
            }
        }

Re: GetEndPointReference() Returns invalid operation

Anonymous — Fri, 24 Jun 2016 18:45:20 GMT

For completenes I have to say that if I manually modify the sketck of the sweep that was created through the API, then the API can create the dimensions.

I havve read that the method GetEndpointReference doesnt work on elements that are readonly. And this endpoints are readonly. But the strange thing is that they are allways read only, the API generated ones and the manually created. But the manuals are being dimensioned without any problem.

Regards

Re: GetEndPointReference() Returns invalid operation

Mustafa.Salaheldin — Sat, 25 Jun 2016 07:30:52 GMT

You forget to provide the function "Createsweep(fdoc)" so please provide your sample family and full VS project so I can help.

Re: GetEndPointReference() Returns invalid operation

Anonymous — Sun, 26 Jun 2016 03:57:40 GMT

Yes, sorry about that. These are the missing methods.

Thanks!

        Autodesk.Revit.DB.Sweep Createsweep(Document doc)
        {

            XYZ puntoi = new XYZ(-450,1400,0);
            XYZ puntof = new XYZ(450,1400,0);
            double di = 30;
            double df = 38;
            double dd=25;

            //Operaciones de desplazamiento
            //Por ahora a lo burro, sin transformacion de coordenadas
            XYZ puntoit = new XYZ(puntoi.X+di,0,puntoi.Y-dd);
            XYZ puntoim = new XYZ(0,0,0);
            XYZ puntoft = new XYZ(puntof.X-df,0,puntoi.Y-dd);


            List<XYZ> _barrido = new List<XYZ>();
            _barrido.Add(puntoit);
            _barrido.Add(puntoft);

            FamilyItemFactory factory = doc.FamilyCreate;

            CreationApplication creapp = doc.Application.Create;
            SketchPlane sketch = FindElement( doc,
                                             typeof( SketchPlane ), "Center (Front/Back)")
                as SketchPlane;

            CurveArrArray curveArrArray = new CurveArrArray();
            curveArrArray.Append( CreateClosedProfile( _countour, creapp ));
            SweepProfile profile = doc.Application.Create.NewCurveLoopsProfile(curveArrArray);

            CurveArray Path =  CreateProfile( _barrido, creapp );

            return factory.NewSweep(true, Path, sketch,
                                    profile , 0, ProfilePlaneLocation.MidPoint );
        }

        Element FindElement(
            Document doc,
            Type targetType,
            string targetName )
        {
            return new FilteredElementCollector( doc )
                .OfClass( targetType )
                .First<Element>( e => e.Name.Equals( targetName ) );
        }

        CurveArray CreateProfile(
            List<XYZ> pts,
            CreationApplication creapp )
        {
            CurveArray profile = new CurveArray();

            int n = pts.Count;
            if(n==1) return null;
            for( int i = 1; i < n; ++i )
            {
                int j =  i - 1;

                profile.Append( Line.CreateBound(
                    pts[j].MmToFootPoint() ,
                    pts[i].MmToFootPoint() ) ) ;
            }
            return profile;
        }

Re: GetEndPointReference() Returns invalid operation

Anonymous — Mon, 27 Jun 2016 22:06:32 GMT

Please find:

http://forums.autodesk.com/t5/revit-api/null-reference-error-when-adding-dimension/m-p/6388655#M16774

The reference is somehow not working meanwhile you are creating the sweep. Its strange, but a known issue.

You can find a working code at the end.

regards

Christian

Re: GetEndPointReference() Returns invalid operation

Anonymous — Tue, 28 Jun 2016 20:38:12 GMT

Thanks I will take a look at it.

Regards.

Jose Ignacio Montes

Re: GetEndPointReference() Returns invalid operation

Anonymous — Tue, 28 Jun 2016 20:39:36 GMT

De nada. Dime si tienes mas preguntas (Let me know if you have more questions.)

😉

Christian

Re: GetEndPointReference() Returns invalid operation

Mustafa.Salaheldin — Tue, 28 Jun 2016 20:45:02 GMT

Let us know if you try it and it works because I tried and it didn't work for me. My be I'm messing something.

Re: GetEndPointReference() Returns invalid operation

Anonymous — Tue, 28 Jun 2016 20:55:24 GMT

It is important to create the CurveArrArray for the sweep upfront, so the sweep is actually created and can be referenced.

CurveArrArray cArr = famdoc.Application.Create.NewCurveArrArray();

Re: GetEndPointReference() Returns invalid operation

Mustafa.Salaheldin — Wed, 29 Jun 2016 06:16:01 GMT

Here is my code:

//
// (C) Copyright 2003-2014 by Autodesk, Inc.
//
// Permission to use, copy, modify, and distribute this software in
// object code form for any purpose and without fee is hereby granted,
// provided that the above copyright notice appears in all copies and
// that both that copyright notice and the limited warranty and
// restricted rights notice below appear in all supporting
// documentation.
//
// AUTODESK PROVIDES THIS PROGRAM "AS IS" AND WITH ALL FAULTS.
// AUTODESK SPECIFICALLY DISCLAIMS ANY IMPLIED WARRANTY OF
// MERCHANTABILITY OR FITNESS FOR A PARTICULAR USE. AUTODESK, INC.
// DOES NOT WARRANT THAT THE OPERATION OF THE PROGRAM WILL BE
// UNINTERRUPTED OR ERROR FREE.
//
// Use, duplication, or disclosure by the U.S. Government is subject to
// restrictions set forth in FAR 52.227-19 (Commercial Computer
// Software - Restricted Rights) and DFAR 252.227-7013(c)(1)(ii)
// (Rights in Technical Data and Computer Software), as applicable.
//


using System;
using System.Collections.Generic;
using System.Text;
using System.Diagnostics;
using System.IO;
using Autodesk.Revit;
using Autodesk.Revit.DB;
using Autodesk.Revit.UI;
using System.Linq;
using Autodesk.Revit.DB.Structure;

namespace GenericModelCreation
{
   /// <summary>
   /// A class inherits IExternalCommand interface.
   /// This class show how to create Generic Model Family by Revit API.
   /// </summary>
   [Autodesk.Revit.Attributes.Transaction(Autodesk.Revit.Attributes.TransactionMode.Manual)]
   [Autodesk.Revit.Attributes.Regeneration(Autodesk.Revit.Attributes.RegenerationOption.Manual)]
   [Autodesk.Revit.Attributes.Journaling(Autodesk.Revit.Attributes.JournalingMode.NoCommandData)]
   public class Command : IExternalCommand
   {
      #region Class Memeber Variables
      // Application of Revit
      private Autodesk.Revit.ApplicationServices.Application m_revit;
      // the document to create generic model family
      private Autodesk.Revit.DB.Document m_familyDocument;
      // FamilyItemFactory used to create family
      private Autodesk.Revit.Creation.FamilyItemFactory m_creationFamily = null;
      // Count error numbers
      private int m_errCount = 0;
      // Error information
      private string m_errorInfo = "";
      #endregion

      #region Class Interface Implementation
      /// <summary>
      /// Implement this method as an external command for Revit.
      /// </summary>
      /// <param name="commandData">An object that is passed to the external application 
      /// which contains data related to the command, 
      /// such as the application object and active view.</param>
      /// <param name="message">A message that can be set by the external application 
      /// which will be displayed if a failure or cancellation is returned by 
      /// the external command.</param>
      /// <param name="elements">A set of elements to which the external application 
      /// can add elements that are to be highlighted in case of failure or cancellation.</param>
      /// <returns>Return the status of the external command. 
      /// A result of Succeeded means that the API external method functioned as expected. 
      /// Cancelled can be used to signify that the user cancelled the external operation 
      /// at some point. Failure should be returned if the application is unable to proceed with 
      /// the operation.</returns>
      public Autodesk.Revit.UI.Result Execute(ExternalCommandData commandData,
                                             ref string message,
                                             ElementSet elements)
      {
         try
         {
            m_revit = commandData.Application.Application;
            m_familyDocument = commandData.Application.ActiveUIDocument.Document;
            // create new family document if active document is not a family document
            if (!m_familyDocument.IsFamilyDocument)
            {
               m_familyDocument = m_revit.NewFamilyDocument("Generic Model.rft");
               if (null == m_familyDocument)
               {
                  message = "Cannot open family document";
                  return Autodesk.Revit.UI.Result.Failed;
               }
            }
            m_creationFamily = m_familyDocument.FamilyCreate;
            // create generic model family in the document
            CreateGenericModel();
            if (0 == m_errCount)
            {
               return Autodesk.Revit.UI.Result.Succeeded;
            }
            else
            {
               message = m_errorInfo;
               return Autodesk.Revit.UI.Result.Failed;
            }
         }
         catch (Exception e)
         {
            message = e.ToString();
            return Autodesk.Revit.UI.Result.Failed;
         }

      }
      #endregion

      #region Class Implementation

      /// <summary>
      /// Examples for form creation in generic model families.
      /// Create extrusion, blend, revolution, sweep, swept blend
      /// </summary>
      public void CreateGenericModel()
      {
          Sweep sweep = null;

          using (Transaction transaction = new Transaction(m_familyDocument, "CreateGenericModel"))
          {
              transaction.Start();

              sweep = CreateSweep();

              transaction.Commit();
          }

          // Here it comes. Delete the sweep and roll back - now you can access the reference of the endpoints of the arcs

          // Dirty, but it works

          ICollection<ElementId> delIds = null;

          using (Transaction transaction = new Transaction(m_familyDocument, "CreateGenericModel"))
          {
              transaction.Start();

              m_familyDocument.Regenerate();
              
              using (SubTransaction delTrans = new SubTransaction(m_familyDocument))
              {
                  try
                  {
                      delTrans.Start();
                      delIds = m_familyDocument.Delete(sweep.Id);
                      delTrans.RollBack();
                  }
                  catch (Exception ex)
                  {
                      Debug.WriteLine(ex.Message);
                  }

              }

              transaction.Commit();
          }

          Sketch sketch = sweep.PathSketch;

          FilteredElementCollector fc = new FilteredElementCollector(m_familyDocument);

          fc.WhereElementIsElementType().OfClass(typeof(DimensionType));

          DimensionType dimType = fc.Cast<DimensionType>().FirstOrDefault() as DimensionType;


          // Get the model lines in the profile and use the end points for reference the sketch dimensions
          // diameter
          List<ModelLine> mArcs = new List<ModelLine>();

          foreach (ElementId id in delIds)
          {
              Element ele = m_familyDocument.GetElement(id);

              if (ele is ModelLine)
              {
                  mArcs.Add(ele as ModelLine);
              }
          }

          foreach (CurveArray array in sketch.Profile)
          {
              Line l = null;
              ReferenceArray refArray = null;
              foreach (Line curve in array)
              {
                  l = Line.CreateBound(curve.GetEndPoint(0), curve.GetEndPoint(1));

                  refArray = new ReferenceArray();

                  Reference refe = curve.Reference;
                  try
                  {
                      using (Transaction t = new Transaction(m_familyDocument))
                      {
                          if (curve.IsBound)
                          {
                              t.Start("FamilyDim");

                              Reference r1 = mArcs[0].GeometryCurve.GetEndPointReference(0);
                              refArray.Append(r1);
                              Reference r2 = mArcs[0].GeometryCurve.GetEndPointReference(1);
                              refArray.Append(r2);

                              Dimension dim = m_familyDocument.FamilyCreate.NewDimension(m_familyDocument.ActiveView, l, refArray);

                              t.Commit();
                          }
                      }
                  }
                  catch (Exception e)
                  {
                      string error = e.Message;
                      throw;
                  }
              }
          }


          return;
      }

      /// <summary>
      /// Create one sweep
      /// </summary>
      private Sweep CreateSweep()
      {
          Sweep sweep = null;

          try
          {

              #region Create rectangular profile and path curve
              CurveArrArray arrarr = new CurveArrArray();
              CurveArray arr = new CurveArray();

              Autodesk.Revit.DB.XYZ normal = Autodesk.Revit.DB.XYZ.BasisZ;
              SketchPlane sketchPlane = CreateSketchPlane(normal, Autodesk.Revit.DB.XYZ.Zero);

              Autodesk.Revit.DB.XYZ pnt1 = new Autodesk.Revit.DB.XYZ(0, 0, 0);
              Autodesk.Revit.DB.XYZ pnt2 = new Autodesk.Revit.DB.XYZ(2, 0, 0);
              Autodesk.Revit.DB.XYZ pnt3 = new Autodesk.Revit.DB.XYZ(1, 1, 0);
              arr.Append(Arc.Create(pnt2, 1.0d, 0.0d, 180.0d, Autodesk.Revit.DB.XYZ.BasisX, Autodesk.Revit.DB.XYZ.BasisY));
              arr.Append(Arc.Create(pnt1, pnt3, pnt2));
              arrarr.Append(arr);
              SweepProfile profile = m_revit.Create.NewCurveLoopsProfile(arrarr);

              Autodesk.Revit.DB.XYZ pnt4 = new Autodesk.Revit.DB.XYZ(10, 0, 0);
              Autodesk.Revit.DB.XYZ pnt5 = new Autodesk.Revit.DB.XYZ(0, 10, 0);
              Curve curve = Line.CreateBound(pnt4, pnt5);

              CurveArray curves = new CurveArray();
              curves.Append(curve);
              #endregion
              // here create one sweep with two arcs formed the profile
              sweep = m_creationFamily.NewSweep(true, curves, sketchPlane, profile, 0, ProfilePlaneLocation.Start);
              // move to proper place
              Autodesk.Revit.DB.XYZ transPoint1 = new Autodesk.Revit.DB.XYZ(11, 0, 0);
              ElementTransformUtils.MoveElement(m_familyDocument, sweep.Id, transPoint1);
          }
          catch (Exception e)
          {
              m_errCount++;
              m_errorInfo += "Unexpected exceptions occur in CreateSweep: " + e.ToString() + "\r\n";
          }

         return sweep;
      }


      /// <summary>
      /// Create sketch plane for generic model profile
      /// </summary>
      /// <param name="normal">plane normal</param>
      /// <param name="origin">origin point</param>
      /// <returns></returns>
      internal SketchPlane CreateSketchPlane(Autodesk.Revit.DB.XYZ normal, Autodesk.Revit.DB.XYZ origin)
      {
         // First create a Geometry.Plane which need in NewSketchPlane() method
         Plane geometryPlane = m_revit.Create.NewPlane(normal, origin);
         if (null == geometryPlane)  // assert the creation is successful
         {
            throw new Exception("Create the geometry plane failed.");
         }
         // Then create a sketch plane using the Geometry.Plane
         SketchPlane plane = SketchPlane.Create(m_familyDocument, geometryPlane);
         // throw exception if creation failed
         if (null == plane)
         {
            throw new Exception("Create the sketch plane failed.");
         }
         return plane;
      }

      #endregion

   }
}

It works fine with no errors or worning but the dimension doesn't appear in the view !!!

I need anyone to try it and tell me the result.

Re: GetEndPointReference() Returns invalid operation

Anonymous — Wed, 29 Jun 2016 14:24:31 GMT

I think I know whats the problem. Your inner loop goes over

foreach (Line curve in array)

You will not find any Line. You created arcs. Did you check if you actually get into the inner loop?

Otherwise:

Did you check if you have dimension lines in the sketch view. Click the Sweep -> Edit Sweep -> Edit Profile. Now you should see something. The dimensions in the view (outside the sketch) have to get created in a different way. At least my experience so far.

I attached 3 images for hopefully better understanding.

regards

Christian

Re: GetEndPointReference() Returns invalid operation

Anonymous — Thu, 07 Jul 2016 08:21:28 GMT

Dear Mustafa

The dimensions are inside the sketch itself. That is what I am looking for.

Thanks for the code. Really helpful.

Unfortunatelly when I try to run your code I get a "Line too short" reply from Revit.

I am working on it. I hope to solve it. I will let you know As soon as I get to the solution.

regards

Jose Ignacio Montes

Re: GetEndPointReference() Returns invalid operation

Anonymous — Fri, 08 Jul 2016 07:33:23 GMT

Hi Mustafa.

Thank you very much for the code. The dimensions are inside the sketch, that is just what I wanted!

It helped me a lot to clarify. Also chhadidg73's answer with the trick was a great help.

The trick is clear. You have to delete the scketch and retrieve it from the deleted ids. I have to say that It is very dirty ideed. Anyway, it works.

For clarifications I had some issues that I want to point out.

In your code I don't know why but the arcs forming the profile gave me a Revit small line warning. I changed them to a triangle and worked.

Also there are some things to take care of for any one interested in reusing it:

You are only dimensioning the first modelline inside the Deleted elements once an over again. Because you retrieve the Modellines inside:

List<ModelLine> mArcs = new List<ModelLine>();

and get them at the line: mArcs.Add(ele as ModelLine);

But when dimensioning you loop through the sketch again:

foreach (CurveArray array in sketch.Profile)
{

foreach (Line curve in array)
{

And when dimensioning you allways take the first line (marked in red):

Reference r1 = mArcs[0].GeometryCurve.GetEndPointReference(0);
refArray.Append(r1);
Reference r2 = mArcs[0].GeometryCurve.GetEndPointReference(1);
refArray.Append(r2);

Of course it works because the sweep path has only one segment, so its allways the first [0].

When deleting elements, the retrieved Ids are first the modellines for the segments of the Path and then those of the profile.

So it has to be a little bit more complex if you want to dimension only the path (with more than one segment), the profile or both of them.

also you are using the active view to draw the dimension so when getting to the profile it will fail. Yo need to refer to the profile sketch plane to do that.

Also you are suposing that the active view is always the floor plan if its not it also will fail.

Hope this clarifies. I dont have time to rearrange the code but if someone needs, I'll do it.

Regards, and thanks again to both of you!

Re: GetEndPointReference() Returns invalid operation

Mustafa.Salaheldin — Mon, 11 Jul 2016 07:06:05 GMT

Ok the loop was the reason. Now my code is working fine.

For putting the dimensions on the view I got the reference of both planar faces of the solid then use the references to put the dimensions.