topic Re: collect all room in leve xx in Revit API Forum

collect all room in leve xx

sonicer — Fri, 10 Mar 2017 12:36:13 GMT

How can I collect all rooms in level 01...a then do somethin with this rooms?

i used coolectelement filter....no idea how to get....have somebody complet source code....

I can do that in dynamo ...now I want do that in c# ....c# beginner programmer...

code for revit 2016 api or revit 2017 api.

thx.

Re: collect all room in leve xx

MarryTookMyCoffe — Fri, 10 Mar 2017 14:43:39 GMT

you have problem because you can't collect Rooms, you need collect SpatialElement.

        public List<Room> getRoomFromLevel(Document document, Level level)
        {
            
            List<Element> Rooms = new FilteredElementCollector(document).OfClass(typeof(SpatialElement)).WhereElementIsNotElementType().Where(room => room.GetType() == typeof(Room)).ToList();

            return new List<Room>(Rooms.Where(room => document.GetElement(room.LevelId) == level).Select(r => r as Room));
        }

Re: collect all room in leve xx

sonicer — Fri, 10 Mar 2017 17:52:10 GMT

sorry don't work..

it does!nt know "Where.()..."and new List<room>

Re: collect all room in leve xx

jeremytammik — Fri, 10 Mar 2017 18:20:15 GMT

Very good solution!

Thank you!

'Where' and 'List<>' come from the System.Collections.Generic namespace.

Here are some further small improvements:

      return new FilteredElementCollector( doc )
        .WhereElementIsNotElementType()
        .OfClass( typeof( SpatialElement ) )
        .Where( e => e.GetType() == typeof( Room ) )
        .Where( e => e.LevelId.IntegerValue.Equals( 
          idLevel.IntegerValue ) )
        .Cast<Room>();

More efficient because of:

Elimination of ToList()
Elimination of New List<>()
Elimination of doc.GetElement()

You can see how to compile it in The Building Coder samples:

https://github.com/jeremytammik/the_building_coder_samples/compare/2017.0.132.7...2017.0.132.8

Cheers,

Jeremy

Re: collect all room in leve xx

sonicer — Fri, 10 Mar 2017 22:10:32 GMT

wou thx Tammik your code work for me....But I want know how to use the first code?I make some change

List<Element> Rooms = new FilteredElementCollector(doc).OfClass(typeof(SpatialElement)).WhereElementIsNotElementType().Where(room => room.GetType() == typeof(Room)).ToList();

List<Room> Rooms1 = new List<Room>(Rooms.Where(room => doc.GetElement(room.LevelId) == level).Select(r => r as Room));

I know the level 01 have id =355....why can I use 355 instead of "level"??? Or make some other mistake? Levelid is string, integer ??

In your code I inserted value 355 instead of idLevel.IntegerValue ...this work.

Re: collect all room in leve xx

MarryTookMyCoffe — Fri, 10 Mar 2017 23:20:48 GMT

level.levelId is type ElementId and you can use integervalue if you what have (int) or toString and then you gonna have string.

I suggest using Jeremy code, don't focus much on code that I write in one minute.

by the way thanks jeremy for improving it. It look much better in one lane.

Re: collect all room in leve xx

sonicer — Sat, 11 Mar 2017 11:07:05 GMT

thx ...much

this is some funny 😄 its not element type and then is typ of spacial element and type of room....not so much logical.....

WhereElementIsNotElementType()
        .OfClass( typeof( SpatialElement ) )
        .Where( e => e.GetType() == typeof( Room )

Re: collect all room in leve xx

jeremytammik — Sat, 11 Mar 2017 14:14:13 GMT

http://thebuildingcoder.typepad.com/blog/2010/08/filtering-for-a-nonnative-class.html

Look at the remarks on the ElementClassFilter Class:

http://www.revitapidocs.com/2017/4b7fb6d7-cb9c-d556-56fc-003a0b8a51b7.htm

Re: collect all room in leve xx

jeremytammik — Tue, 14 Mar 2017 20:43:44 GMT

I summarised this discussion on The Building Coder for legibility and future reference:

http://thebuildingcoder.typepad.com/blog/2017/03/events-uv-coordinates-and-rooms-on-level.html#6

Cheers,

Jeremy

Re: collect all room in leve xx

greg7KTAR — Thu, 11 Mar 2021 09:28:48 GMT

Jeremy:

Can you please explain what is the variable e in your reply? It was not used in the example you corrected. Does it need to be defined as the selected element?

Re: collect all room in leve xx

jeremy_tammik — Thu, 11 Mar 2021 09:33:58 GMT

I see no variable `e` except within the LINQ query expressions, so I do not understand your question.

Re: collect all room in leve xx

rhanzlick — Mon, 07 Jun 2021 16:02:54 GMT

hi Greg, the 'e' in his code is used for LINQ/Lambda expressions. It is a sort of abbreviated (and in most cases preferred IMO) 'foreach loop notation'. The logic is you are assigning an arbitrary variable name (in this case e) to each item in the enumerable on which you are using the expression, ultimately applying some function to each item. GoogleSearch can provide much nicer additional examples and explanations than I could. Additionally, I believe the BuildingCoder also has a few nice articles that discuss the topic.

Re: collect all room in leve xx

rhanzlick — Wed, 09 Jun 2021 14:05:02 GMT

I realize the API has very likely been updated since this OP, but I find the addition of .OfCategory(BuiltinCategory.OST_Rooms) in lieu of the oftype filters.

Re: collect all room in leve xx

jeremy_tammik — Wed, 09 Jun 2021 16:41:40 GMT

Oh yes! Thank you for the pointer. OfCategory is much better, being a fast filter, rather than post-processing with .NET Where, which is not a filter at all, and hence much, much less performant.