topic Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve in Revit API Forum

Properties Dialog doesnt accept input when commit transaction durig Idle event

boostyourbim — Sun, 11 Feb 2018 14:34:41 GMT

This idling event is registered on startup. As expected, it sets the active view's Title on Sheet when Revit goes idle. (this is just a test case, my real application does other things)

The problems as shown in the screencast is that it is now impossible to use the Revit Properties Dialog. When I try to type text input (like to change the height of the wall) Revit does not accept the input. When I try to select from a drop-down list, the list does not function properly.

How can I modify the document on Idle and also have the Properties Dialog continue to work?

        public Autodesk.Revit.UI.Result OnStartup(UIControlledApplication application)
        {
            application.Idling += Application_Idling;
        }

        private void Application_Idling(object sender, IdlingEventArgs e)
        {
            UIApplication uiapp = sender as UIApplication;
            Document doc = uiapp.ActiveUIDocument.Document;

            using (Transaction t = new Transaction(doc, "set date"))
            {
                t.Start();
                doc.ActiveView.LookupParameter("Title on Sheet").Set(DateTime.Now.ToString());
                t.Commit();
            }           
        }

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

boostyourbim — Mon, 12 Feb 2018 20:39:17 GMT

Screencast at https://knowledge.autodesk.com/community/screencast/87c8e255-2670-4f67-9743-0e2c786b1f9b

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

Revitalizer — Tue, 13 Feb 2018 08:54:28 GMT

Hi Harry,

may it be that there are lots of "set date" transactions in the undo stack?

OnIdling event is fired often, you may see the displayed seconds changing.

I think it is a timing problem.

Your manual transaction is made invalid by the onIdling transaction, it just overtakes you when typing your manual input.

So what about integrating a delay?

Also, if your timestamp could be rounded to minutes, you could compare the previous value with the new one and only set the parameter if there is a difference, omitting unnecessary transactions.

Revitalizer

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

boostyourbim — Tue, 13 Feb 2018 13:39:54 GMT

Hi - I don't understand the idea that "Your manual transaction is made invalid by the onIdling transaction"? What is the "onIdling transaction"? If I remove the transaction start & commit from my code there is an error "Attempt to modify the model outside of transaction." Autodesk's documentation says:

"Handlers of this event are permitted to make modifications to any document (including the active document)...In order to change a document, you must begin a new transaction for that document"

In any case, my example of setting this parameter is for testing & demonstration purposes. I do need to commit a transaction every time Revit goes idle and it seems like an Autodesk bug that the Properties Dialog in unusable in this situation.

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

Revitalizer — Tue, 13 Feb 2018 14:01:46 GMT

Hi again,

what I wanted to say is:

Each entry in the undo stack represents a transaction, either done by the user or by code.

If you change a parameter manually, the transaction is committed when you press the Apply button or when you move your mouse pointer from property sheet to a view.

That manual movement for committing may take some time.

The transaction in the Application_Idling event (the "onIdling" transaction), on the other hand, will be committed much faster: when Revit executes the t.Commit(), that means nearly instantly.

It's just a man versus machine thing, your code is faster than you.

Your changes are never committed.

Revitalizer

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

boostyourbim — Tue, 13 Feb 2018 17:14:51 GMT

So any time an Idling transaction is committed, Revit is going to "reset" the Properties dialog to its last state and any in-progress entry will be lost.

So if I am changing the value of an instance parameter from "hello" to "goodbye" and I've typed "good" and then the idle event triggers and commits its transaction, Revit will reset the text box value to "hello".

If that's the reality, then a solution could be to know if the Properties dialog has focus and, if it does, do not run the idling event code. Is there a Revit event that fires when the Properties dialog gets focus? Or use Windows Automation API?

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

Revitalizer — Wed, 14 Feb 2018 09:53:44 GMT

Hi Harry,

afaik, there is no such event.

For the Sheet's title, would it be sufficient if the TimeStamp is set only

when a user opens the Sheet?
when the file is about to be saved/synchronized?

In the first case, you could use UIControlledApplication.ViewActivated - if the ViewActivatedEventArgs.CurrentActiveView is your Sheet, update the TimeStamp.

I don't see a reason for a continuous update - it fills the undo history with a lot of transactions, making it difficult for the user to rollback any other transaction.

Revitalizer

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

Anonymous — Tue, 27 Feb 2018 16:36:25 GMT

Hi Harry,

Couple thoughts on this issue.

1. If you can, have you tried moving this code into an external event and raising it from the idling event? (if it's not already pending)

2. Could you potentially (additionally) implement a delay counter? (would allow you to tune the frequency with which the event is raised from the idling event)

-Ken

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

boostyourbim — Tue, 27 Feb 2018 17:00:43 GMT

Thanks Ken. Have already done #2. Will consider trying #1.

Re: Properties Dialog doesnt accept input when commit transaction durig Idle eve

jeremytammik — Tue, 27 Feb 2018 19:42:13 GMT

Thanks very much to Revitalizer and Ken for their insightful advice.

Just for your information (and my own forgetfulnes -- hhrrrmm, tracking), this issue has also been reported in ADN case 13899743 [Conflict between Idle event and Properties Palette in Revit].

I agree with the analysis discussed above and would suggest using an external event if possible.

In fact, I suggest ALWAYS using an external event rather than an Idling event, if possible:

http://thebuildingcoder.typepad.com/blog/about-the-author.html#5.28

Especially -- Replacing an Idling Event Handler by an External Event:

http://thebuildingcoder.typepad.com/blog/2013/12/replacing-an-idling-event-handler-by-an-external-event.html

Cheers,

Jeremy