topic Re: NewDimension to line in extrusion sketch fails if extrusion has been moved in Revit API Forum

NewDimension to line in extrusion sketch fails if extrusion has been moved

boostyourbim — Thu, 03 May 2018 13:30:00 GMT

Create a new extrusion in a family. Run this macro. Dimensions are created successfully.

Move the extrusion. Run this macro. NewDimension throws exception (Invalid number of references).

Looks like a bug. What is wrong with the reference to the curve endpoint after the extrusion has been moved?

        public void dim()
        {
            Document doc = this.Document;
            
            ReferencePlane plane = new FilteredElementCollector(doc)
                .OfClass(typeof(ReferencePlane))
                .Cast<ReferencePlane>()
                .Where(q => q.Name == "Center (Left/Right)")
                .FirstOrDefault();

            List<string> success = new List<string>();
            using (Transaction t = new Transaction(doc, "Dimension"))
            {            
                t.Start();
                foreach (Extrusion extrusion in new FilteredElementCollector(doc).OfClass(typeof(Extrusion)).Cast<Extrusion>())
                {
                    foreach (CurveArray ca in extrusion.Sketch.Profile)
                    {
                        foreach (Curve c in ca)
                        {                
                            Line line = c as Line;
                            if (line.Direction.IsAlmostEqualTo(XYZ.BasisY) || line.Direction.IsAlmostEqualTo(XYZ.BasisY.Negate()))
                            {
                                Dimension d2 = makeDim(doc, doc.ActiveView, c.GetEndPoint(0), plane.GetPlane(), plane.GetReference(), c.Reference);
                                if (d2 != null)
                                {
                                    success.Add(extrusion.Id.IntegerValue.ToString());
                                }
                            }
                        }
                    }    
                }
                t.Commit();
            }
            TaskDialog.Show("success", string.Join(",", success));
        }
        
        private Dimension makeDim(Document doc, View view, XYZ pt1, Plane plane, Reference r1, Reference r2)
        {
            ReferenceArray ra = new ReferenceArray();
            ra.Append(r1);
            ra.Append(r2);
            Line dimLine = Line.CreateBound(pt1, ProjectOnto( plane, pt1));

            try
            {
                
                Dimension dim = doc.FamilyCreate.NewDimension(view,
                                        dimLine,
                                        ra);
                return dim;
            }
            catch (Exception ex)
            {
                string message = ex.Message;
                TaskDialog.Show("Exception", message);
            }
            return null;
        }
        
        public static XYZ ProjectOnto(Plane plane, XYZ p)
        {
            double d = SignedDistanceTo(plane, p);
            if (d == 0)
                return p;
            XYZ q = p - d * plane.Normal;
            return q;
        }

        private static double SignedDistanceTo(Plane plane, XYZ p)
        {
            XYZ v = p - plane.Origin;
            return plane.Normal.DotProduct(v);
        }

Re: NewDimension to line in extrusion sketch fails if extrusion has been moved

boostyourbim — Thu, 03 May 2018 13:30:50 GMT

Screencast at https://knowledge.autodesk.com/community/screencast/a0e66ac6-a20e-4e8d-8671-c9e4067393f1

Re: NewDimension to line in extrusion sketch fails if extrusion has been moved

FAIR59 — Fri, 04 May 2018 09:18:42 GMT

Revit is ofcourse a bit of a black box, but I think that when you move the extrusion, the references of the profile don't get updated. The profile is a derivative of the actual model lines that define the extrusion. I find that using the geometry of the modellines works ok. You can find the modelline from the reference .

                  if (line.Direction.IsAlmostEqualTo(XYZ.BasisY) || line.Direction.IsAlmostEqualTo(XYZ.BasisY.Negate()))
                  {
                      ModelCurve mc = doc.GetElement(line.Reference.ElementId) as ModelCurve;
 
                      if (mc==null) continue;
                      try{
                          Reference r =mc.GeometryCurve.Reference; 
                          if (r==null)  continue;
                               
                           Dimension d2 = makeDim(doc, doc.ActiveView, c.GetEndPoint(0), plane.GetPlane(), plane.GetReference(), r);
                          if (d2 != null)
                          {
                              success.Add(extrusion.Id.IntegerValue.ToString());
                          }
                      }    
                      catch(Exception ex)
                      {
                      }
                  }