Why is PickObjects with Selection filter slows down my selection

johna — Thu, 07 Feb 2019 19:27:33 GMT

Why is PickOjects with Selection Filter slower than the PickObjects with out Selection Filter in IExternalCommand(Add-in). I try inputting code inside Revit Macro and see no difference in both methods.

My code is working fine(Please see below) The Only difference is the performance. PickObjects with Selection Filter feels a little slower and laggy.

Should i write my code differently? maybe my IselectionFilter is not a good write?

any help, comments, suggestion will greatly appreciated.

#region Namespaces
using System;
using System.Collections.Generic;
using System.Diagnostics;
using Autodesk.Revit.ApplicationServices;
using Autodesk.Revit.Attributes;
using Autodesk.Revit.DB;
using Autodesk.Revit.UI;
using Autodesk.Revit.UI.Selection;
#endregion

namespace ConduitSizeShowInfo
{
    [Transaction(TransactionMode.Manual)]
    public class Command : IExternalCommand
    {
        public Result Execute(
          ExternalCommandData commandData,
          ref string message,
          ElementSet elements)
        {
            UIApplication uiapp = commandData.Application;
            UIDocument uidoc = uiapp.ActiveUIDocument;
            Application app = uiapp.Application;
            Document doc = uidoc.Document;

            try
            {
                //Filter Selection
                SelectElementsFilter conduitFilter = new SelectElementsFilter("Conduits");

                //Pick Multiple Conduits
                IList<Reference> selectedConduits = uidoc.Selection.PickObjects(ObjectType.Element, conduitFilter, "Please select conduits");

                //Show Conduit Size Information
                string showConduitSize = "";
                foreach (Reference conduit in selectedConduits)
                {
                    Element e = doc.GetElement(conduit);
                    Parameter conduitSize = e.LookupParameter("Size");
                    showConduitSize += e.Name + ": " + conduitSize.AsString() + Environment.NewLine;
                }
                TaskDialog.Show("Conduit Sizes", showConduitSize);
            }
            catch(Autodesk.Revit.Exceptions.OperationCanceledException)
            {
                return Result.Cancelled;
            }
            catch(Exception ex)
            {
                message = ex.Message;
                return Result.Failed;
            }
           
            return Result.Succeeded;
        }

        public class SelectElementsFilter : ISelectionFilter
        {
            static string CategoryName = "";

            public SelectElementsFilter(string name)
            {
                CategoryName = name;
            }

            public bool AllowElement(Element e)
            {
                if (e.Category.Name == CategoryName)
                    return true;
                return false;
            }

            public bool AllowReference(Reference r, XYZ p)
            {
                return false;
            }
        }
    }
}

Re: Why is PickObjects with Selection filter slows down my selection

JimJia — Fri, 08 Feb 2019 03:44:49 GMT

I didn't see any problematic code in your selection filter implementation, the only thing I can anticipate is the PickObjects needs more calculation time after element selection filtering, for example, it needs to check if the passed element is in valid mouse selection region, the geometry calculation may need more time.

topic Re: Why is PickObjects with Selection filter slows down my selection in Revit API Forum

Why is PickObjects with Selection filter slows down my selection

Re: Why is PickObjects with Selection filter slows down my selection