topic Re: a gap between sprinkle and pipe even connect in Revit API Forum

a gap between sprinkle and pipe even connect

1368026189 — Tue, 10 Dec 2019 03:55:23 GMT

i have to move slightly to make it show right ,like in the gif ,

but i do not want to transform anything in my code,

i s there any other way to solve?

//my new create Sprinkle
var fi = doc.Create.NewFamilyInstance(pt, fs, level, StructuralType.NonStructural);

var conSet = fi.MEPModel.ConnectorManager.Connectors;
foreach (Connector con in conSet) //Sprinkle only has one connector
{
con.ConnectTo(connector);//connector is the needed connector of my pipe 

//doc.regernerate()//does not make any difference
break;
}

return fi;

Re: a gap between sprinkle and pipe even connect

Anonymous — Tue, 10 Dec 2019 04:14:33 GMT

@1368026189

Hey, i think i can tell what is going on.

I know you do not want to transform anything in your code, but it is literally one line and since these sprinklers are not attached it should not affect anything. Connectors have to already have the same origin for ConnectTo() to work, you can guarantee that by doing something like this:

using System.Linq;

//my new create Sprinkle
var fi = doc.Create.NewFamilyInstance(pt, fs, level, StructuralType.NonStructural);

var conSprinkler = fi.MEPModel.ConnectorManager.Connectors
.OfType<Connector>()
.First(); //(optional change) you said sprinklers only have 1 connector, this is the fastest way to get it i know of.

con.Owner.Location.Move(connector.Origin - con.Origin); //this line 

con.ConnectTo(connector);//connector is the needed connector of my pipe 

//doc.Regenerate()//does not make any difference

return fi;

I would be surprised if this did not fix it.

And if these are FabricationParts there is a different function to use to connect.

Let me know, thanks,

Matt

Re: a gap between sprinkle and pipe even connect

jlpgy — Tue, 10 Dec 2019 05:44:57 GMT

Hi @Anonymous :

OfType<T>() extension method and First() extension method are all from .NET LINQ lib, which I do not think of as very fast way to fetch a connector from Revit DB.

Try

var iterator = ConnectorManager.Connectors.ForwardIterator;
if (iterator.MoveNext())
{
    var connector = iterator.Current as Connector;
}

And I do not suggest Location.Move() method. Sometimes LocationCurve elements will not be correct until I Commit the entire Transaction, even I called Document.Regenerate().

ElementTransformUtils.MoveElement()

method works much better. As far as the usage in MEP domain, MoveELement() will automatically calculate other MEPCurve elements that will following the element you have just moved.

I strongly disagree connecting connectors via ConnectTo() method.

Wanna connec a Pipe to a Sprinkler? Get a pair of face-to-face connectors, of which one is from the Pipe and the other is from Sprinkler. Make sure they are face-to-face, and parallel!

Use

Document..::..NewTransitionFitting Method

to connect these 2 connectors.

This method requires 2 parallel and face to face connectors. Actually, Revit API allows 0.1 degree inaccuracy. This method does not care if they are far away from each other. The Pipe will fit itself to meet the generation of a possible Transition fitting.

Revit will automatically decide if it's necessary to insert a Transition fitting or not.

Violently using ConnecTo() is annoying, which causes lots of protential error in the future.

Suppose today you use ConnectTo() method to connect two connectors which are not strictly at the same point (maybe 1mm far away from each other), or not strictly parallel to each other.

In the future, you might wanna check if Pipes and Elbows, Tees are "correctly" connected. In this case, you might wanna check if the Connector.Origin are at the same X,Y,Z point? You also might wanna check if 2 connectors are parallel to each other. Then what? You have to face lots of ridiculous errors, which are caused by abuse using ConnectTo() method.

Last but not least, I mean no offence to no one! We have run into such issues for hundreds of times while testing our product in some RVT documents generated by some other company's products, which contains countless above-mentioned errors.!

Nice working day. Let's make all MEP developers' life easier.

Re: a gap between sprinkle and pipe even connect

1368026189 — Thu, 12 Dec 2019 10:24:41 GMT

thanks a lot friend！

Re: a gap between sprinkle and pipe even connect

jlpgy — Fri, 13 Dec 2019 08:14:57 GMT

哈哈！不客气！😁