topic Re: Fixture units dont update when Addin is running in Revit API Forum

Fixture units dont update when Addin is running

nelsonhp3 — Tue, 21 Apr 2020 18:35:48 GMT

Hello,

I'm creating an addin that needs the values of Fixture Units for piping systems. However, when the system has an open end, the value of the Fixture Units is equal to zero in some parts.

I tried to create a subtransaction that adds cap to open ends and then deletes them (see image below). However, I realized that while adding the caps, the fixture units are not updated. How can I solve this problem?
Is there any way to update the fixture unit calculation by API?

Re: Fixture units dont update when Addin is running

RPTHOMAS108 — Tue, 21 Apr 2020 22:31:22 GMT

Have you tried calling Document.Regenerate after adding the caps and then inspecting the parameter value? Regenerate is automatically called after a transaction completes.

Re: Fixture units dont update when Addin is running

TripleM-Dev.net — Tue, 21 Apr 2020 23:04:38 GMT

Hi,

Use TransactionGroup, and inside it call the various transaction.

Commit the Transaction and don't assimilate the transactionGroup at the end.

See if this is enough to get the correct values.

If values need to be written back to the Revit Database, do it in a seperate transaction AFTER the group is ended.

See a earlier post: refresh-after-every-pickobject

- Michel

Re: Fixture units dont update when Addin is running

jeremytammik — Wed, 22 Apr 2020 08:02:19 GMT

https://thebuildingcoder.typepad.com/blog/about-the-author.html#5.33

Re: Fixture units dont update when Addin is running

nelsonhp3 — Wed, 06 May 2020 19:26:48 GMT

Thank you, it worked. This is how I made:

TransactionGroup endCapsRecall = new TransactionGroup(doc); Transaction endCaps = new Transaction(doc); endCapsRecall.Start("Transação temporaria"); endCaps.Start("Colocar os end caps"); foreach (PipingSystem ps in CollectorSystems) { if ((ps.SystemType == PipeSystemType.DomesticColdWater || ps.SystemType == PipeSystemType.DomesticHotWater) && ps.BaseEquipmentConnector != null && ps.BaseEquipmentConnector.Direction == FlowDirectionType.Out) { foreach (Element pp in ps.PipingNetwork) { if (pp is Pipe && PlumbingUtils.HasOpenConnector(doc, pp.Id)) PlumbingUtils.PlaceCapOnOpenEnds(doc, pp.Id, (pp as Pipe).PipeType.Id); } } } endCaps.Commit(); coldAndHotWaterSystems = createSectors(); endCapsRecall.RollBack();

Just a note, I can't make it work with

using (Transaction endCaps = new Transaction()) {}

Re: Fixture units dont update when Addin is running

TripleM-Dev.net — Wed, 06 May 2020 19:51:24 GMT

if I read the code correct the endcaps can all be edited in one transaction so the inner transaction would only be needed once.

I was in the understanding that each endcap needed to be edited and then read and the next and the next..

Try the code below.

using (TransactionGroup endCapsRecall = new TransactionGroup(doc)) { endCapsRecall.Start("Transação temporaria"); using (Transaction endCaps = new Transaction(doc)) { endCaps.Start("Colocar os end caps"); // If inside transaction is sufficient/works here then place it here and not inside the if statement. foreach (PipingSystem ps in CollectorSystems) { if ((ps.SystemType == PipeSystemType.DomesticColdWater || ps.SystemType == PipeSystemType.DomesticHotWater) && ps.BaseEquipmentConnector != null && ps.BaseEquipmentConnector.Direction == FlowDirectionType.Out) { foreach (Element pp in ps.PipingNetwork) { if (pp is Pipe && PlumbingUtils.HasOpenConnector(doc, pp.Id)) { //using (Transaction endCaps = new Transaction(doc)) // Transaction only needed here, but if above transaction works leave this out //{ // endCaps.Start("Colocar os end caps"); PlumbingUtils.PlaceCapOnOpenEnds(doc, pp.Id, (pp as Pipe).PipeType.Id); // endCaps.Commit(); //} } } } } endCaps.Commit(); } coldAndHotWaterSystems = createSectors(); endCapsRecall.RollBack(); }

Re: Fixture units dont update when Addin is running

nelsonhp3 — Wed, 06 May 2020 21:44:37 GMT

I don't think this is a good idea because in that case for each pipe there will be a new transaction.

Re: Fixture units dont update when Addin is running

TripleM-Dev.net — Wed, 06 May 2020 21:48:56 GMT

That's why the Transaction is commented out in the loop, and only exits outside the loop.