topic Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ? in Revit API Forum

Revit ElementTransformUtils.CopyElements returns ids of null elements ?

Anonymous — Tue, 22 Sep 2020 15:53:06 GMT

I am using the Autodesk.Revit.DB.ElementTransformUtils.CopyElements method defined here:

https://www.revitapidocs.com/2016/b22df8f6-3fa3-e177-ffa5-ba6c639fb3dc.htm

This copies an element list from a document too another document.

I surprisingly found that when I copy the elements the command runs without errors ok and returns a list of ids.

Running the snippet below you my code prints the "Element is null" in my console multiple times.

It turns out that some of the elements of those IDs are null. Looking at the IDs sequence, I found that the elements from the source model which have the same sequence with the element IDs of the destination model which are missing, are doors elements.

It seems that elements were created (that is why the "CopyElements" methods returns the Element Ids), however, those probably gets deleted. Would that be a case that all hosted elements are null from this list? If yes, how can I get their ID of the hosted copied elements?

using (Transaction tx = new Transaction(doc_Source, ("copying elements "))) { tx.Start(); CopyPasteOptions copy_paste_options = new CopyPasteOptions(); translation = new XYZ(); transform = Transform.Identity; ElementIDs_Destination=Autodesk.Revit.DB.ElementTransformUtils.CopyElements(doc_Source,ElementIDs_Source, doc_Destination, transform, copy_paste_options ); tx.Commit(); foreach(ElementId i in CopiedElementsIDs) { if (doc_Destination.GetElement(i)== null) { Debug.Print("Element is null") } }

Let me know if anyone wants more clarification or information to provide for this issue.

Any answer or similar experience will be really appreciated.

Many thanks,

Alex

Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ?

jeremytammik — Tue, 22 Sep 2020 19:01:35 GMT

I can share a different example of element ids getting nulled out, in case that provides any ideas: afaik, if an element A points to another element B by storing its element id in extensible storage, and A is copied whereas B is not, the element id in the extensible storage is nulled out.

Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ?

jeremytammik — Tue, 22 Sep 2020 19:03:48 GMT

I see no connection in your code between `ElementIDs_Destination` and `CopiedElementsIDs`...

Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ?

Anonymous — Wed, 23 Sep 2020 11:35:14 GMT

@jeremytammikmany thanks for your reply.

I am not sure what the extensive storage is and if this is relevant to my case when using the ElementTransformUtils.CopyElements method.

When I meant null elements I referred to the elements not the element IDs. To clarify my initial post, the list of elements IDs the ElementTransformUtils.CopyElements method returns have not null elements. This list is fine. However, when tying to retrieve the element by its element ID, I am getting a null element. Simply, CopyElements method return IDs which do not refer to existing elements in the document.

Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ?

Anonymous — Wed, 23 Sep 2020 11:41:34 GMT

Apologies for the confusion between `ElementIDs_Destination` and `CopiedElementsIDs`.

I wanted to make things more clear but I forgot to replace `CopiedElementsIDs` to `ElementIDs_Destination`.

See below the correct code.

When running this between two projects providing one wall and one door to the ElementIDs_Source variable, both elements are copied and both IDs are returned. However when the ID of the door (hosted element) is used to retrieve the door element, using the GetElement Method you get a null result. Weirdly, when checking the copied door, it has a different ID from the one returned from the CopyElements method.

using (Transaction tx = new Transaction(doc_Source, ("copying elements "))) { tx.Start(); CopyPasteOptions copy_paste_options = new CopyPasteOptions(); translation = new XYZ(); transform = Transform.Identity; ElementIDs_Destination=Autodesk.Revit.DB.ElementTransformUtils.CopyElements(doc_Source,ElementIDs_Source, doc_Destination, transform, copy_paste_options ); tx.Commit(); foreach(ElementId i in ElementIDs_Destination) { if (doc_Destination.GetElement(i)== null) { Debug.Print("Element is null") } }

Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ?

RPTHOMAS108 — Wed, 23 Sep 2020 14:17:24 GMT

There is not much information on how transactions should be used for this utility but I always assumed the destination document was the one you need an open transaction for as that is the document where new elements are being created. The source document is just providing items that don't change.

Whenever I've used it this has been the approach used, so try opening and committing a transaction on the destination document before iterating the list of ids. I believe this utility is leveraging copy/paste so I'm not sure if transactions are required, seems odd you've added to a document without opening a transaction for such.

Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ?

Anonymous — Wed, 23 Sep 2020 14:52:37 GMT

@RPTHOMAS108Apologies, I meant to write doc_Destination instead of doc_Source. I completely agree with your notes. You very correctly mentioned that CopyElements method needs a transaction for the destination and not the source document.

using (Transaction tx = new Transaction(doc_Destination, ("copying elements "))) { tx.Start(); CopyPasteOptions copy_paste_options = new CopyPasteOptions(); translation = new XYZ(); transform = Transform.Identity; ElementIDs_Destination=Autodesk.Revit.DB.ElementTransformUtils.CopyElements(doc_Source,ElementIDs_Source, doc_Destination, transform, copy_paste_options ); tx.Commit(); foreach(ElementId i in ElementIDs_Destination) { if (doc_Destination.GetElement(i)== null) { Debug.Print("Element is null") } }

Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ?

jeremytammik — Wed, 23 Sep 2020 14:51:54 GMT

This CopyElements sample code opens a transaction on the target document, not the source, which definitely makes more sense, just as Richard suggested:

https://thebuildingcoder.typepad.com/blog/2020/06/set-crop-to-section-box-linked-boundaries-and-intersections.html

Re: Revit ElementTransformUtils.CopyElements returns ids of null elements ?

Anonymous — Thu, 24 Sep 2020 14:28:50 GMT

To give a better understnading about the issue I will try to provide a valid rvt model with some elements failing to be read using their id when those are copied over another file. I will post here again soon.