topic Create window element in Revit API Forum

Create window element

stav1233 — Mon, 14 Feb 2022 03:50:22 GMT

Hey everyone,

I am trying to create a new window instance using

doc.Create.NewFamilyInstance(XYZ, FamilySymbol, HostElement, StructuralType.NonStructural);

After I run the command the window is created but I can’t see it on the module.

I try to lock for the reason using vlookup and I suspect the reason is the new window instance

levelid Element properties is null,

host FamilyInstance properties is null,

host face FamilyInstance properties is null,

Any suggestion?

Re: Create window element

jeremy_tammik — Mon, 14 Feb 2022 10:14:56 GMT

A newly loaded family symbol needs to be activated before it can be used:

http://thebuildingcoder.typepad.com/blog/2014/08/activate-your-family-symbol-before-using-it.html

Re: Create window element

stav1233 — Tue, 15 Feb 2022 03:06:36 GMT

I activate the family symbol but its steal not work.

any more suggestion?

Re: Create window element

jeremy_tammik — Tue, 15 Feb 2022 06:51:44 GMT

Work through the process step by step in the end user interface. Does it work as expected there?

Re: Create window element

caroline.gitonga — Tue, 15 Feb 2022 07:14:00 GMT

Hi @stav1233,

As per @jeremy_tammik response above, I have checked and solved the same issue you have using Activate Family Symbol article.
Family Symbols require to be activated for them to be loaded into the document. You should check whether the symbol is active once the transaction starts or right before the transaction commits. Once it is activated the document re/generates it and it gets loaded. If the symbol is inactive, Revit gives you this exception (attached below). See my code snippet of how you can implement the solution provide on @jeremy_tammik article.

// Find a Window type for the new windows
FilteredElementCollector winCollector = new FilteredElementCollector(document);
IList<Element> windowTypes = winCollector.OfClass(typeof(FamilySymbol)).OfCategory(BuiltInCategory.OST_Windows).WhereElementIsElementType().ToElements();
FamilySymbol winType = windowTypes.First() as FamilySymbol;

//Level level = myWall.Document.GetElement(myWall.LevelId) as Level;
//XYZ location = new XYZ(-22.6724094227806, 45.595454156592, 3.00196850393702);
double x =2 , y =2, z =2;
//inserts 3 windows
for(int i = 0; i < 3; i++)
{
XYZ location = new XYZ(x, y, z);

Transaction trans = new Transaction(document);
trans.Start("window instance");
//check whether the family symbol is active, if not activate and regenerate
if (!winType.IsActive)
{
winType.Activate();
document.Regenerate();
}

FamilyInstance instance = document.Create.NewFamilyInstance(location, winType, myWall, StructuralType.NonStructural);
x += 3;
y += 3;
trans.Commit();

}