topic Re: Memory leak when exporting images in Revit API Forum

Memory leak when exporting images

nice3point — Mon, 20 Jun 2022 11:52:19 GMT

When calling the ExportImage method, there is a large unmanaged memory spike, this memory is not cleared after the transaction is completed, and remains occupied until Revit closes. Tested versions of Revit 2021-2023

Before the call: 1.01 GB

After the call: 2.09 GB

Re: Memory leak when exporting images

jeremy_tammik — Mon, 20 Jun 2022 13:07:10 GMT

Thank you very much for your report, Roman. The development team may well be aware of this. In order to make sure, I will gladly report it to them for closer analysis. A prerequisite for that is a minimal reproducible case in order to be able to efficiently set up, test and debug the behaviour locally:

https://thebuildingcoder.typepad.com/blog/about-the-author.html#1b

Are you able to provide that? E.g., maybe an RVT containing a macro plus an image file (or a link to one) to load. Thank you!

Re: Memory leak when exporting images

nice3point — Mon, 20 Jun 2022 13:45:57 GMT

Simple example to reproduce:

- Revit version: 2023

- Project path: "C:\Program Files\Autodesk\Revit 2023\Samples\rac_basic_sample_project.rvt"

- Profiling tools: JetBrains Rider, dotMemory

Code:

var sectionType = new FilteredElementCollector(document) .WhereElementIsElementType() .OfClass(typeof(ViewFamilyType)) .Cast<ViewFamilyType>() .First(x => x.ViewFamily == ViewFamily.Section); var section = ViewSection.CreateSection(document, sectionType.Id, new BoundingBoxXYZ()); section.DisplayStyle = DisplayStyle.RealisticWithEdges; var options = new ImageExportOptions { ZoomType = ZoomFitType.FitToPage, ExportRange = ExportRange.SetOfViews, FitDirection = FitDirectionType.Vertical, PixelSize = 220, ImageResolution = ImageResolution.DPI_150, HLRandWFViewsFileType = ImageFileType.PNG, ShadowViewsFileType = ImageFileType.PNG, FilePath = Path.GetTempPath() }; options.SetViewsAndSheets(new List<ElementId> {section.Id}); document.ExportImage(options);

Re: Memory leak when exporting images

nice3point — Mon, 20 Jun 2022 13:52:24 GMT

@jeremy_tammik Installer for versions 19-23 and the solution itself. This only happens on first run. All subsequent ones run quickly and without allocating so much memory

Re: Memory leak when exporting images

jeremy_tammik — Mon, 20 Jun 2022 14:38:36 GMT

Thank you for further details and a reproducible case. From your description, I can well imagine that this behaviour is intentional. However, I submitted the ticket REVIT-193325 [doc.ExportImage memory leak] for the developers to take a closer look.

Re: Memory leak when exporting images

nice3point — Mon, 20 Jun 2022 14:43:34 GMT

I don’t know whether it was intentional or not, but I don’t want them to take a couple of gigabytes of memory from me to export an 8 kilobyte image)

Re: Memory leak when exporting images

jeremy_tammik — Mon, 20 Jun 2022 15:14:15 GMT

Yes, I understand. There may be other important considerations that we are unaware of. I added your comment to the ticket, anyway.

Re: Memory leak when exporting images

Sean_Page — Mon, 20 Jun 2022 16:12:57 GMT

Do you think this is Revit causing this, or the GetFiles method indexing files looking for matches to return?

Since you know the file path can't you just return it directly?

Re: Memory leak when exporting images

nice3point — Mon, 20 Jun 2022 17:38:33 GMT

The breakpoint does not capture this method, and I have attached a zip archive with a solution where this method does not exist at all

Re: Memory leak when exporting images

RPTHOMAS108 — Tue, 21 Jun 2022 00:19:55 GMT

Some objects such as ImageExportOptions, Document and UIApplication Inplement IDisposable.

Have you tried calling Dispose on such? Ideally you should not need to but in theory GC has no knowledge of items on the unmanaged side, the dispose method is meant to be implemented to deal with those when called (also called inherently at the end of 'using' block).

Although it would be a bit ridiculous calling Dispose on every API object we use so instead:

Object.Finalize should have also be overridden (or SafeHandle used) by the Autodesk API developers to deal with the unmanaged resources associated with a managed object prior to natural destruction of the managed part i.e. Finalize is always called prior to GC destroying the managed part (dispose isn't). So would assume something lacking in that area needs looking at and perhaps in meantime dispose could help.

Not many code samples you see would be using a 'using' block with the Document object or calling dispose after using it. So more guidance is needed in that respect if 'Dispose' is expected to be called by the developer (on which objects)? Definitely transactions that is clear but what other objects that implement IDisposable?

Re: Memory leak when exporting images

nice3point — Tue, 21 Jun 2022 13:07:02 GMT

Memory leak in the ExportImage method itself, and not when creating an object, the method returns void and I can’t influence its work in any way. Disposing ImageExportOptions does nothing

Re: Memory leak when exporting images

jeremy_tammik — Thu, 30 Jun 2022 19:20:39 GMT

Analysis completed.

REVIT-193325 [doc.ExportImage memory leak] closed as 'code fix needed'.

REVIT-193708 [doc.ExportImage memory leak] raised for critical development work.

Thank you for raising this!