topic Re: Help writting transaction correctly in Revit API Forum

Help writting transaction correctly

davidsUUGCH — Wed, 12 Oct 2022 14:36:12 GMT

The fallowing code does not compile. Gives error CS1061 which means i take means i missing something in the syntax. I have tried some stuff from this video: https://www.youtube.com/watch?v=EYdEOJ4VS8c but the error does not go away. When i moved this to Visual studio 2022 it had even more errors related to start up. So i am at a loss to what is going on.

namespace TESTMACRO6a { [Autodesk.Revit.Attributes.Transaction(Autodesk.Revit.Attributes.TransactionMode.Manual)] [Autodesk.Revit.DB.Macros.AddInId("DF08281E-D5FF-49E9-A1A9-E8B57F4F02C3")] public partial class ThisDocument { private void Module_Startup(object sender, EventArgs e) { } private void Module_Shutdown(object sender, EventArgs e) { } #region Revit Macros generated code private void InternalStartup() { this.Startup += new System.EventHandler(Module_Startup); this.Shutdown += new System.EventHandler(Module_Shutdown); } #endregion public Result Execute(ExternalCommandData commandData, ref string message, ElementSet elements) { UIDocument uidoc = this; View view = uidoc.ActiveView; //collect and set parameter. FilteredElementCollector collector = new FilteredElementCollector(uidoc.Document) .OfClass(typeof(ViewSheet)) .WhereElementIsNotElementType(); foreach(Element e in collector) { foreach (Parameter p in e.Parameters) { if(p.Definition.Name=="CentralLocation") { //Start transaction using (Transaction t = new Transaction(uidoc.Document,"Place family Instance")) { t.Start(); //SetParameter p.Set("CentralSTRG"); t.commit(); } } } }} } }

Any help is appreciated.

Re: Help writting transaction correctly

moturi.magati.george — Wed, 12 Oct 2022 15:34:40 GMT

Hi @davidsUUGCH ,

Try replacing your 26 with

var uiapp = commandData.Application;
var uidoc= uiapp.ActiveUIDocument;

also try to replace line 47 with

t.Commit();

For more information about creating your first Revit plugin kindly check the link below

https://knowledge.autodesk.com/search-result/caas/simplecontent/content/lesson-1-the-basic-plug.html

Re: Help writting transaction correctly

davidsUUGCH — Wed, 12 Oct 2022 16:53:15 GMT

Thanks this solved the previews issue. However now it says there is an error on line 24

private Result Execute(ExternalCommandData commandData, ref string message, ElementSet elements)

This gives me :

Error CS0161: 'TESTMACRO6a.ThisDocument.Execute(Autodesk.Revit.UI.ExternalCommandData, ref string, Autodesk.Revit.DB.ElementSet)': not all code paths return a value

Re: Help writting transaction correctly

davidsUUGCH — Wed, 12 Oct 2022 22:03:59 GMT

Never mind changed the code back to be just a macro this seemed to clear the error.

internal void USERNAMETOX () { UIDocument uidoc = this; View view = uidoc.ActiveView;

This where the changes.