topic Unicode wcscpy_t problem in ObjectARX Forum

Unicode wcscpy_t problem

Anonymous — Thu, 17 Sep 2015 07:08:21 GMT

I've finished migrating my software to Unicode requirements, however I do have one issue for which I have searched at length but yet to find a solution.

The following code:

wcscpy_s (module_layer_objects_res_buf.resval.rstring, module_objects_layer);

yeilds the following compile error:

error C2660: 'wcscpy_s' : function does not take 2 arguments

Firstly, 'wcscpy_s' does in fact take two arguments. I works elswhere in my code just fine, so it's not clear just why the compiler (vs2012) produces this error code.

Secondly, It seems to me this a Unicode issue since the code listed above compiled just fine in vs2002 (non-unicode) using the 'srtcpy' finction where both arguments were 'char' data types.

Thirdly, I expected 'wcscpy_s' to work fine in the Unicode environment where both arguments are the same data type - ACHAR in the union 'rstring', and wchar_t for 'module_objects_layer.' But no, 'wcscpy_s failed in this case.

So, does anyone have an insight to what's going on here? Any help appreciated.

Brian (aka, manybeans)

Re: Unicode wcscpy_t problem

Anonymous — Thu, 17 Sep 2015 08:11:51 GMT

Maybe the compiler thinks this is a C, and not a C++ file? See:

https://msdn.microsoft.com/de-de/library/td1esda9.aspx

Re: Unicode wcscpy_t problem

owenwengerd — Thu, 17 Sep 2015 10:46:11 GMT

There are several overloads of wcscpy_s. Usually the compiler can infer the buffer size from the arguments to the function, but if it cannot, then you must supply the buffer size argument.

Re: Unicode wcscpy_t problem

nick83 — Thu, 17 Sep 2015 11:15:58 GMT

"_tcscpy"

Re: Unicode wcscpy_t problem

Anonymous — Fri, 18 Sep 2015 08:41:26 GMT

All -

Thanks all for your insights and suggestions. However still no solution to the wcscpy_t problem. I'm not sure this is an overload issue since wcscpy_t takes two arguments and my wcscpy_t statement is a two argument statement. Also tried the various cpy forms, including _tcspy. These produce a compile error stating they may be unsafe and to try wcscpy_t instead.

Note that I have numerous statements in my code where wcscpy_t works just fine copying from the resbuf (general_layer_name is a resbuf) to a variable, which is just the reverse of my problem statement.

In other words this statement builds just fine:

wcscpy_s (layer_name_buffer, general_layer_name.resval.rstring);

where my problem statement does not:

wcscpy_s (general_layer_name.resval.rstring, layer_name_buffer);

As I mentioned before, my problem statement here built just fine in the Visiual Studio 2002 C++ compiler using ObjectARX 2004. ObjectARX 2004 is pre Unicode.

Ok. So that's about all the info I have so far. Just as general info, my application is about 107,000 lines in C++/ObjectARX 2012. It builds error/warning free, except for my one problem statement.

Any further thoughts will be appreciated.

Brian (aka, manybeans)

Re: Unicode wcscpy_t problem

owenwengerd — Fri, 18 Sep 2015 19:53:17 GMT

@Anonymous wrote:

I'm not sure this is an overload issue since wcscpy_t takes two arguments and my wcscpy_t statement is a two argument statement.

Folks at stack overflow are more likely to take time to explain what you're doing wrong. I recommend to post there to see if someone can help.

Re: Unicode wcscpy_t problem

nick83 — Mon, 21 Sep 2015 07:32:21 GMT

))) what about reading MSDN help?

wcscpy_s (layer_name_buffer, general_layer_name.resval.rstring); - works fine because your layer_name_buffer is declared like ACHAR layer_name_buffer[50];

lines from MSDN

errno_t wcscpy_s(
   wchar_t (&strDestination)[size],
   const wchar_t *strSource 
); // C++ only

BUT if you want wcscpy_s (general_layer_name.resval.rstring, layer_name_buffer); you have to use

errno_t wcscpy_s(
   wchar_t *strDestination,
   size_t numberOfElements,
   const wchar_t *strSource 
);

because general_layer_name.resval.rstring is ACHAR*

PS: try to use acutUpdString(general_layer_name.resval.rstring, layer_name_buffer); for modifying resbuf string data

Re: Unicode wcscpy_t problem

Anonymous — Tue, 22 Sep 2015 07:52:13 GMT

Hi nick83,

Very nice. I see then that wcscpy_s takes an overload that defines the rstring buffer size. And it works just fine. Thanks for the info.

I searched the ObjectARX 2007 Unicode migration guide for wcscpy_s but found no info on overloads. Maybe it's really there but I just missed it.

In any case I had not been to Microsoft yet on any Unicode issues. I don't have a MSDN subscription, but I did as you suggested and searched for wcscpy_s. Sure enough it came up with exactly the information you listed, and much more too. Thanks for the heads up there.

manybeans

Re: Unicode wcscpy_t problem

nick83 — Tue, 22 Sep 2015 09:01:49 GMT

i dont have MSDN subscription, too :), but i have a computer with internet 🙂
i looked through my code, and found an old ObjectARX function for setting data to resbuf's string field - "acutUpdString". so, i changed nothing for unicode and forgot about this function. the rest of my code is just gets data from resbuf, so, _tcscmp is enough for me.