topic Re: Autocad crash when transaction ends in .NET Forum

Autocad crash when transaction ends

Anonymous — Thu, 23 Apr 2020 15:56:14 GMT

Hi,

I would like to create a dynamic legends so I wrote some handler for:

Database.ObjectAppended
Database.ObjectErased
Database.ObjectModified
Database.ObjectReappended
Database.ObjectUnappended

In my test case I erase an object (manually) (so I pass in Database.ObjectErased ) and do an undo then

I pass in Database.ObjectErased for the second time.

My functions are called:

/// <summary> /// Test si le xrecord existe /// </summary> /// <param name="objid">Objet contenant le xrecord</param> /// <param name="tag">tag du xrecord</param> /// <param name="xData">data du xrecord</param> /// <returns></returns> static protected internal bool hasXRecord(ObjectId objid, string tag, object xData) { bool bRet = false; Document doc = Application.DocumentManager.MdiActiveDocument; using (Transaction acTrans = doc.TransactionManager.StartTransaction()) { DBObject pObj = objid.GetObject(OpenMode.ForRead); if (!pObj.ExtensionDictionary.IsNull) { DBDictionary xDict = pObj.ExtensionDictionary.GetObject(OpenMode.ForRead) as DBDictionary; if(xDict.Contains(tag)) { Xrecord rec = xDict.GetAt(tag).GetObject(OpenMode.ForRead) as Xrecord; bRet = rec.Data.AsArray()[0].Value.Equals(xData); } } } return bRet; } /// <summary> /// Recherche bloc avec un xrecord spécifique /// </summary> /// <param name="tag">tag xrecord</param> /// <param name="xData">valeur xrecord</param> /// <returns></returns> static protected internal BlockTableRecord findBlockRecord(string tag, object xData) { BlockTableRecord bloc = null; Document doc = Application.DocumentManager.MdiActiveDocument; Database db = doc.Database; using (Transaction acTrans = doc.TransactionManager.StartTransaction()) { BlockTable blocTable = db.BlockTableId.GetObject(OpenMode.ForRead) as BlockTable; foreach(ObjectId blocId in blocTable) { if(hasXRecord(blocId, tag, xData)) { bloc = blocId.GetObject(OpenMode.ForRead) as BlockTableRecord; break; } } } return bloc; }

for each Database.ObjectErased but the second Database.ObjectErased (= with undo) cause a kind of deadlock in the end of transaction in function hasXRecord.

I have to use transaction if I want open the objectid.

It'is a BUG or what I'm doing wrong?

thanks

Re: Autocad crash when transaction ends

_gile — Thu, 23 Apr 2020 18:56:42 GMT

Hi,

I don't quite understand the relationship between erasing an object and then canceling the operation and the posted code.
Regarding the posted code, the 'findBlockRecord' method should not return an instance of BlockTableRecord (or of any DBOject) that has been opened in a disposed transaction (the BlockTableRecord has also been disposed), the method should return an ObjectId. And the 'hasXRecord' method does not need to start a new nested transaction, we can very well pass the top transaction as an argument to it.

static bool HasXRecord(Transaction tr, DBObject dbObject, string key, object dataValue) { if (dbObject.ExtensionDictionary.IsNull) return false; var xDict = (DBDictionary)dbObject.ExtensionDictionary.GetObject(OpenMode.ForRead); if (!xDict.Contains(key)) return false; var xrec = (Xrecord)xDict.GetAt(key).GetObject(OpenMode.ForRead); return xrec.Data.AsArray()[0].Value.Equals(dataValue); } static ObjectId FindBlockRecord(Database db, string key, object dataValue) { using (var tr = db.TransactionManager.StartOpenCloseTransaction()) { var bt = (BlockTable)tr.GetObject(db.BlockTableId, OpenMode.ForRead); return bt.Cast<ObjectId>() .FirstOrDefault(id => HasXRecord(tr, tr.GetObject(id, OpenMode.ForRead), key, dataValue)); } }

Re: Autocad crash when transaction ends

Anonymous — Sun, 26 Apr 2020 16:42:23 GMT

"I don't quite understand the relationship between erasing an object and then canceling the operation and the posted code"

Delete object and undo deletetion both call Database.ObjectErased. In fact is not a problem.

"the method should return an ObjectId"

I agree and I correct my method (even it's weird to use transactions to open object but I have to).

But the crash already exists.

I can avoid this crash by calling an legend update command via sendStringToExecute (same code is executed).

BUT I have another problem if legend update command is executed my selection is automatically cleared.

Re: Autocad crash when transaction ends

_gile — Sun, 26 Apr 2020 17:08:49 GMT

Sorry, I still do not understand your issue (maybe due to my English).

You should post a usable code and a detailed description of the circonsatances the error occurs so that we can reproduce it.

Re: Autocad crash when transaction ends

Anonymous — Sun, 26 Apr 2020 19:26:16 GMT

My english is also horrible.

I think my problem is due to executed commands:

The command undo is still running when my code is executed.

I finally avoid the crash and the selection clearing problem by this code:

static void legendCallback(object sender, ObjectErasedEventArgs e) { DBObject objTeated = e.DBObject; if (objTeated != null) { if (!PICLegendZoneCmd.UPDATE_MUTEX)// mutex MAJ { Document doc = Application.DocumentManager.MdiActiveDocument; if ((objTeated.GetType() == typeof(MgPICZone)) || (objTeated.GetType() == typeof(MgPICWay))) { string names = Application.GetSystemVariable("CMDNAMES") as string; if (names.Length > 0) { PICLegendZoneCmd.UPDATE_MUTEX = true; // moyen de contourner un crash (BUG AUTOCAD!?) qd fin transaction => CRADO Application.DocumentManager.MdiActiveDocument.SendStringToExecute("PICUpdateLegendZone\n", true, false, true); } else { // pas de commande ?= pas de crash mais lancer une commande d'update ou plus généralement une commande // effacera la sélection à la fin PICLegendZoneCmd.updateLegendZone(); } } } } }

/// <summary> /// Commande de mise à jour des légendes de zone /// </summary> [CommandMethod("PIC", "PICUpdateLegendZone", "PICUpdateLegendZoneLocal", CommandFlags.Transparent | CommandFlags.UsePickSet | CommandFlags.NoUndoMarker | CommandFlags.NoInferConstraint)] public void updateLegendZoneCmd() { PICLegendZoneCmd.UPDATE_MUTEX = false; PICLegendZoneCmd.updateLegendZone(); }