topic Re: inventor 2016 - 2018 issues in Inventor Programming Forum

inventor 2016 - 2018 issues

m.maertens6DTZT — Fri, 09 Mar 2018 14:48:57 GMT

Hi all,

I'm here again with an issue during updating my inventor to 2018

We're using a module in the VBA that allows us to automaticly 'makeAllFreeAndPromote" an assembly when you drag and drop this.

In 2016 this works perfect, in 2018 not.

Let me explain what I want to do:

1. drag and drop an assembly from our library in my project (on toplevel)

2. explode this imported assembly into the separate parts and delete the imported assembly.

In 2018 this happens:

1. Drag and drop the assembly works fine

2. explode the assembly into separate parts works fine

3. Delete the imported assembly doesn't works anymore.

Please help me out how I can fix this.

Because, when I save my project - it also saves the empty assembly.

See screenshot below.

Here is the code:
Module 1 = auto make all free and promote

Sub AutoMakeAllFreePromote()
'step 1 Check if the correct Workspace is set
    Call GetFileLocation
    Dim oWorkspace As String
    oWorkspace = ThisApplication.DesignProjectManager.ActiveDesignProject.WorkspacePath
    If oWorkspace <> sDefaultRootProject Then
            Debug.Print "Rule AutoMakeAllFreePromote has been cancelled because non-default workspace has been chosen"
            Debug.Print "This is normal if you are editing beCAD"
            Exit Sub
    End If
   
'step 2 Determine the level we are one
    Dim oMainAssembly As AssemblyDocument
    Set oMainAssembly = ThisApplication.ActiveDocument

    Dim oAssembly As AssemblyDocument
    Set oAssembly = ThisApplication.ActiveEditDocument

    Dim oOcc As ComponentOccurrence
          
'step 3 select the part that has been placed & edit it
    If oMainAssembly.FullDocumentName = oAssembly.FullDocumentName Then
    'we are on the main assembly
        Set oOcc = oAssembly.ComponentDefinition.Occurrences.Item(oAssembly.ComponentDefinition.Occurrences.Count)
    Else
    'we are in a subassembly
        MsgBox "Move this assembly to the Main assembly & press 'MakeAllFreeAndPromote'. Next time place directly at top level", vbOKOnly, "Error"
        Exit Sub
        'the below doesn't work properly, to be investigated
        'Set oOcc = oMainAssembly.ComponentDefinition.Occurrences.ItemByName(oMainAssembly.ComponentDefinition.ActiveOccurrence.Name).SubOccurrences.Item(oAssembly.ComponentDefinition.Occurrences.Count)
    End If
       
    
    oOcc.Edit
    
'step 3 Call MakeAllFreeAndPromote
    MakeAlleFreeAndPromote
   
    
End Sub

Module 2 = make all free and promote

Public Sub MakeAlleFreeAndPromote()

' Create a transaction. -> for 1 undo command
Dim oTransMgr As TransactionManager
Set oTransMgr = ThisApplication.TransactionManager
Dim oTrans As Transaction
Set oTrans = oTransMgr.StartTransaction(ThisApplication.ActiveDocument, "MakeAlleFreeAndPromote")
  

' check if an iwall is selected
        Dim oDoc As AssemblyDocument
        Set oDoc = ThisApplication.ActiveDocument

        Dim oOcc As ComponentOccurrence
        On Error Resume Next
        Set oOcc = oDoc.SelectSet.Item(1)
        If Err Then
            GoTo TraverseNormally
        End If
        
        If oOcc.DefinitionDocumentType = kAssemblyDocumentObject Then
            If oOcc.ActiveLevelOfDetailRepresentation = "Wall" Then
               oOcc.Edit
            End If
        End If

'declare everything needed
TraverseNormally:
        Dim oDef As AssemblyComponentDefinition
        Set oDef = oDoc.ComponentDefinition
        
        Dim oAssDoc As AssemblyDocument
        Set oAssDoc = ThisApplication.ActiveEditObject
        Dim oActDef As AssemblyComponentDefinition
        Set oActDef = oAssDoc.ComponentDefinition
        
        Dim oPattern As OccurrencePattern
        Dim oPatternElement As OccurrencePatternElement
        Dim oOccurence As ComponentOccurrence
        Dim oComponent As ComponentOccurrence





        'Traverse all the patterns in the assembly:
        For Each oPattern In oAssDoc.ComponentDefinition.OccurrencePatterns
            'Traverse all elements in the pattern to make them independent:
            For Each oPatternElement In oPattern.OccurrencePatternElements
              '  On Error Resume Next
                oPatternElement.Independent = True
                If Err Then
                    Err.Clear
                    End If
            Next oPatternElement
        Next oPattern
        
        'Delete all patterns in the assembly
        For Each oPattern In oAssDoc.ComponentDefinition.OccurrencePatterns
            oPattern.Delete
        Next oPattern
        
        'delete all suppressed
        For Each oComponent In oAssDoc.ComponentDefinition.Occurrences
                If oComponent.Suppressed = True Then
                    oComponent.Delete
                End If
        Next oComponent
        
        'Unground all components
        For Each oOccurence In oAssDoc.ComponentDefinition.Occurrences
            If oOccurence.Grounded = True Then
                oOccurence.Grounded = False
            End If
        Next oOccurence
        
        'Delete all iComposites
        For Each oIcomp In oAssDoc.ComponentDefinition.iMateResults
         '   On Error Resume Next
            oIcomp.Delete
            If Err Then
            Err.Clear
            End If
        Next oIcomp
        
        'Delete all imates
        For Each oImate In oAssDoc.ComponentDefinition.iMateDefinitions
          '  On Error Resume Next
            oImate.Delete
            If Err Then
            Err.Clear
            End If
        Next oImate
        
        'Delete all constraints
        For Each oConstraint In oAssDoc.ComponentDefinition.Constraints
           ' On Error Resume Next
            oConstraint.Delete
            If Err Then
            Err.Clear
            End If
        Next oConstraint
            
        'Promote all frames

            ' Get the top level occurrence of an assembly
             Dim oSubAssyOcc As ComponentOccurrence
             
             
            ' On Error Resume Next
                     Set oSubAssyOcc = oDef.Occurrences.ItemByName(oDef.ActiveOccurrence.Name)
                      'If Err Then
                       '   MsgBox "A subassembly must be active if you want to promote it. No Subassembly will be touched"
                           
                   ' Else
                        Dim i As Integer
                        For i = 1 To oActDef.Occurrences.Count
                           
                        ' Get the 2nd level occurrence under the assembly occurrence
                        Dim oSubOcc As ComponentOccurrenceProxy
                        Set oSubOcc = oSubAssyOcc.SubOccurrences.Item(1)
                        
                        Dim oPane As BrowserPane
                        Set oPane = oDoc.BrowserPanes.Item("AmBrowserArrangement") '2017 11 05 - multilangue change
                        
                        ' Get the browser nodes corresponding to the two occurrences
                        Dim oTargetNode As BrowserNode
                        Set oTargetNode = oPane.GetBrowserNodeFromObject(oSubAssyOcc)
                        
                        
                        Dim oSourceNode As BrowserNode
                        Set oSourceNode = oPane.GetBrowserNodeFromObject(oSubOcc)
                        
                        
                        ' Reorder the nodes to promote the sub-occurrence to the top level
                        Call oPane.Reorder(oTargetNode, True, oSourceNode)
                        
                        Next
                        
                        ' activate one level up
                             Dim oCtrlDef As ControlDefinition
                            Set oCtrlDef = ThisApplication.CommandManager.ControlDefinitions.Item("AppReturnTopCmd")
                            oCtrlDef.Execute
                                
                        ' Delete the original Subassembly
                            oSubAssyOcc.Delete
                            oSubAssyOcc.Delete
                      'End If
             On Error GoTo 0

    
' End the transaction.
    oTrans.End
End Sub

Re: inventor 2016 - 2018 issues

chandra.shekar.g — Tue, 13 Mar 2018 06:41:03 GMT

Hello @m.maertens6DTZT,

Can you please provide Assembly with imported assembly to reproduce ?

Please make sure that files are non confidential.

Thanks and regards,

Re: inventor 2016 - 2018 issues

m.maertens6DTZT — Tue, 13 Mar 2018 06:57:07 GMT

Hello,

See enclosed the requested files.

Thanks for your help.

Re: inventor 2016 - 2018 issues

m.maertens6DTZT — Tue, 13 Mar 2018 09:12:25 GMT

Hi all,

To come back on my problem ( = not able to delete the imported assembly in an assembly)

The assembly that I want to import is triggered "After Open Document" by the rule "AutoMakeAllFreeAndPromote"

When I adapt the first script "AutomakeAllFreeAndPromote" by adding a messagebox after editoOcc. and deleting the last commando "MakeAllFreeAndPromote", then I am inside the subassembly after importing this assembly. When I then call the commando manually "MakeAllFreeAndPromote" IT WORKS!!!

But when I run this commando automatically during my first script (see step 3) - it doesn't work! Then I'm able to promote the parts to my top level, but not able to delete the empty subassembly.

I also tried to insert the commando at the last line : "oSubAssyOcc.Delete" - but then I get an error.

it seems that I'm not able to select this empty subassembly and delete it.

Who can help me to delete this?

thanks!

Re: inventor 2016 - 2018 issues

chandra.shekar.g — Tue, 13 Mar 2018 09:49:19 GMT

Hello @m.maertens6DTZT,

After promoting, try the following VBA code to delete referenced components.

Sub DeleteDerivedAssembly()
    Dim oDoc As AssemblyDocument
    Set oDoc = ThisApplication.ActiveDocument
    
    Dim oDef As AssemblyComponentDefinition
    Set oDef = oDoc.ComponentDefinition
    
    Dim occ As ComponentOccurrence
    For Each occ In oDef.Occurrences
        If occ.DefinitionDocumentType = kPartDocumentObject Then
            Dim oPartDef As PartComponentDefinition
            Set oPartDef = occ.Definition
            
            Dim oDerivedAssembly As DerivedAssemblyComponent
            For Each oDerivedAssembly In oPartDef.ReferenceComponents.DerivedAssemblyComponents
                Call oDerivedAssembly.Delete
            Next
        End If
        
    Next
End Sub

Please feel free to contact if there is any queries.

If solves problem, click on "Accept as solution" / give a "Kudo".

Thanks and regards,

Re: inventor 2016 - 2018 issues

m.maertens6DTZT — Tue, 13 Mar 2018 10:21:19 GMT

Hi,

Thanks for the code, but when I place that after promoting, then I notice that my parts are modified. This code does something with my parts.
No, what I actually want to do is
1. Import an assembly from my library. (for example a bolt-nut connection)
2. After importing, the assembly must explode so I have the parts separately on top level (must be separately for my BOM)

3. Delete the imported subassembly because it's empty

If you want, I can also make a movie to show you my actions.

I just don't understand why this worked perfectly in 2016 and not in 2018.

Re: inventor 2016 - 2018 issues

chandra.shekar.g — Tue, 13 Mar 2018 10:24:48 GMT

@m.maertens6DTZT,

Video is better to demonstrate.

Thanks and regards,

Re: inventor 2016 - 2018 issues

m.maertens6DTZT — Tue, 13 Mar 2018 11:36:22 GMT

Hi,

I've made 3 video's:

1. Demonstration how this works in 2016

2. Demonstration how this behave in 2018 with the same code.

3. Demo when I disable the 2nd script 'MakeAllFreeAndPromote' but do this manually. See picture below how I disable this.

SO there is a difference of doing this automatically or manually. (And it's the same code)

Thanks for your reply

Re: inventor 2016 - 2018 issues

chandra.shekar.g — Wed, 14 Mar 2018 05:30:55 GMT

Hello @m.maertens6DTZT,

Thanks for videos,

Instead of using command "AppReturnTopCmd", Call oSubAssyOcc.ExitEdit(kExitToParent) Inventor API is used to return back to parent level. Same changes are implemented in the below code.

Public Sub MakeAlleFreeAndPromote()

' Create a transaction. -> for 1 undo command
Dim oTransMgr As TransactionManager
Set oTransMgr = ThisApplication.TransactionManager
Dim oTrans As Transaction
Set oTrans = oTransMgr.StartTransaction(ThisApplication.ActiveDocument, "MakeAlleFreeAndPromote")
  

' check if an iwall is selected
        Dim oDoc As AssemblyDocument
        Set oDoc = ThisApplication.ActiveDocument

        Dim oOcc As ComponentOccurrence
        On Error Resume Next
        Set oOcc = oDoc.SelectSet.Item(1)
        If Err Then
            GoTo TraverseNormally
        End If
        
        If oOcc.DefinitionDocumentType = kAssemblyDocumentObject Then
            If oOcc.ActiveLevelOfDetailRepresentation = "Wall" Then
               oOcc.Edit
            End If
        End If

'declare everything needed
TraverseNormally:
        Dim oDef As AssemblyComponentDefinition
        Set oDef = oDoc.ComponentDefinition
        
        Dim oAssDoc As AssemblyDocument
        Set oAssDoc = ThisApplication.ActiveEditObject
        Dim oActDef As AssemblyComponentDefinition
        Set oActDef = oAssDoc.ComponentDefinition
        
        Dim oPattern As OccurrencePattern
        Dim oPatternElement As OccurrencePatternElement
        Dim oOccurence As ComponentOccurrence
        Dim oComponent As ComponentOccurrence





        'Traverse all the patterns in the assembly:
        For Each oPattern In oAssDoc.ComponentDefinition.OccurrencePatterns
            'Traverse all elements in the pattern to make them independent:
            For Each oPatternElement In oPattern.OccurrencePatternElements
              '  On Error Resume Next
                oPatternElement.Independent = True
                If Err Then
                    Err.Clear
                    End If
            Next oPatternElement
        Next oPattern
        
        'Delete all patterns in the assembly
        For Each oPattern In oAssDoc.ComponentDefinition.OccurrencePatterns
            oPattern.Delete
        Next oPattern
        
        'delete all suppressed
        For Each oComponent In oAssDoc.ComponentDefinition.Occurrences
                If oComponent.Suppressed = True Then
                    oComponent.Delete
                End If
        Next oComponent
        
        'Unground all components
        For Each oOccurence In oAssDoc.ComponentDefinition.Occurrences
            If oOccurence.Grounded = True Then
                oOccurence.Grounded = False
            End If
        Next oOccurence
        
        'Delete all iComposites
        For Each oIcomp In oAssDoc.ComponentDefinition.iMateResults
         '   On Error Resume Next
            oIcomp.Delete
            If Err Then
            Err.Clear
            End If
        Next oIcomp
        
        'Delete all imates
        For Each oImate In oAssDoc.ComponentDefinition.iMateDefinitions
          '  On Error Resume Next
            oImate.Delete
            If Err Then
            Err.Clear
            End If
        Next oImate
        
        'Delete all constraints
        For Each oConstraint In oAssDoc.ComponentDefinition.Constraints
           ' On Error Resume Next
            oConstraint.Delete
            If Err Then
            Err.Clear
            End If
        Next oConstraint
            
        'Promote all frames

            ' Get the top level occurrence of an assembly
             Dim oSubAssyOcc As ComponentOccurrence
             
             
            ' On Error Resume Next
                     Set oSubAssyOcc = oDef.Occurrences.ItemByName(oDef.ActiveOccurrence.Name)
                      'If Err Then
                       '   MsgBox "A subassembly must be active if you want to promote it. No Subassembly will be touched"
                           
                   ' Else
                        Dim i As Integer
                        For i = 1 To oActDef.Occurrences.Count
                           
                        ' Get the 2nd level occurrence under the assembly occurrence
                        Dim oSubOcc As ComponentOccurrenceProxy
                        Set oSubOcc = oSubAssyOcc.SubOccurrences.Item(1)
                        
                        Dim oPane As BrowserPane
                        Set oPane = oDoc.BrowserPanes.Item("AmBrowserArrangement") '2017 11 05 - multilangue change
                        
                        ' Get the browser nodes corresponding to the two occurrences
                        Dim oTargetNode As BrowserNode
                        Set oTargetNode = oPane.GetBrowserNodeFromObject(oSubAssyOcc)
                        
                        
                        Dim oSourceNode As BrowserNode
                        Set oSourceNode = oPane.GetBrowserNodeFromObject(oSubOcc)
                        
                        
                        ' Reorder the nodes to promote the sub-occurrence to the top level
                        Call oPane.Reorder(oTargetNode, True, oSourceNode)
                        
                        Next
                        Call oSubAssyOcc.ExitEdit(kExitToParent)
                        ' activate one level up
                             'Dim oCtrlDef As ControlDefinition
                             'Set oCtrlDef = ThisApplication.CommandManager.ControlDefinitions.Item("AppReturnTopCmd")
                             'oCtrlDef.Execute
                                
                        ' Delete the original Subassembly
                            oSubAssyOcc.Delete
                            oSubAssyOcc.Delete
                      'End If
             On Error GoTo 0

    
' End the transaction.
    oTrans.End
End Sub

Please feel free to contact if there is any queries.

If solves problem, click on "Accept as solution" / give a "Kudo".

Thanks and regards,

Re: inventor 2016 - 2018 issues

m.maertens6DTZT — Wed, 14 Mar 2018 07:11:06 GMT

Hello @chandra.shekar.g

Wow,

This really works again.

Thanks a lot!

Now I can finalize the upgrade to inventor 2018.

Best regards,

Maarten

Re: inventor 2016 - 2018 issues

chandra.shekar.g — Wed, 14 Mar 2018 07:15:27 GMT

@m.maertens6DTZT,

That's great news!!!

My solution leads to finalize the upgrade to Inventor 2018.

Thanks and regards,

Re: inventor 2016 - 2018 issues

m.maertens6DTZT — Wed, 19 May 2021 06:48:28 GMT

Hi,

I'm here again.
Inventor 2022 crashes when I drag and drop a subassembly that includes the rule of "autoMakeAllFreeAndPromote".
Again, when I disable in the rule the line "Call MakeAllFreeAndPromote" - but I do it manually, it works fine.

Any suggestions?

Thanks

Re: inventor 2016 - 2018 issues

chandra.shekar.g — Fri, 21 May 2021 03:59:17 GMT

@m.maertens6DTZT,

Please provide non confidential video demonstrate the issue.

Thanks and regards,