topic Re: Run macro in assembly occurrences in Inventor Programming Forum

Run macro in assembly occurrences

isidro.nunez — Mon, 29 Jun 2020 14:03:02 GMT

Hello again,

I'm trying to create a rule which can be run from an assembly and update/create all the ilogics of each part in that assembly. I have a macro that works fine when I open a part one by one. This macro creates or updates all the ilogic rules, parameters and iproperties needed, no problem here.

The problem comes when I try to run a simple rule from an assembly and iterate through all the part or occurrecces.

This code is from hoppend.nl, I simply modified it a bit.

Sub Main() 'Define the Assembly Document Dim oDoc As AssemblyDocument Dim RuleName As String = "Check" ' check if active document is an assembly Try oDoc = ThisApplication.ActiveDocument Catch MessageBox.Show("Please run on assembly", "Run Rule") End Try Dim oOcc As ComponentOccurrence GoThrough: For Each oOcc In oDoc.ComponentDefinition.Occurrences 'Get Document from Occurrence Dim oOccDoc As Document oOccDoc = oOcc.Definition.Document 'Check if document is a part If oOccDoc.DocumentType = DocumentTypeEnum.kPartDocumentObject Then oOccDoc = oOcc.Definition.Document Try InventorVb.RunMacro("Default", "Importar_ilogic", "Importar_ilogic") iLogicVb.RunRule(oOccDoc.DisplayName, RuleName) 'MessageBox.Show("Rule run in: " & oOccDoc.DisplayName, "Message for debugging purposes") Catch 'MessageBox.Show("Rule not present in: " & oOccDoc.DisplayName, "Message for debugging purposes") End Try 'if the document is an assembly we need to run the same code in each occurrence of that assembly (we uses a goto function) Else If oOccDoc.DocumentType = DocumentTypeEnum.kAssemblyDocumentObject Then oDoc = oOccDoc GoTo GoThrough End If Next End Sub

And I also tried this code (just ignore the vendor check):

Dim openDoc As Document openDoc = ThisDoc.Document Dim docFile As Document If openDoc.DocumentType = 12291 Then On Error Resume Next For Each docFile In openDoc.AllReferencedDocuments If docFile.DocumentType = 12290 Then prov_data = iProperties.Value(docFile.DisplayName, "Project", "Vendor") If prov_data = "Prov1" Then InventorVb.RunMacro("Default", "Importar_ilogic", "Importar_ilogic") 'iLogicVb.RunRule("PartA:1", "ruleName") End If End If Next End If

Any idea how I can solve this?

Thank you a lot in advance.

Re: Run macro in assembly occurrences

WCrihfield — Mon, 29 Jun 2020 16:55:20 GMT

Have you tried running an empty rule with just your RunMacro line in it, to make sure you're accessing the macro correctly?

InventorVb.RunMacro("Default", "Importar_ilogic", "Importar_ilogic")

Re: Run macro in assembly occurrences

tonythm — Tue, 30 Jun 2020 04:20:01 GMT

Hello @isidro.nunez

You can try with excel vba, them will quickly and easier.

Sub UpdateParameterPartInAssy() Dim oWkbk As Workbook Set oWkbk = ThisWorkbook Dim oSheet As Worksheet Set oSheet = oWkbk.ActiveSheet Dim oInv As Inventor.Application Set oInv = GetObject(, "Inventor.Application") 'Define sheet name where information resides Dim sSheetName As String sSheetName = "Sheet1" Dim oAssy As AssemblyDocument Set oAssy = oInv.ActiveDocument Dim sParamRange As String sParamRange = "A2:A20" Dim oDoc As Document For Each oDoc In oAssy.AllReferencedDocuments If oDoc.DocumentType = kPartDocumentObject Then Dim oPartDoc As PartDocument Set oPartDoc = oDoc Dim oUserParams As UserParameters Set oUserParams = oPartDoc.ComponentDefinition.Parameters.UserParameters Dim oUserParam As UserParameter Dim oPartNumProperty As Property Set oPartNumProperty = oDoc.PropertySets.Item("Design Tracking Properties").Item("Part Number") For Each oCell In oSheet.Range(sParamRange) For Each oUserParam In oUserParams If oCell.Value = oPartNumProperty.Value Then If Range("B1").Value = oUserParam.Name Then oUserParam.Expression = oCell.Offset(0, 1).Value & oCell.Offset(0, 3).Value End If End If Next Next End If Next End Sub

Re: Run macro in assembly occurrences

isidro.nunez — Tue, 30 Jun 2020 06:12:31 GMT

Hi @WCrihfield , I have tried that single line in a part and is working. However, when executed in the codes I posted before, the macro seems it's runing at the assembly level. Any way to force a macro to run in an assembly occurrence?

Thanks

Re: Run macro in assembly occurrences

marcin_otręba — Tue, 30 Jun 2020 06:15:06 GMT

when you want to use:

iLogicVb.RunRule("PartA:1", "ruleName")

"PartA:1" - it is occurrence name inside assembly from wchich you run rule.

so in your code you should change:

iLogicVb.RunRule(oOccDoc.DisplayName, RuleName)

iLogicVb.RunRule(oOcc.Name, RuleName)

and it should be ok.

Re: Run macro in assembly occurrences

isidro.nunez — Tue, 30 Jun 2020 06:16:29 GMT

Hi @tonythm , thanks for the code, but how I use it in my case? I have an unknown number of components in each assembly, and in some case, there are auxiliary sub-assemblies. I need to run a macro that is working right now and run another ilogic rule after the macro run.

Thank you

Re: Run macro in assembly occurrences

isidro.nunez — Tue, 30 Jun 2020 06:25:38 GMT

Thank you @marcin_otręba , I fix that but the InventorVb.RunMacro is still running in assembly level, so the rule is not in the occurrence. Thats why I need to run the macro before.

I have pieces without ilogic rules on them, so I need to create them with that macro.

Re: Run macro in assembly occurrences

marcin_otręba — Tue, 30 Jun 2020 06:37:36 GMT

what this macro actually do ?

Re: Run macro in assembly occurrences

marcin_otręba — Tue, 30 Jun 2020 06:40:39 GMT

Check this one:

https://adndevblog.typepad.com/manufacturing/2015/11/pass-parameters-to-a-vba-macro-from-an-ilogic-rule.html

you can have parameter doc as document in your macro and pass it to it using oocc.definition.document.

Re: Run macro in assembly occurrences

isidro.nunez — Tue, 30 Jun 2020 06:47:21 GMT

@marcin_otrębathe macro does the following:

-Read the rules .txt files from a server.

-Create iLogic rules in the part and paste the codes from the server. If there was rules, it updates them.

-Create the parameters needed for the imported rules.

-Set the event triggers for all the rules as needed.

Thank you

Re: Run macro in assembly occurrences

isidro.nunez — Tue, 30 Jun 2020 06:49:21 GMT

I will try this, thanks!

Re: Run macro in assembly occurrences

tonythm — Tue, 30 Jun 2020 06:51:34 GMT

Hi @isidro.nunez

You should be know Part Number of part in Assy. You place them into new file assy(include only part) for refer to input parameter. After that use excel file run macro.

Excel vba control everything you need.

Re: Run macro in assembly occurrences

_dscholtes_ — Tue, 30 Jun 2020 08:28:08 GMT

I removed some code for clarity and it quickly shows this code will not do what you want it to do: process all components in the assembly (even sub-assemblies).

Sub Main() GoThrough: For Each oOcc In oDoc.ComponentDefinition.Occurrences 'Get Document from Occurrence Dim oOccDoc As Document oOccDoc = oOcc.Definition.Document 'Check if document is a part If oOccDoc.DocumentType = DocumentTypeEnum.kPartDocumentObject Then oOccDoc = oOcc.Definition.Document <do something> 'if the document is an assembly we need to run the same code in each occurrence of that assembly (we uses a goto function) Else If oOccDoc.DocumentType = DocumentTypeEnum.kAssemblyDocumentObject Then oDoc = oOccDoc GoTo GoThrough End If Next End Sub

Lets say halfway through processing the occurrences in your top assembly, you find an occurrence representing a sub-assembly. Through the lines 'oDoc = oOccDoc' and 'Goto GoThrough' you think you continue with the sub assembly, but even if that would happen, there is no code to return back to the top assembly, meaning the occurrences below the sub-assembly in the top assembly are never processed.

I deliberately stated 'you think' and 'even if that would happen' because what actually happens is that the line 'oDoc = oOccDoc' messes up the loop created by 'For Each oOcc In oDoc.ComponentDefinition.Occurrences'.

I wonder why you want to go through all the occurrences and get their documents when it's possible to go through all documents directly. You can read a clear article about accessing assembly components, including example code, by Brian Ekins here. It has helped me a lot.

Re: Run macro in assembly occurrences

isidro.nunez — Tue, 30 Jun 2020 09:02:57 GMT

Hi @_dscholtes_ , as I said before, that code is from hoppend.nl , I just modified the minimun. I see the problem, but right now it's not running the macro, the main task of these rules.

If you look at my original post, you can see that I have used both, occurrences and documents in assembly, but the macro is not running on part level, only on assembly level.

I will try to modify the macro as suggested by @marcin_otręba

Thank you

Re: Run macro in assembly occurrences

WCrihfield — Tue, 30 Jun 2020 13:12:44 GMT

You may need to change your macro from using ThisApplication.ActiveDocument to ThisDoc.Document.

Or perhaps you need to modify your Macro to accept a variable, then pass the part document to the Macro as you would a reference within a Sub or Function.

Re: Run macro in assembly occurrences

isidro.nunez — Tue, 30 Jun 2020 13:50:29 GMT

Hi @WCrihfield , when I change ThisApplication.ActiveDocument to ThisDoc.Document, it gives me an error, "ThisDoc is not defined"

Option Explicit Sub Importar_ilogic() Dim i As Object Set i = GetiLogicAddin(ThisApplication) Dim oDoc As Document Set oDoc = ThisDoc.Document Call Parametros <here the macro call other subs and functions> End Sub

I had before this code:

Dim oDoc As Inventor.Document Set oDoc = ThisApplication.ActiveDocument

Thank you

Re: Run macro in assembly occurrences

_dscholtes_ — Tue, 30 Jun 2020 14:14:44 GMT

@isidro.nunez ThisDoc is used in iLogic (rules), not in VBA (macro). Your original code using ThisApplication.ActiveDocument is correct.

Re: Run macro in assembly occurrences

isidro.nunez — Tue, 30 Jun 2020 14:27:43 GMT

Hi @_dscholtes_ , I just saw it in the help:

I tried a few week before to do it with iLogic, but I couldn't manage to create rules.

Thank you

Re: Run macro in assembly occurrences

WCrihfield — Tue, 30 Jun 2020 16:25:03 GMT

That's right. For some reason I was thinking if your Macro was a simple one that is just running some other external iLogic rules. My mistake. But the second suggestion is still valid.

Can you share your other Macro codes here so we can see the full picture of what's going on.

We can most likely find a way to keep it all either in iLogic or all in VBA, to make it simpler for you.

Or, if sharing the code isn't possible, due to privacy or proprietary info concerns, you may be able to create a very simplified assembly, iLogic rule, & macro that we can all use to test, as a proof of concept.

I know you can pass variables and values back and forth between iLogic rules, between VBA macros. and between rules & macros.

Otherwise, I'm not sure how your macro can know which specific part within your active assembly you want it to run on.

Re: Run macro in assembly occurrences

_dscholtes_ — Tue, 30 Jun 2020 17:18:19 GMT

@isidro.nunez If I understand correctly, you have a part file with a rule in it. You don't want to open the part file to run the rule. You want to open an assembly containing that part and have a macro run this rule.

This works for me:

Private Sub RunPartRule() 'Set reference to open document Dim oDoc As Document Set oDoc = ThisApplication.ActiveEditDocument 'Check if it's an assembly. If so, quit If Not oDoc.DocumentType = kAssemblyDocumentObject Then Exit Sub 'Initiate the iLogic component (required to run an rule) Dim iLogicAuto As Object Set iLogicAuto = GetiLogicAddin(ThisApplication) If (iLogicAuto Is Nothing) Then Exit Sub 'Declaration Dim oRefDoc As Document 'Go through each document in the assembly document For Each oRefDoc In oDoc.ReferencedDocuments 'Check if it's a part document If oRefDoc.DocumentType = kPartDocumentObject Then 'Run the rule named "Rule0" from within the part document iLogicAuto.RunRule oRefDoc, "Rule0" End If Next End Sub

The above code requires the following sub

Public Function GetiLogicAddin(oApplication As Inventor.Application) As Object Dim addIn As ApplicationAddIn On Error GoTo NotFound Set addIn = oApplication.ApplicationAddIns.ItemById("{3bdd8d79-2179-4b11-8a5a-257b1c0263ac}") If (addIn Is Nothing) Then Exit Function addIn.Activate Set GetiLogicAddin = addIn.Automation Exit Function NotFound: End Function

When I run the macro "RunPartRule" in my openend test assembly, it successfully runs the rule "Rule0" which is in my test part file.

So, this code only processes the open assembly. It doesn't process sub assemblies. For this to happen, you need a recursive function. You can find an example in the link I posted earlier, but recursive functions have been discussed in various blogs and posts. Or just ask any of the helpful guys here.