Community
@Anonymous wrote:....
;check the group code 0 to see if entity type = TEXT
(if (cond ((= et "TEXT")(setq str (cdr (assoc 1 enlist))))
((= et "MTEXT")
;COMBINE GROUP 3's AND GROUP 1's INTO ONE STRING
(setq str (vl-remove-if-not '(lambda (q)(or (= (car q) 3)(= (car q) 1))) enlist)
str (apply 'strcat (mapcar 'cdr cs))
)
)
((and (= et "INSERT")(= (cdr (assoc 66 enlist)) 1))
(setq ne (entnext en))
(while (and ne (= (cdr (assoc 0 (setq ned (entget ne)))) "ATTRIB"))
(setq str (cdr (assoc 1 ned))
ne (entnext ne)
)
(cond
((= (cdr(assoc 8 enlist)) "TBNO") (setq TBNOList (append TBNOList (list str))))
((= (cdr(assoc 8 enlist)) "WIRENO")(setq WIRENOList(append WIRENOList (list str))))
((= (cdr(assoc 8 enlist)) "DEVID") (setq DEVIDList(append DEVIDList (list str))))
)
)
nil
)
)
.... When adding it to the program it outputs some of the items but not all of them. Also the program is inserting a lot of blank spaces at the beginning. ....
I don't know whether these will explain your problems, but....
I don't understand what the
nil
line is there for.
It also looks [in the context of the larger routine] like the last attribute in any Block will be added to the list twice, because you add each one inside the (cond) that checks entity type, and you then add the 'str' variable [which would be the last attribute if the entity is a Block] after it's looked at all entity-type conditions.
Maybe instead of having that (if) function enclosing the (cond) function, you should skip the (if), and have the adding-to-the-appropriate-list happen within each entity-type condition, so that it adds just the single content for Text or Mtext, but adds each attribute for Blocks.
And I still think [as I suggested in one of your earlier threads] that you should try (write-line) instead of (princ) in your (prinFile) function [not included in this latest post, but earlier]. It will spare you the need to force the new-line "\n" with another (princ) there, and might possibly get rid of your blank-lines problem.
And I still think you can eliminate a (cond) function and add each piece of text content to the appropriate list with one line of code that builds the list name using the layer name, with a (set) function, as I suggested on one of your earlier threads.
Kent Cooper, AIA 
@Anonymous wrote:Kent,
I am having a hard time following our intended changes do you think you could rewrite the script with the changes you thought should be? If so it would be awesome.
....
Very quickly, perhaps something like the attached. I eliminated some unused and unnecessary things, pared down some of the commentary, incorporated my earlier suggestions, and raised one question. I also realized there's an easier way to filter for things on multiple layers, using comma-delimited layer names, just as you can filter for multiple entity types, in (wcmatch) format. Only bits and pieces have been tested, since I don't have the drawing or directory setup you do.
Kent Cooper, AIA
@Anonymous wrote:The problem I am having with the program is coming from the section of code:
....
;COMBINE GROUP 3's AND GROUP 1's INTO ONE STRING
(setq str (vl-remove-if-not '(lambda (q)(or (= (car q) 3)(= (car q) 1))) enlist)
str (apply 'strcat (mapcar 'cdr cs))
)
....
I hadn't looked closely at that part before, since I must have a too-old version to have the 3 entry. But looking at it again, I notice that it calls for a 'cs' variable, which the routine does not set. Should that second setting of 'str' be:
str (apply 'strcat (mapcar 'cdr str))
instead? If so, that is not fixed in the test.lsp file I attached to my last post.
Kent Cooper, AIA
@Anonymous wrote:Yeah the same error is still showing. The program asks for the number of times wireno should output but then is guves me the error: ; error: bad argument type: stringp nil
Since that's the last piece of User input, it could be anywhere after that. I looked for something, and didn't notice any obvious causes. I wondered whether I had gotten all the (set)/(read)/(eval) things right in my routine's consolidation of the list-making, but it shouldn't be from that, if you're getting the same problem with rbt's version that doesn't use that approach.
But it could even be in your srtAN or prinFile functions. Make yourself a valid list of text strings and try those on it, outside of the larger routine.
Or, comment out the localized variables list, like this if in my routine:
(defun C:ESBTEXT2 ();/ rep lts cntr eset en enlist et str laylist ne ned)
and run it. See how many of the variables have been set before it runs into trouble, by typing each variable name with an exclamation point before it:
!rep
!lts
etc., until one of those returns nil. That should give you some way of narrowing down where the problem lies.
[When it's been isolated and fixed, take out the ); in the altered line above.]
Kent Cooper, AIA
![Autodesk Design & Make Report](https://forums.autodesk.com/t5/image/serverpage/image-id/1350519iCB55845EBFC43016/image-size/large?v=v2&px=999" "Autodesk Design & Make Report")
